Changeset 56976 in webkit

Timestamp:

Apr 2, 2010 12:04:50 AM (14 years ago)

Author:

eric@webkit.org

Message:

2010-04-01 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Add cr-win-ews
​https://bugs.webkit.org/show_bug.cgi?id=36974

Adds support for an Early Warning System for Chromium on Linux. The
interface to the Chromium port is the same on every platform, so we
don't need to create a new Port object for this queue.

• Scripts/webkitpy/tool/commands/earlywarningsystem.py:
• Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:

Location:

trunk/WebKitTools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/webkitpy/tool/commands/earlywarningsystem.py (modified) (1 diff)
• Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py (modified) (3 diffs)

trunk/WebKitTools/ChangeLog

@@ +1 @@
+2010-04-01  Adam Barth  <abarth@webkit.org>
+
+        Reviewed by Eric Seidel.
+
+        Add cr-win-ews
+        https://bugs.webkit.org/show_bug.cgi?id=36974
+
+        Adds support for an Early Warning System for Chromium on Linux.  The
+        interface to the Chromium port is the same on every platform, so we
+        don't need to create a new Port object for this queue.
+
+        * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
+        * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
+
 2010-04-01  Adam Barth  <abarth@webkit.org>
 

trunk/WebKitTools/Scripts/webkitpy/tool/commands/earlywarningsystem.py

@@ -119 +119 @@
 
 
-class ChromiumEWS(AbstractEarlyWarningSystem):
-    name = "chromium-ews"
+class AbstractChromiumEWS(AbstractEarlyWarningSystem):
     port_name = "chromium"
     watchers = AbstractEarlyWarningSystem.watchers + [
         "dglazkov@chromium.org",
     ]
+
+
+class ChromiumLinuxEWS(AbstractChromiumEWS):
+    # FIXME: We should rename this command to cr-linux-ews, but that requires
+    #        a database migration. :(
+    name = "chromium-ews"
+
+
+class ChromiumWindowsEWS(AbstractChromiumEWS):
+    name = "cr-win-ews"
 
 

trunk/WebKitTools/Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py

@@ -35 +35 @@
 class EarlyWarningSytemTest(QueuesTest):
     def test_failed_builds(self):
-        ews = ChromiumEWS()
+        ews = ChromiumLinuxEWS()
         ews._build = lambda patch, first_run=False: False
         ews._can_build = lambda: True
         ews.review_patch(Mock())
 
-    def test_chromium_ews(self):
+    def test_chromium_linux_ews(self):
         expected_stderr = {
-            "begin_work_queue" : "CAUTION: chromium-ews will discard all local changes in \"%s\"\nRunning WebKit chromium-ews.\n" % os.getcwd(),
-            "handle_unexpected_error" : "Mock error message\n",
+            "begin_work_queue": "CAUTION: chromium-ews will discard all local changes in \"%s\"\nRunning WebKit chromium-ews.\n" % os.getcwd(),
+            "handle_unexpected_error": "Mock error message\n",
         }
-        self.assert_queue_outputs(ChromiumEWS(), expected_stderr=expected_stderr)
+        self.assert_queue_outputs(ChromiumLinuxEWS(), expected_stderr=expected_stderr)
+
+    def test_chromium_windows_ews(self):
+        expected_stderr = {
+            "begin_work_queue": "CAUTION: cr-win-ews will discard all local changes in \"%s\"\nRunning WebKit cr-win-ews.\n" % os.getcwd(),
+            "handle_unexpected_error": "Mock error message\n",
+        }
+        self.assert_queue_outputs(ChromiumWindowsEWS(), expected_stderr=expected_stderr)
 
     def test_qt_ews(self):
         expected_stderr = {
-            "begin_work_queue" : "CAUTION: qt-ews will discard all local changes in \"%s\"\nRunning WebKit qt-ews.\n" % os.getcwd(),
-            "handle_unexpected_error" : "Mock error message\n",
+            "begin_work_queue": "CAUTION: qt-ews will discard all local changes in \"%s\"\nRunning WebKit qt-ews.\n" % os.getcwd(),
+            "handle_unexpected_error": "Mock error message\n",
         }
         self.assert_queue_outputs(QtEWS(), expected_stderr=expected_stderr)
@@ -56 +63 @@
     def test_gtk_ews(self):
         expected_stderr = {
-            "begin_work_queue" : "CAUTION: gtk-ews will discard all local changes in \"%s\"\nRunning WebKit gtk-ews.\n" % os.getcwd(),
-            "handle_unexpected_error" : "Mock error message\n",
+            "begin_work_queue": "CAUTION: gtk-ews will discard all local changes in \"%s\"\nRunning WebKit gtk-ews.\n" % os.getcwd(),
+            "handle_unexpected_error": "Mock error message\n",
         }
         self.assert_queue_outputs(GtkEWS(), expected_stderr=expected_stderr)
@@ -63 +70 @@
     def test_mac_ews(self):
         expected_stderr = {
-            "begin_work_queue" : "CAUTION: mac-ews will discard all local changes in \"%s\"\nRunning WebKit mac-ews.\n" % os.getcwd(),
-            "handle_unexpected_error" : "Mock error message\n",
+            "begin_work_queue": "CAUTION: mac-ews will discard all local changes in \"%s\"\nRunning WebKit mac-ews.\n" % os.getcwd(),
+            "handle_unexpected_error": "Mock error message\n",
         }
         self.assert_queue_outputs(MacEWS(), expected_stderr=expected_stderr)