Changeset 56985 in webkit


Ignore:
Timestamp:
Apr 2, 2010 1:18:11 AM (14 years ago)
Author:
abarth@webkit.org
Message:

2010-04-02 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Tweak rollout changelog to pass ValidateReviewer check
​https://bugs.webkit.org/show_bug.cgi?id=37019

We need to use the magic word "unreviewed" to make the commit-queue
happy when landing rollouts.

  • Scripts/webkitpy/common/checkout/changelog.py:
  • Scripts/webkitpy/common/checkout/changelog_unittest.py:
Location:
trunk/WebKitTools
Files:
3 edited

Legend:

Unmodified
Added
Removed

  • trunk/WebKitTools/ChangeLog

    r56983 r56985  
     12010-04-02  Adam Barth  <abarth@webkit.org>
     2
     3        Reviewed by Eric Seidel.
     4
     5        Tweak rollout changelog to pass ValidateReviewer check
     6        https://bugs.webkit.org/show_bug.cgi?id=37019
     7
     8        We need to use the magic word "unreviewed" to make the commit-queue
     9        happy when landing rollouts.
     10
     11        * Scripts/webkitpy/common/checkout/changelog.py:
     12        * Scripts/webkitpy/common/checkout/changelog_unittest.py:
     13
    1142010-04-02  Chris Jerdonek  <cjerdonek@webkit.org>
    215

  • trunk/WebKitTools/Scripts/webkitpy/common/checkout/changelog.py

    r56632 r56985  
    142142    # This probably does not belong in changelogs.py
    143143    def _message_for_revert(self, revision, reason, bug_url):
    144         message = "No review, rolling out r%s.\n" % revision
     144        message = "Unreviewed, rolling out r%s.\n" % revision
    145145        message += "%s\n" % view_source_url(revision)
    146146        if bug_url:

  • trunk/WebKitTools/Scripts/webkitpy/common/checkout/changelog_unittest.py

    r56510 r56985  
    130130        self.assertEquals(actual_contents, expected_contents)
    131131
    132     _revert_message = """        No review, rolling out r12345.
     132    _revert_message = """        Unreviewed, rolling out r12345.
    133133        http://trac.webkit.org/changeset/12345
    134134        http://example.com/123
    … …  
    149149    _revert_entry_with_bug_url = '''2009-08-19  Eric Seidel  <eric@webkit.org>
    150150
    151         No review, rolling out r12345.
     151        Unreviewed, rolling out r12345.
    152152        http://trac.webkit.org/changeset/12345
    153153        http://example.com/123
    … …  
    160160    _revert_entry_without_bug_url = '''2009-08-19  Eric Seidel  <eric@webkit.org>
    161161
    162         No review, rolling out r12345.
     162        Unreviewed, rolling out r12345.
    163163        http://trac.webkit.org/changeset/12345
    164164
Note: See TracChangeset for help on using the changeset viewer.