Changeset 56986 in webkit
- Timestamp:
- Apr 2, 2010 1:18:44 AM (14 years ago)
- Location:
- trunk/WebKitTools
- Files:
-
- 2 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/WebKitTools/ChangeLog
r56985 r56986 1 2010-04-02 Adam Barth <abarth@webkit.org> 2 3 Reviewed by Eric Seidel. 4 5 The master commit-queue process should take responsibility for checking that the builders are green 6 https://bugs.webkit.org/show_bug.cgi?id=37009 7 8 We had a failure where the child process noticed that the builders were 9 red. We've always had this race condition, but the new optimistic 10 design made it easier to trigger. 11 12 * Scripts/webkitpy/tool/commands/queues.py: 13 1 14 2010-04-02 Adam Barth <abarth@webkit.org> 2 15 -
trunk/WebKitTools/Scripts/webkitpy/tool/commands/queues.py
r56947 r56986 206 206 def _land(self, patch, first_run=False): 207 207 try: 208 if not self._builders_are_green(): 209 # We return true here because we want to return to the main 210 # QueueEngine loop as quickly as possible. 211 return True 208 212 args = [ 209 213 "land-attachment", 210 214 "--force-clean", 211 215 "--non-interactive", 216 # The master process is responsible for checking the status 217 # of the builders (see above call to _builders_are_green). 218 "--ignore-builders", 212 219 "--build-style=both", 213 220 "--quiet",
Note: See TracChangeset
for help on using the changeset viewer.