Changeset 57015 in webkit

Timestamp:

Apr 2, 2010 12:21:53 PM (14 years ago)

Author:

eric@webkit.org

Message:

2010-04-02 Zhenyao Mo <​zmo@google.com>

Reviewed by Eric Seidel.

fast/canvas/webgl/index-validation.html failed on Leopard Commit Bot
​https://bugs.webkit.org/show_bug.cgi?id=36908

• fast/canvas/webgl/index-validation-expected.txt: Gathering more information about the cause of the failure. It's not a fix, and it won't worse change the current test behavior either, i.e., it won't make it better or worse.
• fast/canvas/webgl/script-tests/index-validation.js: Ditto.

Location:

trunk/LayoutTests

Files:

• ChangeLog (modified) (1 diff)
• fast/canvas/webgl/index-validation-expected.txt (modified) (1 diff)
• fast/canvas/webgl/script-tests/index-validation.js (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2010-04-02  Zhenyao Mo  <zmo@google.com>
+
+        Reviewed by Eric Seidel.
+
+        fast/canvas/webgl/index-validation.html failed on Leopard Commit Bot
+        https://bugs.webkit.org/show_bug.cgi?id=36908
+
+        * fast/canvas/webgl/index-validation-expected.txt: Gathering more information about the cause of the failure.  It's not a fix, and it won't worse change the current test behavior either, i.e., it won't make it better or worse.
+        * fast/canvas/webgl/script-tests/index-validation.js: Ditto.
+
 2010-04-02  Kent Tamura  <tkent@chromium.org>
 

trunk/LayoutTests/fast/canvas/webgl/index-validation-expected.txt

@@ -3 +3 @@
 On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
 
+PASS gl.checkFramebufferStatus(gl.FRAMEBUFFER) is gl.FRAMEBUFFER_COMPLETE
 PASS gl.getError() is 0
 PASS gl.drawElements(gl.TRIANGLES, 3, gl.UNSIGNED_SHORT, 0) is undefined.

trunk/LayoutTests/fast/canvas/webgl/script-tests/index-validation.js

@@ -26 +26 @@
 gl.vertexAttribPointer(normalLoc, 3, gl.FLOAT, false, 7 * gl.sizeInBytes(gl.FLOAT), 3 * gl.sizeInBytes(gl.FLOAT));
 gl.enableVertexAttribArray(normalLoc);
+shouldBe('gl.checkFramebufferStatus(gl.FRAMEBUFFER)', 'gl.FRAMEBUFFER_COMPLETE');
 shouldBe('gl.getError()', '0');
 shouldBeUndefined('gl.drawElements(gl.TRIANGLES, 3, gl.UNSIGNED_SHORT, 0)');