Changeset 57106 in webkit


Ignore:
Timestamp:
Apr 5, 2010 5:18:33 PM (14 years ago)
Author:
eric@webkit.org
Message:

2010-04-05 Zhenyao Mo <​zmo@google.com>

Reviewed by Darin Adler.

A few tests in fast/canvas/webgl/ failed on Leopard Release Bot randomly.
​https://bugs.webkit.org/show_bug.cgi?id=37077
​https://bugs.webkit.org/show_bug.cgi?id=37098

  • fast/canvas/webgl/drawArraysOutOfBounds-expected.txt: Gathering more information about framebuffer status when failure happens.
  • fast/canvas/webgl/drawArraysOutOfBounds.html: Ditto.
  • fast/canvas/webgl/drawElementssOutOfBounds-expected.txt: Ditto.
  • fast/canvas/webgl/drawElementssOutOfBounds.html: Ditto.
  • fast/canvas/webgl/index-validation-copies-indices-expected.txt: Ditto.
  • fast/canvas/webgl/index-validation-copies-indices.html: Ditto.
Location:
trunk/LayoutTests
Files:
7 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r57105 r57106  
     12010-04-05  Zhenyao Mo  <zmo@google.com>
     2
     3        Reviewed by Darin Adler.
     4
     5        A few tests in fast/canvas/webgl/ failed on Leopard Release Bot randomly.
     6        https://bugs.webkit.org/show_bug.cgi?id=37077
     7        https://bugs.webkit.org/show_bug.cgi?id=37098
     8
     9        * fast/canvas/webgl/drawArraysOutOfBounds-expected.txt: Gathering more information about framebuffer status when failure happens.
     10        * fast/canvas/webgl/drawArraysOutOfBounds.html: Ditto.
     11        * fast/canvas/webgl/drawElementssOutOfBounds-expected.txt: Ditto.
     12        * fast/canvas/webgl/drawElementssOutOfBounds.html: Ditto.
     13        * fast/canvas/webgl/index-validation-copies-indices-expected.txt: Ditto.
     14        * fast/canvas/webgl/index-validation-copies-indices.html: Ditto.
     15
    1162010-04-05  Yuta Kitamura  <yutak@chromium.org>
    217

  • trunk/LayoutTests/fast/canvas/webgl/drawArraysOutOfBounds-expected.txt

    r51970 r57106  
    1414
    1515Test buffer with 3 float vectors
     16PASS context.checkFramebufferStatus(context.FRAMEBUFFER) is context.FRAMEBUFFER_COMPLETE
    1617PASS context.drawArrays(context.TRIANGLES, 0, 3) is undefined
    1718PASS context.drawArrays(context.TRIANGLES, 3, 2) threw exception GL error 1282 in drawArrays.

  • trunk/LayoutTests/fast/canvas/webgl/drawArraysOutOfBounds.html

    r51970 r57106  
    3636context.bufferData(context.ARRAY_BUFFER, new WebGLFloatArray([ 0,0.5,0, -0.5,-0.5,0, 0.5,-0.5,0 ]), context.STATIC_DRAW);
    3737context.vertexAttribPointer(0, 3, context.FLOAT, false, 0, 0);
     38shouldBe("context.checkFramebufferStatus(context.FRAMEBUFFER)", "context.FRAMEBUFFER_COMPLETE");
    3839shouldBe("context.drawArrays(context.TRIANGLES, 0, 3)", "undefined");
    3940shouldThrow("context.drawArrays(context.TRIANGLES, 3, 2)");

  • trunk/LayoutTests/fast/canvas/webgl/drawElementssOutOfBounds-expected.txt

    r51970 r57106  
    1313
    1414Test buffer with 3 byte indexes
     15PASS context.checkFramebufferStatus(context.FRAMEBUFFER) is context.FRAMEBUFFER_COMPLETE
    1516PASS context.drawElements(context.TRIANGLES, 3, context.UNSIGNED_BYTE, 0) is undefined
    1617PASS context.drawElements(context.TRIANGLES, 3, context.UNSIGNED_BYTE, 2) threw exception GL error 1282 in drawElements.

  • trunk/LayoutTests/fast/canvas/webgl/drawElementssOutOfBounds.html

    r51970 r57106  
    3939context.bindBuffer(context.ELEMENT_ARRAY_BUFFER, indexObject);
    4040context.bufferData(context.ELEMENT_ARRAY_BUFFER, new WebGLUnsignedByteArray([ 0, 1, 2 ]), context.STATIC_DRAW);
     41shouldBe("context.checkFramebufferStatus(context.FRAMEBUFFER)", "context.FRAMEBUFFER_COMPLETE");
    4142shouldBe("context.drawElements(context.TRIANGLES, 3, context.UNSIGNED_BYTE, 0)", "undefined");
    4243shouldThrow("context.drawElements(context.TRIANGLES, 3, context.UNSIGNED_BYTE, 2)");

  • trunk/LayoutTests/fast/canvas/webgl/index-validation-copies-indices-expected.txt

    r52700 r57106  
    44
    55Regression test for https://bugs.webkit.org/show_bug.cgi?id=32748 : Index validation code must always copy client data
     6PASS context.checkFramebufferStatus(context.FRAMEBUFFER) is context.FRAMEBUFFER_COMPLETE
    67PASS context.drawElements(context.TRIANGLE_STRIP, 4, context.UNSIGNED_SHORT, 2) is undefined.
    78PASS context.drawElements(context.TRIANGLE_STRIP, 4, context.UNSIGNED_SHORT, 0) threw exception GL error 1282 in drawElements.
    89PASS context.drawElements(context.TRIANGLE_STRIP, 4, context.UNSIGNED_SHORT, 4) threw exception GL error 1282 in drawElements.
     10PASS context.checkFramebufferStatus(context.FRAMEBUFFER) is context.FRAMEBUFFER_COMPLETE
    911PASS context.drawElements(context.TRIANGLE_STRIP, 4, context.UNSIGNED_SHORT, 2) is undefined.
    1012PASS context.drawElements(context.TRIANGLE_STRIP, 4, context.UNSIGNED_SHORT, 0) threw exception GL error 1282 in drawElements.

  • trunk/LayoutTests/fast/canvas/webgl/index-validation-copies-indices.html

    r52700 r57106  
    3030var indices = new WebGLUnsignedShortArray([ 10000, 0, 1, 2, 3, 10000 ]);
    3131context.bufferData(context.ELEMENT_ARRAY_BUFFER, indices, context.STATIC_DRAW);
     32shouldBe('context.checkFramebufferStatus(context.FRAMEBUFFER)', 'context.FRAMEBUFFER_COMPLETE');
    3233shouldBeUndefined("context.drawElements(context.TRIANGLE_STRIP, 4, context.UNSIGNED_SHORT, 2)");
    3334shouldThrow("context.drawElements(context.TRIANGLE_STRIP, 4, context.UNSIGNED_SHORT, 0)");
    … …  
    3536indices[0] = 2;
    3637indices[5] = 1;
     38shouldBe("context.checkFramebufferStatus(context.FRAMEBUFFER)", "context.FRAMEBUFFER_COMPLETE");
    3739shouldBeUndefined("context.drawElements(context.TRIANGLE_STRIP, 4, context.UNSIGNED_SHORT, 2)");
    3840shouldThrow("context.drawElements(context.TRIANGLE_STRIP, 4, context.UNSIGNED_SHORT, 0)");
Note: See TracChangeset for help on using the changeset viewer.