Changeset 57148 in webkit

Timestamp:

Apr 6, 2010 7:32:49 AM (14 years ago)

Author:

tonikitoo@webkit.org

Message:

Remove unused DIRECTIONAL_PAD_NAVIGATION
​https://bugs.webkit.org/show_bug.cgi?id=37134

Reviewed by Laszlo Gombos.
Patch by Antonio Gomes <​tonikitoo@webkit.org>

Android browser was planning to have a "directional pad navigation" available on
trunk, under a build guard called DIRECTIONAL_PAD_NAVIGATION, but according to
​https://bugs.webkit.org/show_bug.cgi?id=23145#c3 , the plan was dropped.

However bug 23163 landed some code relying on the build flag supposedly to be added,
and is now dead code in trunk.

• dom/Element.cpp:

(WebCore::Element::updateFocusAppearance):

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• dom/Element.cpp (modified) (1 diff)

trunk/WebCore/ChangeLog

@@ +1 @@
+2010-04-05  Antonio Gomes  <tonikitoo@webkit.org>
+
+        Reviewed by Laszlo Gombos.
+
+        Remove unused DIRECTIONAL_PAD_NAVIGATION
+        https://bugs.webkit.org/show_bug.cgi?id=37134
+
+        Android browser was planning to have a "directional pad navigation" available on
+        trunk, guarded by a build flag named DIRECTIONAL_PAD_NAVIGATION, but according to
+        https://bugs.webkit.org/show_bug.cgi?id=23145#c3 , the plan was dropped.
+
+        However bug 23163 landed some code relying on the build flag supposedly to be added,
+        and is now dead code in trunk.
+
+        * dom/Element.cpp:
+        (WebCore::Element::updateFocusAppearance):
+
 2010-04-06  Mattias Nissler  <mnissler@chromium.org>
 

trunk/WebCore/dom/Element.cpp

@@ -1338 +1338 @@
             frame->revealSelection();
         }
-    }
-    // FIXME: I'm not sure all devices will want this off, but this is
-    // currently turned off for Android.
-#if !ENABLE(DIRECTIONAL_PAD_NAVIGATION)
-    else if (renderer() && !renderer()->isWidget())
+    } else if (renderer() && !renderer()->isWidget())
         renderer()->enclosingLayer()->scrollRectToVisible(getRect());
-#endif
 }