Changeset 57163 in webkit

Timestamp:

Apr 6, 2010 12:50:58 PM (14 years ago)

Author:

eric@webkit.org

Message:

2010-04-06 Simon Hausmann <​simon.hausmann@nokia.com>

Reviewed by Darin Adler.

JS code generator does not support feature conditional attributes that are writable
​https://bugs.webkit.org/show_bug.cgi?id=37149

Write out the feature #ifdef not only for the getter, but also for the setter
function.

• bindings/scripts/CodeGeneratorJS.pm:

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• bindings/scripts/CodeGeneratorJS.pm (modified) (2 diffs)

trunk/WebCore/ChangeLog

@@ +1 @@
+2010-04-06  Simon Hausmann  <simon.hausmann@nokia.com>
+
+        Reviewed by Darin Adler.
+
+        JS code generator does not support feature conditional attributes that are writable
+        https://bugs.webkit.org/show_bug.cgi?id=37149
+
+        Write out the feature #ifdef not only for the getter, but also for the setter
+        function.
+
+        * bindings/scripts/CodeGeneratorJS.pm:
+
 2010-04-06  Evan Stade  <estade@chromium.org>
 

trunk/WebCore/bindings/scripts/CodeGeneratorJS.pm

@@ -1467 +1467 @@
                         my $implSetterFunctionName = $codeGenerator->WK_ucfirst($name);
 
+                        my $conditional = $attribute->signature->extendedAttributes->{"Conditional"};
+                        if ($conditional) {
+                            $conditionalString = "ENABLE(" . join(") && ENABLE(", split(/&/, $conditional)) . ")";
+                            push(@implContent, "#if ${conditionalString}\n");
+                        }
+
                         push(@implContent, "void ${putFunctionName}(ExecState* exec, JSObject* thisObject, JSValue value)\n");
                         push(@implContent, "{\n");
@@ -1535 +1541 @@
                         }
                         
-                        push(@implContent, "}\n\n");
+                        push(@implContent, "}\n");
+
+                        if ($conditional) {
+                            push(@implContent, "#endif\n");
+                        }
+
+                        push(@implContent, "\n");
                     }
                 }