Changeset 57178 in webkit

Timestamp:

Apr 6, 2010 4:36:41 PM (14 years ago)

Author:

eric@webkit.org

Message:

2010-04-06 Chris Evans <​cevans@chromium.org>

Reviewed by Adam Barth.

Add test for javascript:window.open() popup blocker bypass.
​https://bugs.webkit.org/show_bug.cgi?id=37138

• fast/events/popup-blocked-from-window-open.html: added
• fast/events/popup-blocked-from-window-open-expected.txt: added

2010-04-06 Chris Evans <​cevans@chromium.org>

Reviewed by Adam Barth.

Use the new UserGestureIndictor to process javascript:window.open()

​https://bugs.webkit.org/show_bug.cgi?id=37138

• bindings/v8/ScriptController.cpp (WebCore::ScriptController::processingUserGesture): Use the new UserGestureIndicator when processing a javascript:window.open()

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/events/popup-blocked-from-window-open-expected.txt (added)
• LayoutTests/fast/events/popup-blocked-from-window-open.html (added)
• WebCore/ChangeLog (modified) (1 diff)
• WebCore/bindings/v8/ScriptController.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2010-04-06  Chris Evans  <cevans@chromium.org>
+
+        Reviewed by Adam Barth.
+
+        Add test for javascript:window.open() popup blocker bypass.
+        https://bugs.webkit.org/show_bug.cgi?id=37138
+
+        * fast/events/popup-blocked-from-window-open.html: added
+        * fast/events/popup-blocked-from-window-open-expected.txt: added
+
 2010-04-06  Adam Barth  <abarth@webkit.org>
 

trunk/WebCore/ChangeLog

@@ +1 @@
+2010-04-06  Chris Evans  <cevans@chromium.org>
+
+        Reviewed by Adam Barth.
+
+        Use the new UserGestureIndictor to process javascript:window.open()
+
+        https://bugs.webkit.org/show_bug.cgi?id=37138
+
+        * bindings/v8/ScriptController.cpp
+        (WebCore::ScriptController::processingUserGesture):
+          Use the new UserGestureIndicator when processing a
+          javascript:window.open()
+
 2010-04-06  Vangelis Kokkevis  <vangelis@chromium.org>
 

trunk/WebCore/bindings/v8/ScriptController.cpp

@@ -193 +193 @@
             return true;
     } else if (m_sourceURL && m_sourceURL->isNull() && !activeProxy->timerCallback()) {
-        // This is the <a href="javascript:window.open('...')> case -> we let it through.
-        return true;
+        // This is the javascript:window.open('...') case -> we let it through if it was a <a href> user click and not if it was window.open().
+        return UserGestureIndicator::processingUserGesture();
     }