Changeset 57211 in webkit

Timestamp:

Apr 7, 2010 9:32:10 AM (14 years ago)

Author:

tonikitoo@webkit.org

Message:

Spatial Navigation: bail out as soon as algorithm finds a focus candidate is not applicable ​https://bugs.webkit.org/show_bug.cgi?id=37135

Reviewed by Kenneth Christiansen.
Patch by Antonio Gomes <​tonikitoo@webkit.org>

It happens, for example, when distanceDataForNode assigns numeric_limits<long long> to
current focus candidate's. It means that current candidate is not in direction, or not
a valid target node.

• page/FocusController.cpp:

(WebCore::FocusController::findFocusableNodeInDirection):

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• page/FocusController.cpp (modified) (1 diff)

trunk/WebCore/ChangeLog

@@ +1 @@
+2010-04-05  Antonio Gomes  <tonikitoo@webkit.org>
+
+        Reviewed by Kenneth Christiansen.
+
+        Spatial Navigation: bail out as soon as algorithm finds a focus candidate is not applicable
+        https://bugs.webkit.org/show_bug.cgi?id=37135
+
+        It happens, for example, when distanceDataForNode assigns numeric_limits<long long> to
+        current focus candidate's. It means that current candidate is not in direction, or not
+        a valid target node.
+
+        * page/FocusController.cpp:
+        (WebCore::FocusController::findFocusableNodeInDirection):
+
 2010-04-07  Andrey Kosyakov  <caseq@chromium.org>
 

trunk/WebCore/page/FocusController.cpp

@@ -407 +407 @@
             distanceDataForNode(direction, focusedNode, currentFocusCandidate);
 
+            // Bail out if distance is maximum.
+            if (currentFocusCandidate.distance == maxDistance())
+                continue;
+
             // If candidateParent is not null, it means that we are in a recursive call
             // from deepFineFocusableNodeInDirection (i.e. processing an element in an iframe),