Changeset 57241 in webkit

Timestamp:

Apr 7, 2010 4:49:11 PM (14 years ago)

Author:

abarth@webkit.org

Message:

2010-04-07 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Fix two cookie tests to clean up after themselves (so they can be run repeatedly)
​https://bugs.webkit.org/show_bug.cgi?id=37235

Tiger's CFNetwork doesn't seem to understand "max-age=-1" so we'll
use "expires=some date in the past" to clear cookies instead.
I've verified that these tests still work on Snow Leopard.

• http/tests/xmlhttprequest/resources/cross-origin-set-cookies.php:
• http/tests/xmlhttprequest/resources/get-set-cookie.cgi:

Location:

trunk/LayoutTests

Files:

• ChangeLog (modified) (1 diff)
• http/tests/xmlhttprequest/resources/cross-origin-set-cookies.php (modified) (1 diff)
• http/tests/xmlhttprequest/resources/get-set-cookie.cgi (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2010-04-07  Eric Seidel  <eric@webkit.org>
+
+        Reviewed by Adam Barth.
+
+        Fix two cookie tests to clean up after themselves (so they can be run repeatedly)
+        https://bugs.webkit.org/show_bug.cgi?id=37235
+
+        Tiger's CFNetwork doesn't seem to understand "max-age=-1" so we'll
+        use "expires=some date in the past" to clear cookies instead.
+        I've verified that these tests still work on Snow Leopard.
+
+        * http/tests/xmlhttprequest/resources/cross-origin-set-cookies.php:
+        * http/tests/xmlhttprequest/resources/get-set-cookie.cgi:
+
 2010-04-07  Erik Arvidsson  <arv@chromium.org>
 

trunk/LayoutTests/http/tests/xmlhttprequest/resources/cross-origin-set-cookies.php

@@ -2 +2 @@
 $age_string = "";
 if ($_GET['clear']) {
-    $age_string = "max-age=-1";
+    $age_string = "expires=Thu, 19 Mar 1982 11:22:11 GMT";
 }
 header("Set-Cookie: WK-xhr-cookie-storage=MySpecialValue;$age_string");

trunk/LayoutTests/http/tests/xmlhttprequest/resources/get-set-cookie.cgi

@@ -4 +4 @@
 my $AGE_STRING = "";
 if ($ENV{"QUERY_STRING"}) { # Assume any query string means "?clear=1"
-    $AGE_STRING = "max-age=-1";
+    $AGE_STRING = "expires=Thu, 19 Mar 1982 11:22:11 GMT";
 }
 print "Set-Cookie: WK-test=1;$AGE_STRING\n";