Changeset 57319 in webkit


Ignore:
Timestamp:
Apr 9, 2010 1:59:31 AM (14 years ago)
Author:
eric@webkit.org
Message:

2010-04-09 Kenneth Rohde Christiansen <​kenneth@webkit.org>

Reviewed by Simon Fraser.

Update test as the 'all' value has been removed

  • fast/media/media-feature-wgt-view-mode.html:

2010-04-09 Kenneth Rohde Christiansen <​kenneth@webkit.org>

Reviewed by Simon Fraser.

Remove "all" value from the view-mode media feature (as agreed on
1-Apr-2010) in the Widgets voice conf.

  • css/CSSValueKeywords.in:
  • css/MediaQueryEvaluator.cpp: (WebCore::view_modeMediaFeatureEval):
Location:
trunk
Files:
5 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r57316 r57319  
     12010-04-09  Kenneth Rohde Christiansen  <kenneth@webkit.org>
     2
     3        Reviewed by Simon Fraser.
     4
     5        Update test as the 'all' value has been removed
     6
     7        * fast/media/media-feature-wgt-view-mode.html:
     8
    192010-04-09  Andras Becsi  <abecsi@webkit.org>
    210

  • trunk/LayoutTests/fast/media/media-feature-wgt-view-mode.html

    r56740 r57319  
    1010            }
    1111        }
    12         @media (-webkit-view-mode: all) {
     12        @media (-webkit-view-mode) {
    1313            div {
    1414                background-color: green;

  • trunk/WebCore/ChangeLog

    r57317 r57319  
     12010-04-09  Kenneth Rohde Christiansen  <kenneth@webkit.org>
     2
     3        Reviewed by Simon Fraser.
     4
     5        Remove "all" value from the view-mode media feature (as agreed on
     6        1-Apr-2010) in the Widgets voice conf.
     7
     8        * css/CSSValueKeywords.in:
     9        * css/MediaQueryEvaluator.cpp:
     10        (WebCore::view_modeMediaFeatureEval):
     11
    1122010-04-09  Sheriff Bot  <webkit.review.bot@gmail.com>
    213

  • trunk/WebCore/css/CSSValueKeywords.in

    r56740 r57319  
    716716application
    717717fullscreen
    718 #all

  • trunk/WebCore/css/MediaQueryEvaluator.cpp

    r56740 r57319  
    502502        String mode = static_cast<CSSPrimitiveValue*>(value)->getStringValue();
    503503        if (ChromeClient* client = frame->page()->chrome()->client()) {
    504             if (mode == "all")
    505                 return true;
    506504            if (mode == "mini" && client->isDocked())
    507505                return true;
    … …  
    515513        }
    516514    }
    517     return false;
     515    return true;
    518516}
    519517#endif
Note: See TracChangeset for help on using the changeset viewer.