Changeset 57339 in webkit


Ignore:
Timestamp:
Apr 9, 2010 8:56:00 AM (14 years ago)
Author:
Adam Roben
Message:

Make :visited tests added in r57292 not assert on Windows and GTK builds

Fixes <​http://webkit.org/b/37333>.

Reviewed by Anders Carlsson.

WebKitTools:

Don't return 0 as a JSValueRef

That is an illegal use of the JSC API.

  • DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:

(LayoutTestController::computedStyleIncludingVisitedInfo):

  • DumpRenderTree/win/LayoutTestControllerWin.cpp:

(LayoutTestController::computedStyleIncludingVisitedInfo):
Return an "undefined" JSValueRef instead of 0.

LayoutTests:

Add Windows- and GTK-specific results for new :visited tests

These platforms haven't yet implemented the new LayoutTestController
API these tests require. Implementing the API is tracked by
<​http://webkit.org/b/37336> and <​http://webkit.org/b/37337>.

  • platform/gtk/fast/history/nested-visited-test-expected.txt: Added.
  • platform/gtk/fast/history/self-is-visited-expected.txt: Added.
  • platform/gtk/fast/history/sibling-visited-test-expected.txt: Added.
  • platform/win/fast/history/nested-visited-test-expected.txt: Added.
  • platform/win/fast/history/self-is-visited-expected.txt: Added.
  • platform/win/fast/history/sibling-visited-test-expected.txt: Added.
Location:
trunk
Files:
8 added
4 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r57324 r57339  
     12010-04-09  Adam Roben  <aroben@apple.com>
     2
     3        Add Windows- and GTK-specific results for new :visited tests
     4
     5        These platforms haven't yet implemented the new LayoutTestController
     6        API these tests require. Implementing the API is tracked by
     7        <http://webkit.org/b/37336> and <http://webkit.org/b/37337>.
     8
     9        Fixes <http://webkit.org/b/37333> REGRESSION (r57292): :visited tests
     10        are asserting on debug Windows and GTK builds.
     11
     12        Reviewed by Anders Carlsson.
     13
     14        * platform/gtk/fast/history/nested-visited-test-expected.txt: Added.
     15        * platform/gtk/fast/history/self-is-visited-expected.txt: Added.
     16        * platform/gtk/fast/history/sibling-visited-test-expected.txt: Added.
     17        * platform/win/fast/history/nested-visited-test-expected.txt: Added.
     18        * platform/win/fast/history/self-is-visited-expected.txt: Added.
     19        * platform/win/fast/history/sibling-visited-test-expected.txt: Added.
     20
    1212010-04-09  Zhenyao Mo  <zmo@google.com>
    222

  • trunk/WebKitTools/ChangeLog

    r57328 r57339  
     12010-04-09  Adam Roben  <aroben@apple.com>
     2
     3        Don't return 0 as a JSValueRef
     4
     5        That is an illegal use of the JSC API.
     6
     7        Fixes <http://webkit.org/b/37333> REGRESSION (r57292): :visited tests
     8        are asserting on debug Windows and GTK builds
     9
     10        Reviewed by Anders Carlsson.
     11
     12        * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
     13        (LayoutTestController::computedStyleIncludingVisitedInfo):
     14        * DumpRenderTree/win/LayoutTestControllerWin.cpp:
     15        (LayoutTestController::computedStyleIncludingVisitedInfo):
     16        Return an "undefined" JSValueRef instead of 0.
     17
    1182010-04-09  Csaba Osztrogonác  <ossy@webkit.org>
    219

  • trunk/WebKitTools/DumpRenderTree/gtk/LayoutTestControllerGtk.cpp

    r57292 r57339  
    147147{
    148148    // FIXME: Implement this.
    149     return 0;
     149    return JSValueMakeUndefined(context);
    150150}
    151151

  • trunk/WebKitTools/DumpRenderTree/win/LayoutTestControllerWin.cpp

    r57292 r57339  
    177177{
    178178    // FIXME: Implement this.
    179     return 0;
     179    return JSValueMakeUndefined(context);
    180180}
    181181
Note: See TracChangeset for help on using the changeset viewer.