Changeset 57388 in webkit

Timestamp:

Apr 9, 2010 5:51:28 PM (14 years ago)

Author:

eric@webkit.org

Message:

2010-04-09 Yi Shen <​yi.4.shen@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] tst_QWebFrame::popupFocus() fails
​https://bugs.webkit.org/show_bug.cgi?id=37320

The QWebPopup class has been moved & renamed, so tst_QWebFrame::popupFocus() should use
the class name "QComboBox", rather than "WebCore::QWebPopup" to find the popup menu.

• tests/qwebframe/tst_qwebframe.cpp:

Location:

trunk/WebKit/qt

Files:

• ChangeLog (modified) (1 diff)
• tests/qwebframe/tst_qwebframe.cpp (modified) (1 diff)

trunk/WebKit/qt/ChangeLog

@@ +1 @@
+2010-04-09  Yi Shen  <yi.4.shen@nokia.com>
+
+        Reviewed by Kenneth Rohde Christiansen.
+
+        [Qt] tst_QWebFrame::popupFocus() fails
+        https://bugs.webkit.org/show_bug.cgi?id=37320
+
+        The QWebPopup class has been moved & renamed, so tst_QWebFrame::popupFocus() should use
+        the class name "QComboBox", rather than "WebCore::QWebPopup" to find the popup menu.
+
+        * tests/qwebframe/tst_qwebframe.cpp:
+
 2010-04-09  Antonio Gomes  <tonikitoo@webkit.org>
 

trunk/WebKit/qt/tests/qwebframe/tst_qwebframe.cpp

@@ -2516 +2516 @@
     // open the popup by clicking. check if focus is on the popup
     QTest::mouseClick(&view, Qt::LeftButton, 0, QPoint(25, 25));
-    QObject* webpopup = firstChildByClassName(&view, "WebCore::QWebPopup");
+    QObject* webpopup = firstChildByClassName(&view, "QComboBox");
     QComboBox* combo = qobject_cast<QComboBox*>(webpopup);
     QVERIFY(combo != 0);