Changeset 57394 in webkit

Timestamp:

Apr 9, 2010 6:56:18 PM (14 years ago)

Author:

eric@webkit.org

Message:

2010-04-09 Evan Martin <​evan@chromium.org>

Reviewed by Darin Adler.

StorageEvent destructor should be in StorageEvent.cpp
​https://bugs.webkit.org/show_bug.cgi?id=37356

Because Storage is forward-declared in StorageEvent.h, we need to define
the StorageEvent destructor in the .cpp file so that the RefPtr<Storage>
destructor has a complete type for Storage.

• storage/StorageEvent.cpp: (WebCore::StorageEvent::~StorageEvent):
• storage/StorageEvent.h:

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• storage/StorageEvent.cpp (modified) (1 diff)
• storage/StorageEvent.h (modified) (1 diff)

trunk/WebCore/ChangeLog

@@ +1 @@
+2010-04-09  Evan Martin  <evan@chromium.org>
+
+        Reviewed by Darin Adler.
+
+        StorageEvent destructor should be in StorageEvent.cpp
+        https://bugs.webkit.org/show_bug.cgi?id=37356
+
+        Because Storage is forward-declared in StorageEvent.h, we need to define
+        the StorageEvent destructor in the .cpp file so that the RefPtr<Storage>
+        destructor has a complete type for Storage.
+
+        * storage/StorageEvent.cpp:
+        (WebCore::StorageEvent::~StorageEvent):
+        * storage/StorageEvent.h:
+
 2010-04-09  Young Han Lee  <joybro@company100.net>
 

trunk/WebCore/storage/StorageEvent.cpp

@@ -42 +42 @@
 }
 
+StorageEvent::~StorageEvent()
+{
+}
+
 PassRefPtr<StorageEvent> StorageEvent::create(const AtomicString& type, const String& key, const String& oldValue, const String& newValue, const String& uri, Storage* storageArea)
 {

trunk/WebCore/storage/StorageEvent.h

@@ -40 +40 @@
         static PassRefPtr<StorageEvent> create();
         static PassRefPtr<StorageEvent> create(const AtomicString& type, const String& key, const String& oldValue, const String& newValue, const String& uri, Storage* storageArea);
+        virtual ~StorageEvent();
 
         const String& key() const { return m_key; }