Changeset 57492 in webkit

Timestamp:

Apr 12, 2010 6:04:16 PM (14 years ago)

Author:

dumi@chromium.org

Message:

Throwing a SECURITY_ERR when openDatabase() cannot open a database
for whatever reason, as required by the spec.
​https://bugs.webkit.org/show_bug.cgi?id=33916

Reviewed by Dimitri Glazkov.

• bindings/js/JSDOMWindowCustom.cpp:

(WebCore::JSDOMWindow::openDatabase):

• bindings/v8/custom/V8DOMWindowCustom.cpp:

(WebCore::V8DOMWindow::openDatabaseCallback):

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• bindings/js/JSDOMWindowCustom.cpp (modified) (1 diff)
• bindings/v8/custom/V8DOMWindowCustom.cpp (modified) (1 diff)

trunk/WebCore/ChangeLog

@@ +1 @@
+2010-04-12  Dumitru Daniliuc  <dumi@chromium.org>
+
+        Reviewed by Dimitri Glazkov.
+
+        Throwing a SECURITY_ERR when openDatabase() cannot open a database
+        for whatever reason, as required by the spec.
+        https://bugs.webkit.org/show_bug.cgi?id=33916
+
+        * bindings/js/JSDOMWindowCustom.cpp:
+        (WebCore::JSDOMWindow::openDatabase):
+        * bindings/v8/custom/V8DOMWindowCustom.cpp:
+        (WebCore::V8DOMWindow::openDatabaseCallback):
+
 2010-04-12  Steve Falkenburg  <sfalken@apple.com>
 

trunk/WebCore/bindings/js/JSDOMWindowCustom.cpp

@@ -978 +978 @@
 
     JSValue result = toJS(exec, globalObject(), WTF::getPtr(impl()->openDatabase(name, version, displayName, estimatedSize, creationCallback.release(), ec)));
+    if (!ec && result.isNull())
+        ec = SECURITY_ERR;
+
     setDOMException(exec, ec);
     return result;

trunk/WebCore/bindings/v8/custom/V8DOMWindowCustom.cpp

@@ -736 +736 @@
 
     v8::Handle<v8::Value> result = toV8(imp->openDatabase(name, version, displayName, estimatedSize, creationCallback.release(), ec));
+    if (!ec && result.IsEmpty())
+        ec = SECURITY_ERR;
+
     V8Proxy::setDOMException(ec);
     return result;