Changeset 57496 in webkit

Timestamp:

Apr 12, 2010 7:29:01 PM (14 years ago)

Author:

tonikitoo@webkit.org

Message:

Spatial Navigation: make renderRectRelativeToRootDocument method to fallback to getRect() of Element when needed
​https://bugs.webkit.org/show_bug.cgi?id=37461

Reviewed by Simon Fraser.
Patch by Antonio Gomes <​tonikitoo@webkit.org>

WebCore:

getRect() of Element can be used instead of absoluteClippedOverflowRect of RenderObject when
the node is currently offscreen in an scroll overflowed content.

Test: fast/events/spatial-navigation/snav-simple-content-overflow.html

• page/SpatialNavigation.cpp:

(WebCore::renderRectRelativeToRootDocument):

LayoutTests:

• fast/events/spatial-navigation/snav-simple-content-overflow-expected.txt: Added.
• fast/events/spatial-navigation/snav-simple-content-overflow.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/events/spatial-navigation/snav-simple-content-overflow-expected.txt (added)
• LayoutTests/fast/events/spatial-navigation/snav-simple-content-overflow.html (added)
• WebCore/ChangeLog (modified) (1 diff)
• WebCore/page/SpatialNavigation.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2010-04-12  Antonio Gomes  <tonikitoo@webkit.org>
+
+        Reviewed by Simon Fraser.
+
+        Spatial Navigation: make renderRectRelativeToRootDocument method to fallback to getRect() of Element when needed
+        https://bugs.webkit.org/show_bug.cgi?id=37461
+
+        * fast/events/spatial-navigation/snav-simple-content-overflow-expected.txt: Added.
+        * fast/events/spatial-navigation/snav-simple-content-overflow.html: Added.
+
+
 2010-04-08  yael aharon  <yael.aharon@nokia.com>
 

trunk/WebCore/ChangeLog

@@ +1 @@
+2010-04-12  Antonio Gomes  <tonikitoo@webkit.org>
+
+        Reviewed by Simon Fraser.
+
+        Spatial Navigation: make renderRectRelativeToRootDocument method to fallback to getRect() of Element when needed
+        https://bugs.webkit.org/show_bug.cgi?id=37461
+
+        getRect() of Element can be used instead of absoluteClippedOverflowRect of RenderObject when
+        the node is currently offscreen in an scroll overflowed content.
+
+        Test: fast/events/spatial-navigation/snav-simple-content-overflow.html
+
+        * page/SpatialNavigation.cpp:
+        (WebCore::renderRectRelativeToRootDocument):
+
 2010-04-12  Antonio Gomes  <tonikitoo@webkit.org>
 

trunk/WebCore/page/SpatialNavigation.cpp

@@ -107 +107 @@
     IntRect rect(render->absoluteClippedOverflowRect());
 
+    if (rect.isEmpty()) {
+        Element* e = static_cast<Element*>(render->node());
+        rect = e->getRect();
+    }
+
     // In cases when the |render|'s associated node is in a scrollable inner
     // document, we only consider its scrollOffset if it is not offscreen.