Changeset 57564 in webkit

Timestamp:

Apr 13, 2010 11:12:42 PM (14 years ago)

Author:

krit@webkit.org

Message:

2010-04-13 Dirk Schulze <​krit@webkit.org>

Reviewed by Eric Seidel.

REGRESSION(r57511): many new graphics / svg related leaks
​https://bugs.webkit.org/show_bug.cgi?id=37527

The content of a HashMap was not correctly deleted. Fixed this
in the DTor and in invalidateClient of RenderSVGResourceClipper.

• rendering/RenderSVGResourceClipper.cpp: (WebCore::RenderSVGResourceClipper::~RenderSVGResourceClipper): (WebCore::RenderSVGResourceClipper::invalidateClient):

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• rendering/RenderSVGResourceClipper.cpp (modified) (2 diffs)

trunk/WebCore/ChangeLog

@@ +1 @@
+2010-04-13  Dirk Schulze  <krit@webkit.org>
+
+        Reviewed by Eric Seidel.
+
+        REGRESSION(r57511): many new graphics / svg related leaks
+        https://bugs.webkit.org/show_bug.cgi?id=37527
+
+        The content of a HashMap was not correctly deleted. Fixed this
+        in the DTor and in invalidateClient of RenderSVGResourceClipper.
+
+        * rendering/RenderSVGResourceClipper.cpp:
+        (WebCore::RenderSVGResourceClipper::~RenderSVGResourceClipper):
+        (WebCore::RenderSVGResourceClipper::invalidateClient):
+
 2010-04-13  Zhenyao Mo  <zmo@google.com>
 

trunk/WebCore/rendering/RenderSVGResourceClipper.cpp

@@ -51 +51 @@
 RenderSVGResourceClipper::~RenderSVGResourceClipper()
 {
+    deleteAllValues(m_clipper);
     m_clipper.clear();
 }
@@ -77 +78 @@
         return;
 
-    m_clipper.take(object);
+    delete m_clipper.take(object);
 }