Changeset 57663 in webkit

Timestamp:

Apr 15, 2010 12:33:59 PM (14 years ago)

Author:

tonikitoo@webkit.org

Message:

Spatial Navigation: make hasOffscreenRect() to earlier return 'true' if absoluteClippedOverflowRect() gives an empty rect
​https://bugs.webkit.org/show_bug.cgi?id=37635

Reviewed by Simon Fraser.
Patch by Antonio Gomes <​tonikitoo@webkit.org>

absoluteClippedOverflowRect method of RenderObject does return an empty IntRect for offscreen nodes.
So hasOffscreenRect method (SpatialNavigation.cpp) can safily bail out earlier in such cases.

• page/SpatialNavigation.cpp:

(WebCore::hasOffscreenRect):

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• page/SpatialNavigation.cpp (modified) (1 diff)

trunk/WebCore/ChangeLog

@@ +1 @@
+2010-04-14  Antonio Gomes  <tonikitoo@webkit.org>
+
+        Reviewed by Simon Fraser.
+
+        Spatial Navigation: make hasOffscreenRect() to earlier return 'true' if absoluteClippedOverflowRect() gives an empty rect
+        https://bugs.webkit.org/show_bug.cgi?id=37635
+
+        absoluteClippedOverflowRect method of RenderObject does return an empty IntRect for offscreen nodes.
+        So hasOffscreenRect method (SpatialNavigation.cpp) can safily bail out earlier in such cases.
+
+        * page/SpatialNavigation.cpp:
+        (WebCore::hasOffscreenRect):
+
 2010-04-14  Antonio Gomes  <tonikitoo@webkit.org>
 

trunk/WebCore/page/SpatialNavigation.cpp

@@ -437 +437 @@
 
     IntRect rect(render->absoluteClippedOverflowRect());
+    if (rect.isEmpty())
+        return true;
+
     return !containerViewportRect.intersects(rect);
 }