Changeset 57788 in webkit


Ignore:
Timestamp:
Apr 17, 2010 5:42:05 PM (14 years ago)
Author:
eric@webkit.org
Message:

2010-04-17 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Remove steps_references and commands_references
​https://bugs.webkit.org/show_bug.cgi?id=37758

We tried using the mumble_references convention to manage our
dependencies, but it doesn't seem to be providing much value for the
steps and commands module because these modules are small pieces of the
larger tool module. In this patch, I've removed the references file
for these modules.

I've left the style_references file for the style module because that
module seems better isolated from the rest of webkitpy and the
style_references file appears to be providing some value.

  • Scripts/webkitpy/tool/commands/commandtest.py:
  • Scripts/webkitpy/tool/commands/download_unittest.py:
  • Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
  • Scripts/webkitpy/tool/commands/queries_unittest.py:
  • Scripts/webkitpy/tool/commands/queues_unittest.py:
  • Scripts/webkitpy/tool/commands/queuestest.py:
  • Scripts/webkitpy/tool/commands/upload.py:
  • Scripts/webkitpy/tool/commands/upload_unittest.py:
  • Scripts/webkitpy/tool/commands_references.py: Removed.
  • Scripts/webkitpy/tool/steps/closebugforlanddiff_unittest.py:
  • Scripts/webkitpy/tool/steps/steps_unittest.py:
  • Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittest.py:
  • Scripts/webkitpy/tool/steps/validatereviewer_unittest.py:
  • Scripts/webkitpy/tool/steps_references.py: Removed.
Location:
trunk/WebKitTools
Files:
2 deleted
13 edited

Legend:

Unmodified
Added
Removed

  • trunk/WebKitTools/ChangeLog

    r57778 r57788  
     12010-04-17  Adam Barth  <abarth@webkit.org>
     2
     3        Reviewed by Eric Seidel.
     4
     5        Remove steps_references and commands_references
     6        https://bugs.webkit.org/show_bug.cgi?id=37758
     7
     8        We tried using the mumble_references convention to manage our
     9        dependencies, but it doesn't seem to be providing much value for the
     10        steps and commands module because these modules are small pieces of the
     11        larger tool module.  In this patch, I've removed the references file
     12        for these modules.
     13 
     14        I've left the style_references file for the style module because that
     15        module seems better isolated from the rest of webkitpy and the
     16        style_references file appears to be providing some value.
     17
     18        * Scripts/webkitpy/tool/commands/commandtest.py:
     19        * Scripts/webkitpy/tool/commands/download_unittest.py:
     20        * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
     21        * Scripts/webkitpy/tool/commands/queries_unittest.py:
     22        * Scripts/webkitpy/tool/commands/queues_unittest.py:
     23        * Scripts/webkitpy/tool/commands/queuestest.py:
     24        * Scripts/webkitpy/tool/commands/upload.py:
     25        * Scripts/webkitpy/tool/commands/upload_unittest.py:
     26        * Scripts/webkitpy/tool/commands_references.py: Removed.
     27        * Scripts/webkitpy/tool/steps/closebugforlanddiff_unittest.py:
     28        * Scripts/webkitpy/tool/steps/steps_unittest.py:
     29        * Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittest.py:
     30        * Scripts/webkitpy/tool/steps/validatereviewer_unittest.py:
     31        * Scripts/webkitpy/tool/steps_references.py: Removed.
     32
    1332010-04-17  Eric Seidel  <eric@webkit.org>
    234

  • trunk/WebKitTools/Scripts/webkitpy/tool/commands/commandtest.py

    r56519 r57788  
    3131from webkitpy.common.system.outputcapture import OutputCapture
    3232from webkitpy.tool.mocktool import MockTool
    33 from webkitpy.tool.commands_references import Mock
     33from webkitpy.thirdparty.mock import Mock
    3434
    3535class CommandsTest(unittest.TestCase):

  • trunk/WebKitTools/Scripts/webkitpy/tool/commands/download_unittest.py

    r57587 r57788  
    2727# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
    2828
    29 from webkitpy.tool.commands_references import Mock
     29from webkitpy.thirdparty.mock import Mock
    3030from webkitpy.tool.commands.commandtest import CommandsTest
    3131from webkitpy.tool.commands.download import *

  • trunk/WebKitTools/Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py

    r56976 r57788  
    2929import os
    3030
    31 from webkitpy.tool.commands_references import Mock
     31from webkitpy.thirdparty.mock import Mock
    3232from webkitpy.tool.commands.earlywarningsystem import *
    3333from webkitpy.tool.commands.queuestest import QueuesTest

  • trunk/WebKitTools/Scripts/webkitpy/tool/commands/queries_unittest.py

    r56508 r57788  
    2828
    2929from webkitpy.common.net.bugzilla import Bugzilla
    30 from webkitpy.tool.commands_references import Mock
     30from webkitpy.thirdparty.mock import Mock
    3131from webkitpy.tool.commands.commandtest import CommandsTest
    3232from webkitpy.tool.commands.queries import *

  • trunk/WebKitTools/Scripts/webkitpy/tool/commands/queues_unittest.py

    r57552 r57788  
    3131from webkitpy.common.net.bugzilla import Attachment
    3232from webkitpy.common.system.outputcapture import OutputCapture
    33 from webkitpy.tool.commands_references import Mock
     33from webkitpy.thirdparty.mock import Mock
    3434from webkitpy.tool.commands.commandtest import CommandsTest
    3535from webkitpy.tool.commands.queues import *

  • trunk/WebKitTools/Scripts/webkitpy/tool/commands/queuestest.py

    r56658 r57788  
    3131from webkitpy.common.net.bugzilla import Attachment
    3232from webkitpy.common.system.outputcapture import OutputCapture
    33 from webkitpy.tool.commands_references import Mock
     33from webkitpy.thirdparty.mock import Mock
    3434from webkitpy.tool.mocktool import MockTool
    3535

  • trunk/WebKitTools/Scripts/webkitpy/tool/commands/upload.py

    r57552 r57788  
    4141from webkitpy.common.net.bugzilla import parse_bug_id
    4242from webkitpy.common.system.user import User
    43 from webkitpy.tool.commands_references import Mock
     43from webkitpy.thirdparty.mock import Mock
    4444from webkitpy.tool.commands.abstractsequencedcommand import AbstractSequencedCommand
    4545from webkitpy.tool.grammar import pluralize, join_with_separators

  • trunk/WebKitTools/Scripts/webkitpy/tool/commands/upload_unittest.py

    r57587 r57788  
    2727# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
    2828
    29 from webkitpy.tool.commands_references import Mock
     29from webkitpy.thirdparty.mock import Mock
    3030from webkitpy.tool.commands.commandtest import CommandsTest
    3131from webkitpy.tool.commands.upload import *

  • trunk/WebKitTools/Scripts/webkitpy/tool/steps/closebugforlanddiff_unittest.py

    r56519 r57788  
    3030
    3131from webkitpy.common.system.outputcapture import OutputCapture
     32from webkitpy.thirdparty.mock import Mock
    3233from webkitpy.tool.mocktool import MockTool
    33 from webkitpy.tool.steps_references import Mock
    3434from webkitpy.tool.steps.closebugforlanddiff import CloseBugForLandDiff
    3535

  • trunk/WebKitTools/Scripts/webkitpy/tool/steps/steps_unittest.py

    r56519 r57788  
    3030
    3131from webkitpy.common.system.outputcapture import OutputCapture
     32from webkitpy.thirdparty.mock import Mock
    3233from webkitpy.tool.mocktool import MockTool
    33 from webkitpy.tool.steps_references import Mock
    3434from webkitpy.tool.steps.update import Update
    3535from webkitpy.tool.steps.promptforbugortitle import PromptForBugOrTitle

  • trunk/WebKitTools/Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittest.py

    r56672 r57788  
    3030
    3131from webkitpy.common.system.outputcapture import OutputCapture
     32from webkitpy.thirdparty.mock import Mock
    3233from webkitpy.tool.mocktool import MockTool
    33 from webkitpy.tool.steps_references import Mock
    3434from webkitpy.tool.steps.updatechangelogswithreviewer import UpdateChangeLogsWithReviewer
    3535

  • trunk/WebKitTools/Scripts/webkitpy/tool/steps/validatereviewer_unittest.py

    r56748 r57788  
    3131from webkitpy.common.checkout.changelog import ChangeLogEntry
    3232from webkitpy.common.system.outputcapture import OutputCapture
     33from webkitpy.thirdparty.mock import Mock
    3334from webkitpy.tool.mocktool import MockTool
    34 from webkitpy.tool.steps_references import Mock
    3535from webkitpy.tool.steps.validatereviewer import ValidateReviewer
    3636
Note: See TracChangeset for help on using the changeset viewer.