Changeset 57903 in webkit


Ignore:
Timestamp:
Apr 20, 2010 12:20:10 PM (14 years ago)
Author:
eric@webkit.org
Message:

2010-04-20 Kent Tamura <tkent@chromium.org>

Reviewed by Darin Adler.

Change a parameter type of chooseIconForFiles()
https://bugs.webkit.org/show_bug.cgi?id=37504

Change PassRefPtr<FileChooser> parameter of chooseIconForFiles()
to FileChooser*. Though an implementation of chooseIconForFiles()
might have ownership of the FileChooser instance, we don't need to
use PassRefPtr<> in this case.

  • loader/EmptyClients.h: (WebCore::EmptyChromeClient::chooseIconForFiles):
  • page/Chrome.cpp: (WebCore::Chrome::chooseIconForFiles):
  • page/Chrome.h:
  • page/ChromeClient.h:

2010-04-20 Kent Tamura <tkent@chromium.org>

Reviewed by Darin Adler.

Change a parameter type of chooseIconForFiles()
https://bugs.webkit.org/show_bug.cgi?id=37504

  • src/ChromeClientImpl.cpp: (WebKit::ChromeClientImpl::chooseIconForFiles):
  • src/ChromeClientImpl.h:

2010-04-20 Kent Tamura <tkent@chromium.org>

Reviewed by Darin Adler.

Change a parameter type of chooseIconForFiles()
https://bugs.webkit.org/show_bug.cgi?id=37504

  • WebCoreSupport/ChromeClientGtk.cpp: (WebKit::ChromeClient::chooseIconForFiles):
  • WebCoreSupport/ChromeClientGtk.h:

2010-04-20 Kent Tamura <tkent@chromium.org>

Reviewed by Darin Adler.

Change a parameter type of chooseIconForFiles()
https://bugs.webkit.org/show_bug.cgi?id=37504

  • WebCoreSupport/ChromeClientHaiku.cpp: (WebCore::ChromeClientHaiku::chooseIconForFiles):
  • WebCoreSupport/ChromeClientHaiku.h:

2010-04-20 Kent Tamura <tkent@chromium.org>

Reviewed by Darin Adler.

Change a parameter type of chooseIconForFiles()
https://bugs.webkit.org/show_bug.cgi?id=37504

  • WebCoreSupport/WebChromeClient.h:
  • WebCoreSupport/WebChromeClient.mm: (WebChromeClient::chooseIconForFiles):

2010-04-20 Kent Tamura <tkent@chromium.org>

Reviewed by Darin Adler.

Change a parameter type of chooseIconForFiles()
https://bugs.webkit.org/show_bug.cgi?id=37504

  • WebCoreSupport/ChromeClientQt.cpp: (WebCore::ChromeClientQt::chooseIconForFiles):
  • WebCoreSupport/ChromeClientQt.h:

2010-04-20 Kent Tamura <tkent@chromium.org>

Reviewed by Darin Adler.

Change a parameter type of chooseIconForFiles()
https://bugs.webkit.org/show_bug.cgi?id=37504

  • WebCoreSupport/WebChromeClient.cpp: (WebChromeClient::chooseIconForFiles):
  • WebCoreSupport/WebChromeClient.h:

2010-04-20 Kent Tamura <tkent@chromium.org>

Reviewed by Darin Adler.

Change a parameter type of chooseIconForFiles()
https://bugs.webkit.org/show_bug.cgi?id=37504

  • WebKitSupport/ChromeClientWx.cpp: (WebCore::ChromeClientWx::chooseIconForFiles):
  • WebKitSupport/ChromeClientWx.h:
Location:
trunk
Files:
26 edited

Legend:

Unmodified
Added
Removed
  • trunk/WebCore/ChangeLog

    r57902 r57903  
     12010-04-20  Kent Tamura  <tkent@chromium.org>
     2
     3        Reviewed by Darin Adler.
     4
     5        Change a parameter type of chooseIconForFiles()
     6        https://bugs.webkit.org/show_bug.cgi?id=37504
     7
     8        Change PassRefPtr<FileChooser> parameter of chooseIconForFiles()
     9        to FileChooser*. Though an implementation of chooseIconForFiles()
     10        might have ownership of the FileChooser instance, we don't need to
     11        use PassRefPtr<> in this case.
     12
     13        * loader/EmptyClients.h:
     14        (WebCore::EmptyChromeClient::chooseIconForFiles):
     15        * page/Chrome.cpp:
     16        (WebCore::Chrome::chooseIconForFiles):
     17        * page/Chrome.h:
     18        * page/ChromeClient.h:
     19
    1202010-04-20  Diego Escalante Urrelo  <descalante@igalia.com>
    221
  • trunk/WebCore/loader/EmptyClients.h

    r57856 r57903  
    145145
    146146    virtual void runOpenPanel(Frame*, PassRefPtr<FileChooser>) { }
    147     virtual void chooseIconForFiles(const Vector<String>&, PassRefPtr<FileChooser>) { }
     147    virtual void chooseIconForFiles(const Vector<String>&, FileChooser*) { }
    148148
    149149    virtual void formStateDidChange(const Node*) { }
  • trunk/WebCore/page/Chrome.cpp

    r56851 r57903  
    431431}
    432432
    433 void Chrome::chooseIconForFiles(const Vector<String>& filenames, PassRefPtr<FileChooser> fileChooser)
     433void Chrome::chooseIconForFiles(const Vector<String>& filenames, FileChooser* fileChooser)
    434434{
    435435    m_client->chooseIconForFiles(filenames, fileChooser);
  • trunk/WebCore/page/Chrome.h

    r56851 r57903  
    136136
    137137        void runOpenPanel(Frame*, PassRefPtr<FileChooser>);
    138         void chooseIconForFiles(const Vector<String>&, PassRefPtr<FileChooser>);
     138        void chooseIconForFiles(const Vector<String>&, FileChooser*);
    139139
    140140        bool setCursor(PlatformCursorHandle);
  • trunk/WebCore/page/ChromeClient.h

    r57775 r57903  
    193193        virtual void runOpenPanel(Frame*, PassRefPtr<FileChooser>) = 0;
    194194        // Asynchronous request to load an icon for specified filenames.
    195         virtual void chooseIconForFiles(const Vector<String>&, PassRefPtr<FileChooser>) = 0;
     195        virtual void chooseIconForFiles(const Vector<String>&, FileChooser*) = 0;
    196196
    197197        virtual bool setCursor(PlatformCursorHandle) = 0;
  • trunk/WebKit/chromium/ChangeLog

    r57891 r57903  
     12010-04-20  Kent Tamura  <tkent@chromium.org>
     2
     3        Reviewed by Darin Adler.
     4
     5        Change a parameter type of chooseIconForFiles()
     6        https://bugs.webkit.org/show_bug.cgi?id=37504
     7
     8        * src/ChromeClientImpl.cpp:
     9        (WebKit::ChromeClientImpl::chooseIconForFiles):
     10        * src/ChromeClientImpl.h:
     11
    1122010-04-20  Jay Civelli  <jcivelli@chromium.org>
    213
  • trunk/WebKit/chromium/src/ChromeClientImpl.cpp

    r57887 r57903  
    603603}
    604604
    605 void ChromeClientImpl::chooseIconForFiles(const Vector<WebCore::String>&, PassRefPtr<WebCore::FileChooser>)
     605void ChromeClientImpl::chooseIconForFiles(const Vector<WebCore::String>&, WebCore::FileChooser*)
    606606{
    607607    notImplemented();
  • trunk/WebKit/chromium/src/ChromeClientImpl.h

    r57887 r57903  
    3636namespace WebCore {
    3737class AccessibilityObject;
     38class FileChooser;
    3839class HTMLParserQuirks;
    3940class PopupContainer;
     
    125126    virtual void cancelGeolocationPermissionRequestForFrame(WebCore::Frame*, WebCore::Geolocation*);
    126127    virtual void runOpenPanel(WebCore::Frame*, PassRefPtr<WebCore::FileChooser>);
    127     virtual void chooseIconForFiles(const Vector<WebCore::String>&, PassRefPtr<WebCore::FileChooser>);
     128    virtual void chooseIconForFiles(const Vector<WebCore::String>&, WebCore::FileChooser*);
    128129    virtual bool setCursor(WebCore::PlatformCursorHandle) { return false; }
    129130    virtual void formStateDidChange(const WebCore::Node*);
  • trunk/WebKit/gtk/ChangeLog

    r57901 r57903  
     12010-04-20  Kent Tamura  <tkent@chromium.org>
     2
     3        Reviewed by Darin Adler.
     4
     5        Change a parameter type of chooseIconForFiles()
     6        https://bugs.webkit.org/show_bug.cgi?id=37504
     7
     8        * WebCoreSupport/ChromeClientGtk.cpp:
     9        (WebKit::ChromeClient::chooseIconForFiles):
     10        * WebCoreSupport/ChromeClientGtk.h:
     11
    1122010-04-20  Martin Robinson  <mrobinson@webkit.org>
    213
  • trunk/WebKit/gtk/WebCoreSupport/ChromeClientGtk.cpp

    r56851 r57903  
    560560}
    561561
    562 void ChromeClient::chooseIconForFiles(const Vector<WebCore::String>& filenames, PassRefPtr<WebCore::FileChooser> chooser)
     562void ChromeClient::chooseIconForFiles(const Vector<WebCore::String>& filenames, WebCore::FileChooser* chooser)
    563563{
    564564    chooser->iconLoaded(Icon::createIconForFiles(filenames));
  • trunk/WebKit/gtk/WebCoreSupport/ChromeClientGtk.h

    r56851 r57903  
    111111#endif
    112112        virtual void runOpenPanel(WebCore::Frame*, PassRefPtr<WebCore::FileChooser>);
    113         virtual void chooseIconForFiles(const Vector<WebCore::String>&, PassRefPtr<WebCore::FileChooser>);
     113        virtual void chooseIconForFiles(const Vector<WebCore::String>&, WebCore::FileChooser*);
    114114
    115115        virtual void formStateDidChange(const WebCore::Node*) { }
  • trunk/WebKit/haiku/ChangeLog

    r57469 r57903  
     12010-04-20  Kent Tamura  <tkent@chromium.org>
     2
     3        Reviewed by Darin Adler.
     4
     5        Change a parameter type of chooseIconForFiles()
     6        https://bugs.webkit.org/show_bug.cgi?id=37504
     7
     8        * WebCoreSupport/ChromeClientHaiku.cpp:
     9        (WebCore::ChromeClientHaiku::chooseIconForFiles):
     10        * WebCoreSupport/ChromeClientHaiku.h:
     11
    1122010-04-11  Sheriff Bot  <webkit.review.bot@gmail.com>
    213
  • trunk/WebKit/haiku/WebCoreSupport/ChromeClientHaiku.cpp

    r56439 r57903  
    358358}
    359359
    360 void ChromeClientHaiku::chooseIconForFiles(const Vector<String>& filenames, PassRefPtr<FileChooser> chooser)
     360void ChromeClientHaiku::chooseIconForFiles(const Vector<String>& filenames, FileChooser* chooser)
    361361{
    362362    chooser->iconLoaded(Icon::createIconForFiles(filenames));
  • trunk/WebKit/haiku/WebCoreSupport/ChromeClientHaiku.h

    r56851 r57903  
    139139
    140140        void runOpenPanel(Frame*, PassRefPtr<FileChooser>);
    141         void chooseIconForFiles(const Vector<String>&, PassRefPtr<FileChooser>);
     141        void chooseIconForFiles(const Vector<String>&, FileChooser*);
    142142
    143143        bool setCursor(PlatformCursorHandle);
  • trunk/WebKit/mac/ChangeLog

    r57895 r57903  
     12010-04-20  Kent Tamura  <tkent@chromium.org>
     2
     3        Reviewed by Darin Adler.
     4
     5        Change a parameter type of chooseIconForFiles()
     6        https://bugs.webkit.org/show_bug.cgi?id=37504
     7
     8        * WebCoreSupport/WebChromeClient.h:
     9        * WebCoreSupport/WebChromeClient.mm:
     10        (WebChromeClient::chooseIconForFiles):
     11
    1122010-04-20  Sheriff Bot  <webkit.review.bot@gmail.com>
    213
  • trunk/WebKit/mac/WebCoreSupport/WebChromeClient.h

    r56851 r57903  
    124124
    125125    virtual void runOpenPanel(WebCore::Frame*, PassRefPtr<WebCore::FileChooser>);
    126     virtual void chooseIconForFiles(const Vector<WebCore::String>&, PassRefPtr<WebCore::FileChooser>);
     126    virtual void chooseIconForFiles(const Vector<WebCore::String>&, WebCore::FileChooser*);
    127127
    128128    virtual bool setCursor(WebCore::PlatformCursorHandle) { return false; }
  • trunk/WebKit/mac/WebCoreSupport/WebChromeClient.mm

    r56439 r57903  
    645645}
    646646
    647 void WebChromeClient::chooseIconForFiles(const Vector<String>& filenames, PassRefPtr<FileChooser> chooser)
     647void WebChromeClient::chooseIconForFiles(const Vector<String>& filenames, FileChooser* chooser)
    648648{
    649649    chooser->iconLoaded(Icon::createIconForFiles(filenames));
  • trunk/WebKit/qt/ChangeLog

    r57856 r57903  
     12010-04-20  Kent Tamura  <tkent@chromium.org>
     2
     3        Reviewed by Darin Adler.
     4
     5        Change a parameter type of chooseIconForFiles()
     6        https://bugs.webkit.org/show_bug.cgi?id=37504
     7
     8        * WebCoreSupport/ChromeClientQt.cpp:
     9        (WebCore::ChromeClientQt::chooseIconForFiles):
     10        * WebCoreSupport/ChromeClientQt.h:
     11
    1122010-04-19  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
    213
  • trunk/WebKit/qt/WebCoreSupport/ChromeClientQt.cpp

    r57656 r57903  
    518518}
    519519
    520 void ChromeClientQt::chooseIconForFiles(const Vector<String>& filenames, PassRefPtr<FileChooser> chooser)
     520void ChromeClientQt::chooseIconForFiles(const Vector<String>& filenames, FileChooser* chooser)
    521521{
    522522    chooser->iconLoaded(Icon::createIconForFiles(filenames));
  • trunk/WebKit/qt/WebCoreSupport/ChromeClientQt.h

    r57819 r57903  
    149149
    150150        virtual void runOpenPanel(Frame*, PassRefPtr<FileChooser>);
    151         virtual void chooseIconForFiles(const Vector<String>&, PassRefPtr<FileChooser>);
     151        virtual void chooseIconForFiles(const Vector<String>&, FileChooser*);
    152152
    153153        virtual void formStateDidChange(const Node*) { }
  • trunk/WebKit/win/ChangeLog

    r57856 r57903  
     12010-04-20  Kent Tamura  <tkent@chromium.org>
     2
     3        Reviewed by Darin Adler.
     4
     5        Change a parameter type of chooseIconForFiles()
     6        https://bugs.webkit.org/show_bug.cgi?id=37504
     7
     8        * WebCoreSupport/WebChromeClient.cpp:
     9        (WebChromeClient::chooseIconForFiles):
     10        * WebCoreSupport/WebChromeClient.h:
     11
    1122010-04-16  Gavin Barraclough  <barraclough@apple.com>
    213
  • trunk/WebKit/win/WebCoreSupport/WebChromeClient.cpp

    r56439 r57903  
    751751}
    752752
    753 void WebChromeClient::chooseIconForFiles(const Vector<WebCore::String>& filenames, PassRefPtr<WebCore::FileChooser> chooser)
     753void WebChromeClient::chooseIconForFiles(const Vector<WebCore::String>& filenames, WebCore::FileChooser* chooser)
    754754{
    755755    chooser->iconLoaded(Icon::createIconForFiles(filenames));
  • trunk/WebKit/win/WebCoreSupport/WebChromeClient.h

    r56851 r57903  
    127127
    128128    virtual void runOpenPanel(WebCore::Frame*, PassRefPtr<WebCore::FileChooser>);
    129     virtual void chooseIconForFiles(const Vector<WebCore::String>&, PassRefPtr<WebCore::FileChooser>);
     129    virtual void chooseIconForFiles(const Vector<WebCore::String>&, WebCore::FileChooser*);
    130130
    131131    virtual bool setCursor(WebCore::PlatformCursorHandle cursor);
  • trunk/WebKit/wx/ChangeLog

    r57863 r57903  
     12010-04-20  Kent Tamura  <tkent@chromium.org>
     2
     3        Reviewed by Darin Adler.
     4
     5        Change a parameter type of chooseIconForFiles()
     6        https://bugs.webkit.org/show_bug.cgi?id=37504
     7
     8        * WebKitSupport/ChromeClientWx.cpp:
     9        (WebCore::ChromeClientWx::chooseIconForFiles):
     10        * WebKitSupport/ChromeClientWx.h:
     11
    1122010-04-19  Kevin Ollivier  <kevino@theolliviers.com>
    213
  • trunk/WebKit/wx/WebKitSupport/ChromeClientWx.cpp

    r56439 r57903  
    443443}
    444444
    445 void ChromeClientWx::chooseIconForFiles(const Vector<String>& filenames, PassRefPtr<FileChooser> chooser)
     445void ChromeClientWx::chooseIconForFiles(const Vector<String>& filenames, FileChooser* chooser)
    446446{
    447447    chooser->iconLoaded(Icon::createIconForFiles(filenames));
  • trunk/WebKit/wx/WebKitSupport/ChromeClientWx.h

    r56851 r57903  
    129129
    130130    virtual void runOpenPanel(Frame*, PassRefPtr<FileChooser>);
    131     virtual void chooseIconForFiles(const Vector<String>&, PassRefPtr<FileChooser>);
     131    virtual void chooseIconForFiles(const Vector<String>&, FileChooser*);
    132132
    133133    virtual void formStateDidChange(const Node*) { }
Note: See TracChangeset for help on using the changeset viewer.