Changeset 57903 in webkit
- Timestamp:
- Apr 20, 2010 12:20:10 PM (14 years ago)
- Location:
- trunk
- Files:
-
- 26 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/WebCore/ChangeLog
r57902 r57903 1 2010-04-20 Kent Tamura <tkent@chromium.org> 2 3 Reviewed by Darin Adler. 4 5 Change a parameter type of chooseIconForFiles() 6 https://bugs.webkit.org/show_bug.cgi?id=37504 7 8 Change PassRefPtr<FileChooser> parameter of chooseIconForFiles() 9 to FileChooser*. Though an implementation of chooseIconForFiles() 10 might have ownership of the FileChooser instance, we don't need to 11 use PassRefPtr<> in this case. 12 13 * loader/EmptyClients.h: 14 (WebCore::EmptyChromeClient::chooseIconForFiles): 15 * page/Chrome.cpp: 16 (WebCore::Chrome::chooseIconForFiles): 17 * page/Chrome.h: 18 * page/ChromeClient.h: 19 1 20 2010-04-20 Diego Escalante Urrelo <descalante@igalia.com> 2 21 -
trunk/WebCore/loader/EmptyClients.h
r57856 r57903 145 145 146 146 virtual void runOpenPanel(Frame*, PassRefPtr<FileChooser>) { } 147 virtual void chooseIconForFiles(const Vector<String>&, PassRefPtr<FileChooser>) { }147 virtual void chooseIconForFiles(const Vector<String>&, FileChooser*) { } 148 148 149 149 virtual void formStateDidChange(const Node*) { } -
trunk/WebCore/page/Chrome.cpp
r56851 r57903 431 431 } 432 432 433 void Chrome::chooseIconForFiles(const Vector<String>& filenames, PassRefPtr<FileChooser>fileChooser)433 void Chrome::chooseIconForFiles(const Vector<String>& filenames, FileChooser* fileChooser) 434 434 { 435 435 m_client->chooseIconForFiles(filenames, fileChooser); -
trunk/WebCore/page/Chrome.h
r56851 r57903 136 136 137 137 void runOpenPanel(Frame*, PassRefPtr<FileChooser>); 138 void chooseIconForFiles(const Vector<String>&, PassRefPtr<FileChooser>);138 void chooseIconForFiles(const Vector<String>&, FileChooser*); 139 139 140 140 bool setCursor(PlatformCursorHandle); -
trunk/WebCore/page/ChromeClient.h
r57775 r57903 193 193 virtual void runOpenPanel(Frame*, PassRefPtr<FileChooser>) = 0; 194 194 // Asynchronous request to load an icon for specified filenames. 195 virtual void chooseIconForFiles(const Vector<String>&, PassRefPtr<FileChooser>) = 0;195 virtual void chooseIconForFiles(const Vector<String>&, FileChooser*) = 0; 196 196 197 197 virtual bool setCursor(PlatformCursorHandle) = 0; -
trunk/WebKit/chromium/ChangeLog
r57891 r57903 1 2010-04-20 Kent Tamura <tkent@chromium.org> 2 3 Reviewed by Darin Adler. 4 5 Change a parameter type of chooseIconForFiles() 6 https://bugs.webkit.org/show_bug.cgi?id=37504 7 8 * src/ChromeClientImpl.cpp: 9 (WebKit::ChromeClientImpl::chooseIconForFiles): 10 * src/ChromeClientImpl.h: 11 1 12 2010-04-20 Jay Civelli <jcivelli@chromium.org> 2 13 -
trunk/WebKit/chromium/src/ChromeClientImpl.cpp
r57887 r57903 603 603 } 604 604 605 void ChromeClientImpl::chooseIconForFiles(const Vector<WebCore::String>&, PassRefPtr<WebCore::FileChooser>)605 void ChromeClientImpl::chooseIconForFiles(const Vector<WebCore::String>&, WebCore::FileChooser*) 606 606 { 607 607 notImplemented(); -
trunk/WebKit/chromium/src/ChromeClientImpl.h
r57887 r57903 36 36 namespace WebCore { 37 37 class AccessibilityObject; 38 class FileChooser; 38 39 class HTMLParserQuirks; 39 40 class PopupContainer; … … 125 126 virtual void cancelGeolocationPermissionRequestForFrame(WebCore::Frame*, WebCore::Geolocation*); 126 127 virtual void runOpenPanel(WebCore::Frame*, PassRefPtr<WebCore::FileChooser>); 127 virtual void chooseIconForFiles(const Vector<WebCore::String>&, PassRefPtr<WebCore::FileChooser>);128 virtual void chooseIconForFiles(const Vector<WebCore::String>&, WebCore::FileChooser*); 128 129 virtual bool setCursor(WebCore::PlatformCursorHandle) { return false; } 129 130 virtual void formStateDidChange(const WebCore::Node*); -
trunk/WebKit/gtk/ChangeLog
r57901 r57903 1 2010-04-20 Kent Tamura <tkent@chromium.org> 2 3 Reviewed by Darin Adler. 4 5 Change a parameter type of chooseIconForFiles() 6 https://bugs.webkit.org/show_bug.cgi?id=37504 7 8 * WebCoreSupport/ChromeClientGtk.cpp: 9 (WebKit::ChromeClient::chooseIconForFiles): 10 * WebCoreSupport/ChromeClientGtk.h: 11 1 12 2010-04-20 Martin Robinson <mrobinson@webkit.org> 2 13 -
trunk/WebKit/gtk/WebCoreSupport/ChromeClientGtk.cpp
r56851 r57903 560 560 } 561 561 562 void ChromeClient::chooseIconForFiles(const Vector<WebCore::String>& filenames, PassRefPtr<WebCore::FileChooser>chooser)562 void ChromeClient::chooseIconForFiles(const Vector<WebCore::String>& filenames, WebCore::FileChooser* chooser) 563 563 { 564 564 chooser->iconLoaded(Icon::createIconForFiles(filenames)); -
trunk/WebKit/gtk/WebCoreSupport/ChromeClientGtk.h
r56851 r57903 111 111 #endif 112 112 virtual void runOpenPanel(WebCore::Frame*, PassRefPtr<WebCore::FileChooser>); 113 virtual void chooseIconForFiles(const Vector<WebCore::String>&, PassRefPtr<WebCore::FileChooser>);113 virtual void chooseIconForFiles(const Vector<WebCore::String>&, WebCore::FileChooser*); 114 114 115 115 virtual void formStateDidChange(const WebCore::Node*) { } -
trunk/WebKit/haiku/ChangeLog
r57469 r57903 1 2010-04-20 Kent Tamura <tkent@chromium.org> 2 3 Reviewed by Darin Adler. 4 5 Change a parameter type of chooseIconForFiles() 6 https://bugs.webkit.org/show_bug.cgi?id=37504 7 8 * WebCoreSupport/ChromeClientHaiku.cpp: 9 (WebCore::ChromeClientHaiku::chooseIconForFiles): 10 * WebCoreSupport/ChromeClientHaiku.h: 11 1 12 2010-04-11 Sheriff Bot <webkit.review.bot@gmail.com> 2 13 -
trunk/WebKit/haiku/WebCoreSupport/ChromeClientHaiku.cpp
r56439 r57903 358 358 } 359 359 360 void ChromeClientHaiku::chooseIconForFiles(const Vector<String>& filenames, PassRefPtr<FileChooser>chooser)360 void ChromeClientHaiku::chooseIconForFiles(const Vector<String>& filenames, FileChooser* chooser) 361 361 { 362 362 chooser->iconLoaded(Icon::createIconForFiles(filenames)); -
trunk/WebKit/haiku/WebCoreSupport/ChromeClientHaiku.h
r56851 r57903 139 139 140 140 void runOpenPanel(Frame*, PassRefPtr<FileChooser>); 141 void chooseIconForFiles(const Vector<String>&, PassRefPtr<FileChooser>);141 void chooseIconForFiles(const Vector<String>&, FileChooser*); 142 142 143 143 bool setCursor(PlatformCursorHandle); -
trunk/WebKit/mac/ChangeLog
r57895 r57903 1 2010-04-20 Kent Tamura <tkent@chromium.org> 2 3 Reviewed by Darin Adler. 4 5 Change a parameter type of chooseIconForFiles() 6 https://bugs.webkit.org/show_bug.cgi?id=37504 7 8 * WebCoreSupport/WebChromeClient.h: 9 * WebCoreSupport/WebChromeClient.mm: 10 (WebChromeClient::chooseIconForFiles): 11 1 12 2010-04-20 Sheriff Bot <webkit.review.bot@gmail.com> 2 13 -
trunk/WebKit/mac/WebCoreSupport/WebChromeClient.h
r56851 r57903 124 124 125 125 virtual void runOpenPanel(WebCore::Frame*, PassRefPtr<WebCore::FileChooser>); 126 virtual void chooseIconForFiles(const Vector<WebCore::String>&, PassRefPtr<WebCore::FileChooser>);126 virtual void chooseIconForFiles(const Vector<WebCore::String>&, WebCore::FileChooser*); 127 127 128 128 virtual bool setCursor(WebCore::PlatformCursorHandle) { return false; } -
trunk/WebKit/mac/WebCoreSupport/WebChromeClient.mm
r56439 r57903 645 645 } 646 646 647 void WebChromeClient::chooseIconForFiles(const Vector<String>& filenames, PassRefPtr<FileChooser>chooser)647 void WebChromeClient::chooseIconForFiles(const Vector<String>& filenames, FileChooser* chooser) 648 648 { 649 649 chooser->iconLoaded(Icon::createIconForFiles(filenames)); -
trunk/WebKit/qt/ChangeLog
r57856 r57903 1 2010-04-20 Kent Tamura <tkent@chromium.org> 2 3 Reviewed by Darin Adler. 4 5 Change a parameter type of chooseIconForFiles() 6 https://bugs.webkit.org/show_bug.cgi?id=37504 7 8 * WebCoreSupport/ChromeClientQt.cpp: 9 (WebCore::ChromeClientQt::chooseIconForFiles): 10 * WebCoreSupport/ChromeClientQt.h: 11 1 12 2010-04-19 Jocelyn Turcotte <jocelyn.turcotte@nokia.com> 2 13 -
trunk/WebKit/qt/WebCoreSupport/ChromeClientQt.cpp
r57656 r57903 518 518 } 519 519 520 void ChromeClientQt::chooseIconForFiles(const Vector<String>& filenames, PassRefPtr<FileChooser>chooser)520 void ChromeClientQt::chooseIconForFiles(const Vector<String>& filenames, FileChooser* chooser) 521 521 { 522 522 chooser->iconLoaded(Icon::createIconForFiles(filenames)); -
trunk/WebKit/qt/WebCoreSupport/ChromeClientQt.h
r57819 r57903 149 149 150 150 virtual void runOpenPanel(Frame*, PassRefPtr<FileChooser>); 151 virtual void chooseIconForFiles(const Vector<String>&, PassRefPtr<FileChooser>);151 virtual void chooseIconForFiles(const Vector<String>&, FileChooser*); 152 152 153 153 virtual void formStateDidChange(const Node*) { } -
trunk/WebKit/win/ChangeLog
r57856 r57903 1 2010-04-20 Kent Tamura <tkent@chromium.org> 2 3 Reviewed by Darin Adler. 4 5 Change a parameter type of chooseIconForFiles() 6 https://bugs.webkit.org/show_bug.cgi?id=37504 7 8 * WebCoreSupport/WebChromeClient.cpp: 9 (WebChromeClient::chooseIconForFiles): 10 * WebCoreSupport/WebChromeClient.h: 11 1 12 2010-04-16 Gavin Barraclough <barraclough@apple.com> 2 13 -
trunk/WebKit/win/WebCoreSupport/WebChromeClient.cpp
r56439 r57903 751 751 } 752 752 753 void WebChromeClient::chooseIconForFiles(const Vector<WebCore::String>& filenames, PassRefPtr<WebCore::FileChooser>chooser)753 void WebChromeClient::chooseIconForFiles(const Vector<WebCore::String>& filenames, WebCore::FileChooser* chooser) 754 754 { 755 755 chooser->iconLoaded(Icon::createIconForFiles(filenames)); -
trunk/WebKit/win/WebCoreSupport/WebChromeClient.h
r56851 r57903 127 127 128 128 virtual void runOpenPanel(WebCore::Frame*, PassRefPtr<WebCore::FileChooser>); 129 virtual void chooseIconForFiles(const Vector<WebCore::String>&, PassRefPtr<WebCore::FileChooser>);129 virtual void chooseIconForFiles(const Vector<WebCore::String>&, WebCore::FileChooser*); 130 130 131 131 virtual bool setCursor(WebCore::PlatformCursorHandle cursor); -
trunk/WebKit/wx/ChangeLog
r57863 r57903 1 2010-04-20 Kent Tamura <tkent@chromium.org> 2 3 Reviewed by Darin Adler. 4 5 Change a parameter type of chooseIconForFiles() 6 https://bugs.webkit.org/show_bug.cgi?id=37504 7 8 * WebKitSupport/ChromeClientWx.cpp: 9 (WebCore::ChromeClientWx::chooseIconForFiles): 10 * WebKitSupport/ChromeClientWx.h: 11 1 12 2010-04-19 Kevin Ollivier <kevino@theolliviers.com> 2 13 -
trunk/WebKit/wx/WebKitSupport/ChromeClientWx.cpp
r56439 r57903 443 443 } 444 444 445 void ChromeClientWx::chooseIconForFiles(const Vector<String>& filenames, PassRefPtr<FileChooser>chooser)445 void ChromeClientWx::chooseIconForFiles(const Vector<String>& filenames, FileChooser* chooser) 446 446 { 447 447 chooser->iconLoaded(Icon::createIconForFiles(filenames)); -
trunk/WebKit/wx/WebKitSupport/ChromeClientWx.h
r56851 r57903 129 129 130 130 virtual void runOpenPanel(Frame*, PassRefPtr<FileChooser>); 131 virtual void chooseIconForFiles(const Vector<String>&, PassRefPtr<FileChooser>);131 virtual void chooseIconForFiles(const Vector<String>&, FileChooser*); 132 132 133 133 virtual void formStateDidChange(const Node*) { }
Note: See TracChangeset
for help on using the changeset viewer.