Changeset 57980 in webkit

Timestamp:

Apr 21, 2010 7:42:39 AM (14 years ago)

Author:

Adam Roben

Message:

Fix leaks of FilterData/SVGFilterBuilder in RenderSVGResourceFilter

Fixes <​http://webkit.org/b/37922>.

Reviewed by Dave Hyatt.

• rendering/RenderSVGResourceFilter.cpp:

(WebCore::RenderSVGResourceFilter::applyResource): Use an OwnPtr to
hold the heap-allocated FilterData object, so that we won't leak it
when we bail out of this function on error.

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• rendering/RenderSVGResourceFilter.cpp (modified) (2 diffs)

trunk/WebCore/ChangeLog

@@ +1 @@
+2010-04-21  Adam Roben  <aroben@apple.com>
+
+        Fix leaks of FilterData/SVGFilterBuilder in RenderSVGResourceFilter
+
+        Fixes <http://webkit.org/b/37922>.
+
+        Reviewed by Dave Hyatt.
+
+        * rendering/RenderSVGResourceFilter.cpp:
+        (WebCore::RenderSVGResourceFilter::applyResource): Use an OwnPtr to
+        hold the heap-allocated FilterData object, so that we won't leak it
+        when we bail out of this function on error.
+
 2010-04-21  Zoltan Herczeg  <zherczeg@webkit.org>
 

trunk/WebCore/rendering/RenderSVGResourceFilter.cpp

@@ -150 +150 @@
     }
 
-    FilterData* filterData = new FilterData;
+    OwnPtr<FilterData> filterData(new FilterData);
     filterData->builder = buildPrimitives();
     if (!filterData->builder)
@@ -224 +224 @@
 
     context = sourceGraphicContext;
-    m_filter.set(object, filterData);
+    m_filter.set(object, filterData.release());
 
     return true;