Changeset 58046 in webkit
- Timestamp:
- Apr 21, 2010 8:22:10 PM (14 years ago)
- Location:
- trunk/WebKit/chromium
- Files:
-
- 2 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/WebKit/chromium/ChangeLog
r58032 r58046 1 2010-04-21 Jay Civelli <jcivelli@chromium.org> 2 3 Reviewed by Darin Fisher. 4 5 [Chromium] Don't notify the WebView that a popup was 6 opened when the popup is handled externally, as the popup 7 is in that case transparent to the WebView. 8 The notification was causing an ASSERT on Mac (where 9 the popup is handled externally) as there would be no 10 notification that the popup was closed. 11 https://bugs.webkit.org/show_bug.cgi?id=37825 12 13 * src/ChromeClientImpl.cpp: 14 (WebKit::ChromeClientImpl::popupOpened): 15 1 16 2010-04-21 Sheriff Bot <webkit.review.bot@gmail.com> 2 17 -
trunk/WebKit/chromium/src/ChromeClientImpl.cpp
r57903 r58046 630 630 if (!webwidget) 631 631 webwidget = m_webView->client()->createPopupMenu(false); 632 } 633 m_webView->popupOpened(popupContainer); 632 // We only notify when the WebView has to handle the popup, as when 633 // the popup is handled externally, the fact that a popup is showing is 634 // transparent to the WebView. 635 m_webView->popupOpened(popupContainer); 636 } 634 637 static_cast<WebPopupMenuImpl*>(webwidget)->Init(popupContainer, bounds); 635 638 }
Note: See TracChangeset
for help on using the changeset viewer.