Changeset 58205 in webkit


Ignore:
Timestamp:
Apr 23, 2010 6:05:02 PM (14 years ago)
Author:
eric@webkit.org
Message:

2010-04-23 Rafael Weinstein <​rafaelw@grafaelw.sfo.corp.google.com>

Reviewed by Darin Fisher.

This patch adds a vector of additionalFeatures to WindowFeatures
and populates it with any feature strings that evaluate to "yes"
and aren't directly observed in WindowFeatures. This allows
clients to capture experimental window features.

​https://bugs.webkit.org/show_bug.cgi?id=38013

  • page/WindowFeatures.cpp: (WebCore::WindowFeatures::setWindowFeature):
  • page/WindowFeatures.h:

2010-04-23 Rafael Weinstein <​rafaelw@grafaelw.sfo.corp.google.com>

Reviewed by Darin Fisher.

This patch adds a WebWindowFeatures binding struct for the
chromium client in anticipation of a follow-on patch which will
pass it to WebViewClient::createWindow.

​https://bugs.webkit.org/show_bug.cgi?id=38013

  • public/WebViewClient.h: (WebKit::WebViewClient::createView):
  • public/WebWindowFeatures.h: Added. (WebKit::WebWindowFeatures::WebWindowFeatures):
  • src/ChromeClientImpl.cpp: (WebKit::ChromeClientImpl::createWindow):
Location:
trunk
Files:
1 added
4 edited

Legend:

Unmodified
Added
Removed

  • trunk/WebCore/ChangeLog

    r58203 r58205  
     12010-04-23  Rafael Weinstein  <rafaelw@grafaelw.sfo.corp.google.com>
     2
     3        Reviewed by Darin Fisher.
     4
     5        This patch adds a vector of additionalFeatures to WindowFeatures
     6        and populates it with any feature strings that evaluate to "yes"
     7        and aren't directly observed in WindowFeatures. This allows
     8        clients to capture experimental window features.
     9
     10        https://bugs.webkit.org/show_bug.cgi?id=38013
     11
     12        * page/WindowFeatures.cpp:
     13        (WebCore::WindowFeatures::setWindowFeature):
     14        * page/WindowFeatures.h:
     15
    1162010-04-23  Dan Bernstein  <mitz@apple.com>
    217

  • trunk/WebCore/page/WindowFeatures.cpp

    r29663 r58205  
    156156    else if (keyString == "scrollbars")
    157157        scrollbarsVisible = value;
     158    else if (value == 1)
     159        additionalFeatures.append(keyString);
    158160}
    159161

  • trunk/WebCore/page/WindowFeatures.h

    r28592 r58205  
    7777        bool fullscreen;
    7878        bool dialog;
     79
     80        Vector<String> additionalFeatures;
    7981    };
    8082

  • trunk/WebKit/chromium/ChangeLog

    r58140 r58205  
     12010-04-23  Rafael Weinstein  <rafaelw@grafaelw.sfo.corp.google.com>
     2
     3        Reviewed by Darin Fisher.
     4
     5        This patch adds a WebWindowFeatures binding struct for the
     6        chromium client in anticipation of a follow-on patch which will
     7        pass it to WebViewClient::createWindow.
     8
     9        https://bugs.webkit.org/show_bug.cgi?id=38013
     10
     11        * public/WebViewClient.h:
     12        (WebKit::WebViewClient::createView):
     13        * public/WebWindowFeatures.h: Added.
     14        (WebKit::WebWindowFeatures::WebWindowFeatures):
     15        * src/ChromeClientImpl.cpp:
     16        (WebKit::ChromeClientImpl::createWindow):
     17
    1182010-04-22  Zhenyao Mo  <zmo@google.com>
    219
Note: See TracChangeset for help on using the changeset viewer.