Changeset 58230 in webkit

Timestamp:

Apr 25, 2010 9:16:58 AM (14 years ago)

Author:

hamaji@chromium.org

Message:

2010-04-25 Shinichiro Hamaji <​hamaji@chromium.org>

Reviewed by Simon Hausmann.

[Qt] layoutTestController.counterValueForElementById crashes for a nonexistent ID
​https://bugs.webkit.org/show_bug.cgi?id=34573

• WebCoreSupport/DumpRenderTreeSupportQt.cpp: (DumpRenderTreeSupportQt::counterValueForElementById):

Location:

trunk/WebKit/qt

Files:

• ChangeLog (modified) (1 diff)
• WebCoreSupport/DumpRenderTreeSupportQt.cpp (modified) (1 diff)

trunk/WebKit/qt/ChangeLog

@@ +1 @@
+2010-04-25  Shinichiro Hamaji  <hamaji@chromium.org>
+
+        Reviewed by Simon Hausmann.
+
+        [Qt] layoutTestController.counterValueForElementById crashes for a nonexistent ID
+        https://bugs.webkit.org/show_bug.cgi?id=34573
+
+        * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
+        (DumpRenderTreeSupportQt::counterValueForElementById):
+
 2010-04-20  Robert Hogan  <robert@webkit.org>
 

trunk/WebKit/qt/WebCoreSupport/DumpRenderTreeSupportQt.cpp

@@ -266 +266 @@
     Frame* coreFrame = QWebFramePrivate::core(frame);
     if (Document* document = coreFrame->document()) {
-        Element* element = document->getElementById(id);
-        return WebCore::counterValueForElement(element);
+        if (Element* element = document->getElementById(id))
+            return WebCore::counterValueForElement(element);
     }
     return QString();