Changeset 58282 in webkit

Timestamp:

Apr 26, 2010 8:36:06 PM (14 years ago)

Author:

abarth@webkit.org

Message:

2010-04-26 Adam Barth <​abarth@webkit.org>

Unreviewed, rolling out r58265.
​http://trac.webkit.org/changeset/58265
​https://bugs.webkit.org/show_bug.cgi?id=38021

This change prevents me from uploading patches. It also breaks sheriff-bot.

• Scripts/webkitpy/tool/steps/options.py:

Location:

trunk/WebKitTools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/webkitpy/tool/steps/options.py (modified) (1 diff)

trunk/WebKitTools/ChangeLog

@@ +1 @@
+2010-04-26  Adam Barth  <abarth@webkit.org>
+
+        Unreviewed, rolling out r58265.
+        http://trac.webkit.org/changeset/58265
+        https://bugs.webkit.org/show_bug.cgi?id=38021
+
+        This change prevents me from uploading patches.  It also breaks sheriff-bot.
+
+        * Scripts/webkitpy/tool/steps/options.py:
+
 2010-04-26  Eric Seidel  <eric@webkit.org>
 

trunk/WebKitTools/Scripts/webkitpy/tool/steps/options.py

@@ -41 +41 @@
     description = make_option("-m", "--description", action="store", type="string", dest="description", help="Description string for the attachment (default: \"patch\")")
     email = make_option("--email", action="store", type="string", dest="email", help="Email address to use in ChangeLogs.")
-    fancy_review = make_option("--no-fancy-review", action="store_false", dest="fancy_review", default=True, help="Do not upload the patch to Rietveld code review tool.")
+    fancy_review = make_option("--fancy-review", action="store_true", dest="fancy_review", default=False, help="(Experimental) Upload the patch to Rietveld code review tool.")
     force_clean = make_option("--force-clean", action="store_true", dest="force_clean", default=False, help="Clean working directory before applying patches (removes local changes and commits)")
 # FIXME: Make commit ranges treat each commit separately instead of squashing them into one.