Changeset 58329 in webkit

Timestamp:

Apr 27, 2010 1:25:07 PM (14 years ago)

Author:

abarth@webkit.org

Message:

2010-04-27 Adam Barth <​abarth@webkit.org>

Reviewed by Darin Adler.

run-bindings-tests should use --reset-results instead of --overwrite
​https://bugs.webkit.org/show_bug.cgi?id=38200

As requested by Ojan.

• Scripts/run-bindings-tests:

Location:

trunk/WebKitTools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/run-bindings-tests (modified) (6 diffs)

trunk/WebKitTools/ChangeLog

@@ +1 @@
+2010-04-27  Adam Barth  <abarth@webkit.org>
+
+        Reviewed by Darin Adler.
+
+        run-bindings-tests should use --reset-results instead of --overwrite
+        https://bugs.webkit.org/show_bug.cgi?id=38200
+
+        As requested by Ojan.
+
+        * Scripts/run-bindings-tests:
+
 2010-04-27  Adam Barth  <abarth@webkit.org>
 

trunk/WebKitTools/Scripts/run-bindings-tests

@@ -68 +68 @@
 
 
-def run_tests(generator, input_directory, reference_directory, overwrite):
+def run_tests(generator, input_directory, reference_directory, reset_results):
     work_directory = reference_directory
 
@@ -78 +78 @@
         print 'Testing the %s generator on %s' % (generator, input_file)
         # Generate output into the work directory (either the given one or a 
-        # temp one if not overwrite is performed)
-        if not overwrite:
+        # temp one if not reset_results is performed)
+        if not reset_results:
             work_directory = tempfile.mkdtemp()
         if not generate_from_idl(generator, os.path.join(input_directory,
@@ -85 +85 @@
                                  work_directory):
             passed = False
-        if overwrite:
+        if reset_results:
             print "Overwrote reference files"
             continue
@@ -102 +102 @@
 
     Options:
-        --overwrite: Overwrites the reference files with the generated results.
+       --reset-results: Overwrites the reference files with the generated results.
 
     """
-    overwrite = "--overwrite" in argv
+    reset_results = "--reset-results" in argv
 
     current_scm = scm.detect_scm_system(os.curdir)
@@ -122 +122 @@
         input_directory = os.path.join('WebCore', 'bindings', 'scripts', 'test')
         reference_directory = os.path.join('WebCore', 'bindings', 'scripts', 'test', generator)
-        if not run_tests(generator, input_directory, reference_directory, overwrite):
+        if not run_tests(generator, input_directory, reference_directory, reset_results):
             all_tests_passed = False
 
@@ -129 +129 @@
         return 0
     else:
-        print '(To update the reference files, execute "run-bindings-test --overwrite")'
+        print '(To update the reference files, execute "run-bindings-test --reset-results")'
         return -1