Changeset 58377 in webkit

Timestamp:

Apr 27, 2010 9:53:19 PM (14 years ago)

Author:

tkent@chromium.org

Message:

2010-04-27 Kent Tamura <​tkent@chromium.org>

Reviewed by Shinichiro Hamaji.

[DRT/Chromium] Enable Windows project generation
​https://bugs.webkit.org/show_bug.cgi?id=38103

• Avoid platform.system(), which causes a crash with python.exe in depot_tools. Use sys.platform instead.
• Process DumpRenderTree.gyp on all platforms.

• gyp_webkit:

Location:

trunk/WebKit/chromium

Files:

• ChangeLog (modified) (1 diff)
• gyp_webkit (modified) (3 diffs)

trunk/WebKit/chromium/ChangeLog

@@ +1 @@
+2010-04-27  Kent Tamura  <tkent@chromium.org>
+
+        Reviewed by Shinichiro Hamaji.
+
+        [DRT/Chromium] Enable Windows project generation
+        https://bugs.webkit.org/show_bug.cgi?id=38103
+
+        - Avoid platform.system(), which causes a crash with python.exe in
+          depot_tools. Use sys.platform instead.
+        - Process DumpRenderTree.gyp on all platforms.
+
+        * gyp_webkit:
+
 2010-04-27  Jay Civelli  <jcivelli@chromium.org>
 

trunk/WebKit/chromium/gyp_webkit

@@ -33 +33 @@
 import glob
 import os
-import platform
 import shlex
 import sys
@@ -79 +78 @@
 
   # On linux, we want gyp to output a makefile (default is scons).
-  if platform.system() == 'Linux':
+  if sys.platform == 'linux2':
     args.extend(['-fmake'])
 
@@ -92 +91 @@
                '--depth=./',
 
-               # gyp file to execute.
-               'WebKit.gyp'])
-
-  # Generate DRT build files on the platforms that support it.
-  if platform.system() in ('Darwin', 'Linux'):
-    args.append('../../WebKitTools/DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp')
+               # gyp files to execute.
+               'WebKit.gyp',
+               '../../WebKitTools/DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp'])
 
   print 'Updating webkit projects from gyp files...'