Changeset 58382 in webkit


Ignore:
Timestamp:
Apr 27, 2010 11:00:03 PM (14 years ago)
Author:
eric@webkit.org
Message:

2010-04-27 Jens Alfke <snej@chromium.org>

Reviewed by Eric Seidel.

[chromium] Fix bug that prevents autosave of forms without action attribute
https://bugs.webkit.org/show_bug.cgi?id=38014
Change is in the Chromium WebKit API so it can't be tested with a JS-based layout test.
It needs a native unit test, which would go in the Chromium repo, not WebKit.

  • src/WebPasswordFormData.cpp: (WebKit::WebPasswordFormData::WebPasswordFormData): Set correct URL if action is NULL
Location:
trunk/WebKit/chromium
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/WebKit/chromium/ChangeLog

    r58380 r58382  
     12010-04-27  Jens Alfke  <snej@chromium.org>
     2
     3        Reviewed by Eric Seidel.
     4
     5        [chromium] Fix bug that prevents autosave of forms without action attribute
     6        https://bugs.webkit.org/show_bug.cgi?id=38014
     7        Change is in the Chromium WebKit API so it can't be tested with a JS-based layout test.
     8        It needs a native unit test, which would go in the Chromium repo, not WebKit.
     9
     10        * src/WebPasswordFormData.cpp:
     11        (WebKit::WebPasswordFormData::WebPasswordFormData): Set correct URL if action is NULL
     12
    1132010-04-27  Michael Nordman  <michaeln@google.com>
    214
  • trunk/WebKit/chromium/src/WebPasswordFormData.cpp

    r50722 r58382  
    163163
    164164    // Calculate the canonical action URL
    165     KURL fullAction = frame->loader()->completeURL(form->action());
     165    String action = form->action();
     166    if (action.isNull())
     167        action = ""; // missing 'action' attribute implies current URL
     168    KURL fullAction = frame->loader()->completeURL(action);
    166169    if (!fullAction.isValid())
    167170        return;
Note: See TracChangeset for help on using the changeset viewer.