Changeset 58419 in webkit

Timestamp:

Apr 28, 2010 12:15:03 PM (14 years ago)

Author:

eric@webkit.org

Message:

2010-04-28 Ilya Tikhonovsky <​loislo@chromium.org>

Reviewed by Yury Semikhatsky.

WebInspector: Timeline: We can have precise urls in the EvaluateScript records.
​https://bugs.webkit.org/show_bug.cgi?id=38264

• inspector/front-end/TimelinePanel.js: (WebInspector.TimelinePanel.FormattedRecord.prototype._generatePopupContent): (WebInspector.TimelinePanel.FormattedRecord.prototype._getRecordDetails):

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• inspector/front-end/TimelinePanel.js (modified) (2 diffs)

trunk/WebCore/ChangeLog

@@ +1 @@
+2010-04-28  Ilya Tikhonovsky  <loislo@chromium.org>
+
+        Reviewed by Yury Semikhatsky.
+
+        WebInspector: Timeline: We can have precise urls in the EvaluateScript records.
+        https://bugs.webkit.org/show_bug.cgi?id=38264
+
+        * inspector/front-end/TimelinePanel.js:
+        (WebInspector.TimelinePanel.FormattedRecord.prototype._generatePopupContent):
+        (WebInspector.TimelinePanel.FormattedRecord.prototype._getRecordDetails):
+
 2010-04-28  Pavel Feldman  <pfeldman@chromium.org>
 

trunk/WebCore/inspector/front-end/TimelinePanel.js

@@ -952 +952 @@
                     recordContentTable.appendChild(this._createRow(WebInspector.UIString("Expected Content Length"), this.data.expectedContentLength));
             } else if (this.type === recordTypes.EvaluateScript) {
-                var link = WebInspector.linkifyResourceAsNode(this.data.url, "scripts", null, "timeline-details");
+                var link = WebInspector.linkifyResourceAsNode(this.data.url, "scripts", this.data.lineNumber, "timeline-details");
                 recordContentTable.appendChild(this._createLinkRow(WebInspector.UIString("Script"), link));
             } else if (this.type === recordTypes.Paint) {
@@ -986 +986 @@
             case WebInspector.TimelineAgent.RecordType.TimerFire:
                 return record.data.timerId;
+            case WebInspector.TimelineAgent.RecordType.EvaluateScript:
+                return record.data.url ? WebInspector.displayNameForURL(record.data.url) + ":" + record.data.lineNumber : "";
             case WebInspector.TimelineAgent.RecordType.XHRReadyStateChange:
             case WebInspector.TimelineAgent.RecordType.XHRLoad:
-            case WebInspector.TimelineAgent.RecordType.EvaluateScript:
             case WebInspector.TimelineAgent.RecordType.ResourceSendRequest:
             case WebInspector.TimelineAgent.RecordType.ResourceReceiveData: