Changeset 58511 in webkit

Timestamp:

Apr 29, 2010 6:50:07 AM (14 years ago)

Author:

xan@webkit.org

Message:

2010-04-29 Xan Lopez <​xlopez@igalia.com>

Reviewed by Gustavo Noronha.

[GTK] GObject DOM bindings
​https://bugs.webkit.org/show_bug.cgi?id=33590

Add WebKitDOMDocument tests to the build.

• GNUmakefile.am:

WebKit/gtk:

2010-04-29 Xan Lopez <​xlopez@igalia.com>

Reviewed by Gustavo Noronha.

[GTK] GObject DOM bindings
​https://bugs.webkit.org/show_bug.cgi?id=33590

Move WebKitDOMDocument unit tests to their own file.

• tests/testdomdocument.c: Added. (finish_loading): (dom_document_fixture_setup): (dom_document_fixture_teardown): (test_dom_document_title): (main):
• tests/testwebview.c:

Location:

trunk

Files:

• ChangeLog (modified) (1 diff)
• GNUmakefile.am (modified) (2 diffs)
• WebKit/gtk/ChangeLog (modified) (1 diff)
• WebKit/gtk/tests/testdomdocument.c (added)
• WebKit/gtk/tests/testwebview.c (modified) (2 diffs)

trunk/ChangeLog

@@ +1 @@
+2010-04-29  Xan Lopez  <xlopez@igalia.com>
+
+        Reviewed by Gustavo Noronha.
+
+        [GTK] GObject DOM bindings
+        https://bugs.webkit.org/show_bug.cgi?id=33590
+
+        Add WebKitDOMDocument tests to the build.
+
+        * GNUmakefile.am:
+
 2010-04-28  Sam Weinig  <sam@webkit.org>
 

trunk/GNUmakefile.am

@@ -623 +623 @@
         -no-fast-install
 
-TEST_PROGS += Programs/unittests/testhttpbackend \
+TEST_PROGS += \
+        Programs/unittests/testdomdocument \
+        Programs/unittests/testhttpbackend \
         Programs/unittests/testloading \
         Programs/unittests/testglobals \
@@ -644 +646 @@
 
 # Add additional tests here
+Programs_unittests_testdomdocument_SOURCES = WebKit/gtk/tests/testdomdocument.c
+Programs_unittests_testdomdocument_CFLAGS = $(webkit_tests_cflags)
+Programs_unittests_testdomdocument_LDADD = $(webkit_tests_ldadd)
+Programs_unittests_testdomdocument_LDFLAGS = $(webkit_tests_ldflags)
+
 Programs_unittests_testhttpbackend_SOURCES = WebKit/gtk/tests/testhttpbackend.c
 Programs_unittests_testhttpbackend_CFLAGS = $(webkit_tests_cflags)

trunk/WebKit/gtk/ChangeLog

@@ +1 @@
+2010-04-29  Xan Lopez  <xlopez@igalia.com>
+
+        Reviewed by Gustavo Noronha.
+
+        [GTK] GObject DOM bindings
+        https://bugs.webkit.org/show_bug.cgi?id=33590
+
+        Move WebKitDOMDocument unit tests to their own file.
+
+        * tests/testdomdocument.c: Added.
+        (finish_loading):
+        (dom_document_fixture_setup):
+        (dom_document_fixture_teardown):
+        (test_dom_document_title):
+        (main):
+        * tests/testwebview.c:
+
 2010-04-29  Xan Lopez  <xlopez@igalia.com>
 

trunk/WebKit/gtk/tests/testwebview.c

@@ -337 +337 @@
 }    
 
-static void test_webkit_web_view_document()
-{
-    GtkWidget* window;
-    GtkWidget* web_view;
-    gchar* title;
-    WebKitDOMDocument* document;
-    
-    window = gtk_window_new(GTK_WINDOW_TOPLEVEL);
-    web_view = webkit_web_view_new();
-    
-    gtk_container_add(GTK_CONTAINER(window), web_view);
-    gtk_widget_show_all(window);
-
-    loop = g_main_loop_new(NULL, TRUE);
-
-    g_signal_connect(window, "map-event",
-                     G_CALLBACK(map_event_cb), loop);
-    g_main_loop_run(loop);
-
-    document = webkit_web_view_get_dom_document(WEBKIT_WEB_VIEW(web_view));
-    g_assert(document);
-    webkit_dom_document_set_title(document, (gchar*)"First title");
-    title = webkit_dom_document_get_title(document);
-    g_assert(title);
-    g_assert_cmpstr(title, ==, "First title");
-    g_free(title);
-    webkit_dom_document_set_title(document, (gchar*)"Title changed by DOM bindings");
-    title = webkit_dom_document_get_title(document);
-    g_assert(title);
-    g_assert_cmpstr(title, ==, "Title changed by DOM bindings");
-    g_free(title);
-    
-    gtk_widget_destroy(window);
-}    
-
 int main(int argc, char** argv)
 {
@@ -400 +365 @@
     g_test_add_func("/webkit/webview/grab_focus", test_webkit_web_view_grab_focus);
     g_test_add_func("/webkit/webview/window-features", test_webkit_web_view_window_features);
-    g_test_add_func("/webkit/webview/document", test_webkit_web_view_document);
 
     return g_test_run ();