Changeset 58749 in webkit

Timestamp:

May 4, 2010 4:16:20 AM (14 years ago)

Author:

xan@webkit.org

Message:

2010-05-04 Xan Lopez <​xlopez@igalia.com>

Reviewed by Holger Freyther.

[GTK] GObject DOM bindings
​https://bugs.webkit.org/show_bug.cgi?id=33590

Use helper functions from CodeGenerator.pm to figure out whether a
type is "fundamental" or not (basically whether it's anything
other than a string or a non-pointer type).

• bindings/scripts/CodeGeneratorGObject.pm:

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• bindings/scripts/CodeGeneratorGObject.pm (modified) (1 diff)

trunk/WebCore/ChangeLog

@@ +1 @@
+2010-05-04  Xan Lopez  <xlopez@igalia.com>
+
+        Reviewed by Holger Freyther.
+
+        [GTK] GObject DOM bindings
+        https://bugs.webkit.org/show_bug.cgi?id=33590
+
+        Use helper functions from CodeGenerator.pm to figure out whether a
+        type is "fundamental" or not (basically whether it's anything
+        other than a string or a non-pointer type).
+
+        * bindings/scripts/CodeGeneratorGObject.pm:
+
 2010-04-30  Alexander Pavlov  <apavlov@chromium.org>
 

trunk/WebCore/bindings/scripts/CodeGeneratorGObject.pm

@@ -262 +262 @@
     my $type = shift;
 
-    return 0 if $type eq "DOMString";
-    return 0 if $type eq "CompareHow";
-    return 0 if $type eq "float";
-    return 0 if $type eq "double";
-    return 0 if $type eq "boolean";
-    return 0 if $type eq "char";
-    return 0 if $type eq "long";
-    return 0 if $type eq "long long";
-    return 0 if $type eq "short";
-    return 0 if $type eq "uchar";
-    return 0 if $type eq "unsigned";
-    return 0 if $type eq "int";
-    return 0 if $type eq "unsigned int";
-    return 0 if $type eq "unsigned long";
-    return 0 if $type eq "unsigned long long";
-    return 0 if $type eq "unsigned short";
-    return 0 if $type eq "void";
-
+    return 0 if $codeGenerator->IsNonPointerType($type) || $codeGenerator->IsStringType($type);
     return 1;
 }