Changeset 58764 in webkit


Ignore:
Timestamp:
May 4, 2010 9:31:22 AM (14 years ago)
Author:
eric@webkit.org
Message:

2010-05-04 Laszlo Gombos <Laszlo Gombos>

Reviewed by Kenneth Rohde Christiansen.

[Qt] QWebPage viewMode property
​https://bugs.webkit.org/show_bug.cgi?id=38119

Rename the property from wrt_viewMode to _q_viewMode.

  • Api/qwebpage.cpp: (QWebPagePrivate::dynamicPropertyChangeEvent):
  • tests/qwebpage/tst_qwebpage.cpp: (tst_QWebPage::viewModes):

2010-05-04 Laszlo Gombos <Laszlo Gombos>

Reviewed by Kenneth Rohde Christiansen.

[Qt] QWebPage viewMode property
​https://bugs.webkit.org/show_bug.cgi?id=38119

Rename the property from wrt_viewMode to _q_viewMode.

  • DumpRenderTree/qt/LayoutTestControllerQt.cpp: (LayoutTestController::setViewModeMediaFeature):
Location:
trunk
Files:
5 edited

Legend:

Unmodified
Added
Removed

  • trunk/WebKit/qt/Api/qwebpage.cpp

    r58727 r58764  
    12061206void QWebPagePrivate::dynamicPropertyChangeEvent(QDynamicPropertyChangeEvent* event)
    12071207{
    1208     if (event->propertyName() == "wrt_viewMode") {
    1209         QString mode = q->property("wrt_viewMode").toString();
     1208    if (event->propertyName() == "_q_viewMode") {
     1209        QString mode = q->property("_q_viewMode").toString();
    12101210        if (mode != viewMode) {
    12111211            viewMode = mode;

  • trunk/WebKit/qt/ChangeLog

    r58754 r58764  
     12010-05-04  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
     2
     3        Reviewed by Kenneth Rohde Christiansen.
     4
     5        [Qt] QWebPage viewMode property
     6        https://bugs.webkit.org/show_bug.cgi?id=38119
     7
     8        Rename the property from wrt_viewMode to _q_viewMode.
     9
     10        * Api/qwebpage.cpp:
     11        (QWebPagePrivate::dynamicPropertyChangeEvent):
     12        * tests/qwebpage/tst_qwebpage.cpp:
     13        (tst_QWebPage::viewModes):
     14
    1152010-05-04  Simon Hausmann  <simon.hausmann@nokia.com>
    216

  • trunk/WebKit/qt/tests/qwebpage/tst_qwebpage.cpp

    r58648 r58764  
    112112    void userAgentLocaleChange();
    113113
    114     void wrt_viewModes();
     114    void viewModes();
    115115
    116116    void crashTests_LazyInitializationOfMainFrame();
    … …  
    361361}
    362362
    363 void tst_QWebPage::wrt_viewModes()
     363void tst_QWebPage::viewModes()
    364364{
    365365    m_view->setHtml("<body></body>");
    366     m_page->setProperty("wrt_viewMode", "minimized");
     366    m_page->setProperty("_q_viewMode", "minimized");
    367367
    368368    QVariant empty = m_page->mainFrame()->evaluateJavaScript("window.styleMedia.matchMedium(\"(-webkit-view-mode)\")");

  • trunk/WebKitTools/ChangeLog

    r58759 r58764  
     12010-05-04  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
     2
     3        Reviewed by Kenneth Rohde Christiansen.
     4
     5        [Qt] QWebPage viewMode property
     6        https://bugs.webkit.org/show_bug.cgi?id=38119
     7
     8        Rename the property from wrt_viewMode to _q_viewMode.
     9
     10        * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
     11        (LayoutTestController::setViewModeMediaFeature):
     12
    1132010-05-04  Jochen Eisinger  <jochen@chromium.org>
    214

  • trunk/WebKitTools/DumpRenderTree/qt/LayoutTestControllerQt.cpp

    r58703 r58764  
    141141void LayoutTestController::setViewModeMediaFeature(const QString& mode)
    142142{
    143     m_drt->webPage()->setProperty("wrt_viewMode", mode);
     143    m_drt->webPage()->setProperty("_q_viewMode", mode);
    144144}
    145145
Note: See TracChangeset for help on using the changeset viewer.