Changeset 58804 in webkit

Timestamp:

May 5, 2010 12:31:40 AM (14 years ago)

Author:

krit@webkit.org

Message:

2010-05-05 Dirk Schulze <​krit@webkit.org>

Reviewed by Nikolas Zimmermann.

SVG hit testing is *way* too slow
​https://bugs.webkit.org/show_bug.cgi?id=19312

Use the cached stroke and fill boundaries in RenderPath as a heuristik to
speed up SVG's hit testing.

No new tests added.

• rendering/RenderPath.cpp: (WebCore::RenderPath::fillContains): (WebCore::RenderPath::strokeContains):

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• rendering/RenderPath.cpp (modified) (2 diffs)

trunk/WebCore/ChangeLog

@@ +1 @@
+2010-05-05  Dirk Schulze  <krit@webkit.org>
+
+        Reviewed by Nikolas Zimmermann.
+
+        SVG hit testing is *way* too slow
+        https://bugs.webkit.org/show_bug.cgi?id=19312
+
+        Use the cached stroke and fill boundaries in RenderPath as a heuristik to
+        speed up SVG's hit testing.
+
+        No new tests added.
+
+        * rendering/RenderPath.cpp:
+        (WebCore::RenderPath::fillContains):
+        (WebCore::RenderPath::strokeContains):
+
 2010-05-04  Dumitru Daniliuc  <dumi@chromium.org>
 

trunk/WebCore/rendering/RenderPath.cpp

@@ -74 +74 @@
 bool RenderPath::fillContains(const FloatPoint& point, bool requiresFill) const
 {
-    if (m_path.isEmpty())
+    if (!m_fillBoundingBox.contains(point))
         return false;
 
@@ -85 +85 @@
 bool RenderPath::strokeContains(const FloatPoint& point, bool requiresStroke) const
 {
-    if (m_path.isEmpty())
+    if (!m_strokeAndMarkerBoundingBox.contains(point))
         return false;