Changeset 59585 in webkit


Ignore:
Timestamp:
May 16, 2010 5:26:32 PM (14 years ago)
Author:
tony@chromium.org
Message:

2010-05-12 Tony Chang <tony@chromium.org>

Reviewed by Darin Adler.

Spellcheck disabling does not disable context menu
https://bugs.webkit.org/show_bug.cgi?id=25639

  • editing/spelling/context-menu-suggestions.html: Added.
  • platform/chromium/test_expectations.txt:
  • platform/gtk/Skipped:
  • platform/mac-leopard/editing/spelling/context-menu-suggestions-expected.txt: Added.
  • platform/qt/Skipped:
  • platform/win/Skipped:

2010-05-12 Tony Chang <tony@chromium.org>

Reviewed by Darin Adler.

Spellcheck disabling does not disable context menu
https://bugs.webkit.org/show_bug.cgi?id=25639

Test: editing/spelling/context-menu-suggestions.html

  • platform/ContextMenu.cpp: (WebCore::ContextMenu::populate):

2010-05-12 Tony Chang <tony@chromium.org>

Reviewed by Darin Adler.

Spellcheck disabling does not disable context menu
https://bugs.webkit.org/show_bug.cgi?id=25639

  • DumpRenderTree/mac/EventSendingController.mm: (+[EventSendingController isSelectorExcludedFromWebScript:]): (+[EventSendingController webScriptNameForSelector:]): (-[EventSendingController contextClick:]): add a bool parameter that

when true, dumps the context menu items to stdout.

Location:
trunk
Files:
3 added
9 edited

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/ChangeLog

    r59582 r59585  
     12010-05-12  Tony Chang  <tony@chromium.org>
     2
     3        Reviewed by Darin Adler.
     4
     5        Spellcheck disabling does not disable context menu
     6        https://bugs.webkit.org/show_bug.cgi?id=25639
     7
     8        * editing/spelling/context-menu-suggestions.html: Added.
     9        * platform/chromium/test_expectations.txt:
     10        * platform/gtk/Skipped:
     11        * platform/mac-leopard/editing/spelling/context-menu-suggestions-expected.txt: Added.
     12        * platform/qt/Skipped:
     13        * platform/win/Skipped:
     14
    1152010-05-16  Andreas Kling  <andreas.kling@nokia.com>
    216
  • trunk/LayoutTests/platform/chromium/test_expectations.txt

    r59541 r59585  
    28322832// Flaky crashing test. Started crashing around Chromium r47220
    28332833BUG44150 LINUX DEBUG : fast/forms/input-text-paste-maxlength.html = CRASH PASS
     2834
     2835// Need to dump context menu items on eventSender.contextClick(true).
     2836BUGWK39105 : editing/spelling/context-menu-suggestions.html = TEXT
  • trunk/LayoutTests/platform/gtk/Skipped

    r59568 r59585  
    59205920# Skip this, it's pending on one patch in the commit queue
    59215921accessibility/aria-controls-with-tabs.html
     5922
     5923# Need to dump context menu items on eventSender.contextClick(true).
     5924# https://bugs.webkit.org/show_bug.cgi?id=39102
     5925editing/spelling/context-menu-suggestions.html
  • trunk/LayoutTests/platform/qt/Skipped

    r59580 r59585  
    50915091# Discussed in https://bugs.webkit.org/show_bug.cgi?id=38928
    50925092fast/loader/recursive-before-unload-crash.html
     5093
     5094# Need to dump context menu items on eventSender.contextClick(true).
     5095# https://bugs.webkit.org/show_bug.cgi?id=39103
     5096editing/spelling/context-menu-suggestions.html
  • trunk/LayoutTests/platform/win/Skipped

    r59541 r59585  
    877877# https://bugs.webkit.org/show_bug.cgi?id=38795 - doesn't print PaintEvent instrumentation output
    878878inspector/timeline-paint.html
     879
     880# Need to dump context menu items on eventSender.contextClick(true). TODO: add bug number
     881# https://bugs.webkit.org/show_bug.cgi?id=39104
     882editing/spelling/context-menu-suggestions.html
  • trunk/WebCore/ChangeLog

    r59583 r59585  
     12010-05-12  Tony Chang  <tony@chromium.org>
     2
     3        Reviewed by Darin Adler.
     4
     5        Spellcheck disabling does not disable context menu
     6        https://bugs.webkit.org/show_bug.cgi?id=25639
     7
     8        Test: editing/spelling/context-menu-suggestions.html
     9
     10        * platform/ContextMenu.cpp:
     11        (WebCore::ContextMenu::populate):
     12
    1132010-05-16  Sam Weinig  <sam@webkit.org>
    214
  • trunk/WebCore/platform/ContextMenu.cpp

    r56825 r59585  
    393393        SelectionController* selection = frame->selection();
    394394        bool inPasswordField = selection->isInPasswordField();
     395        bool spellCheckingEnabled = frame->editor()->spellCheckingEnabledInFocusedNode();
    395396       
    396         if (!inPasswordField) {
     397        if (!inPasswordField && spellCheckingEnabled) {
    397398            // Consider adding spelling-related or grammar-related context menu items (never both, since a single selected range
    398399            // is never considered a misspelling and bad grammar at the same time)
  • trunk/WebKitTools/ChangeLog

    r59580 r59585  
     12010-05-12  Tony Chang  <tony@chromium.org>
     2
     3        Reviewed by Darin Adler.
     4
     5        Spellcheck disabling does not disable context menu
     6        https://bugs.webkit.org/show_bug.cgi?id=25639
     7
     8        * DumpRenderTree/mac/EventSendingController.mm:
     9        (+[EventSendingController isSelectorExcludedFromWebScript:]):
     10        (+[EventSendingController webScriptNameForSelector:]):
     11        (-[EventSendingController contextClick:]): add a bool parameter that
     12              when true, dumps the context menu items to stdout.
     13
    1142010-05-16  Robert Hogan  <robert@webkit.org>
    215
  • trunk/WebKitTools/DumpRenderTree/mac/EventSendingController.mm

    r56808 r59585  
    123123    if (aSelector == @selector(beginDragWithFiles:)
    124124            || aSelector == @selector(clearKillRing)
    125             || aSelector == @selector(contextClick)
     125            || aSelector == @selector(contextClick:)
    126126            || aSelector == @selector(enableDOMUIEventLogging:)
    127127            || aSelector == @selector(fireKeyboardEventsToElement:)
     
    153153    if (aSelector == @selector(beginDragWithFiles:))
    154154        return @"beginDragWithFiles";
     155    if (aSelector == @selector(contextClick:))
     156        return @"contextClick";
    155157    if (aSelector == @selector(enableDOMUIEventLogging:))
    156158        return @"enableDOMUIEventLogging";
     
    493495}
    494496
    495 - (void)contextClick
     497- (void)contextClick:(BOOL)shouldPrintMenuItems
    496498{
    497499    [[[mainFrame frameView] documentView] layout];
     
    509511
    510512    NSView *subView = [[mainFrame webView] hitTest:[event locationInWindow]];
    511     if (subView)
    512         [subView menuForEvent:event];
     513    if (subView) {
     514        NSMenu* menu = [subView menuForEvent:event];
     515        if (shouldPrintMenuItems) {
     516            printf("ContextMenuItems: ");
     517            for (int i = 0; i < [menu numberOfItems]; ++i) {
     518                if (i > 0)
     519                    printf(", ");
     520                NSMenuItem* menuItem = [menu itemAtIndex:i];
     521                fputs([menuItem isSeparatorItem] ? "<separator>" : [[menuItem title] UTF8String], stdout);
     522            }
     523            printf("\n");
     524        }
     525    }
    513526}
    514527
Note: See TracChangeset for help on using the changeset viewer.