Changeset 59585 in webkit
- Timestamp:
- May 16, 2010 5:26:32 PM (14 years ago)
- Location:
- trunk
- Files:
-
- 3 added
- 9 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/LayoutTests/ChangeLog
r59582 r59585 1 2010-05-12 Tony Chang <tony@chromium.org> 2 3 Reviewed by Darin Adler. 4 5 Spellcheck disabling does not disable context menu 6 https://bugs.webkit.org/show_bug.cgi?id=25639 7 8 * editing/spelling/context-menu-suggestions.html: Added. 9 * platform/chromium/test_expectations.txt: 10 * platform/gtk/Skipped: 11 * platform/mac-leopard/editing/spelling/context-menu-suggestions-expected.txt: Added. 12 * platform/qt/Skipped: 13 * platform/win/Skipped: 14 1 15 2010-05-16 Andreas Kling <andreas.kling@nokia.com> 2 16 -
trunk/LayoutTests/platform/chromium/test_expectations.txt
r59541 r59585 2832 2832 // Flaky crashing test. Started crashing around Chromium r47220 2833 2833 BUG44150 LINUX DEBUG : fast/forms/input-text-paste-maxlength.html = CRASH PASS 2834 2835 // Need to dump context menu items on eventSender.contextClick(true). 2836 BUGWK39105 : editing/spelling/context-menu-suggestions.html = TEXT -
trunk/LayoutTests/platform/gtk/Skipped
r59568 r59585 5920 5920 # Skip this, it's pending on one patch in the commit queue 5921 5921 accessibility/aria-controls-with-tabs.html 5922 5923 # Need to dump context menu items on eventSender.contextClick(true). 5924 # https://bugs.webkit.org/show_bug.cgi?id=39102 5925 editing/spelling/context-menu-suggestions.html -
trunk/LayoutTests/platform/qt/Skipped
r59580 r59585 5091 5091 # Discussed in https://bugs.webkit.org/show_bug.cgi?id=38928 5092 5092 fast/loader/recursive-before-unload-crash.html 5093 5094 # Need to dump context menu items on eventSender.contextClick(true). 5095 # https://bugs.webkit.org/show_bug.cgi?id=39103 5096 editing/spelling/context-menu-suggestions.html -
trunk/LayoutTests/platform/win/Skipped
r59541 r59585 877 877 # https://bugs.webkit.org/show_bug.cgi?id=38795 - doesn't print PaintEvent instrumentation output 878 878 inspector/timeline-paint.html 879 880 # Need to dump context menu items on eventSender.contextClick(true). TODO: add bug number 881 # https://bugs.webkit.org/show_bug.cgi?id=39104 882 editing/spelling/context-menu-suggestions.html -
trunk/WebCore/ChangeLog
r59583 r59585 1 2010-05-12 Tony Chang <tony@chromium.org> 2 3 Reviewed by Darin Adler. 4 5 Spellcheck disabling does not disable context menu 6 https://bugs.webkit.org/show_bug.cgi?id=25639 7 8 Test: editing/spelling/context-menu-suggestions.html 9 10 * platform/ContextMenu.cpp: 11 (WebCore::ContextMenu::populate): 12 1 13 2010-05-16 Sam Weinig <sam@webkit.org> 2 14 -
trunk/WebCore/platform/ContextMenu.cpp
r56825 r59585 393 393 SelectionController* selection = frame->selection(); 394 394 bool inPasswordField = selection->isInPasswordField(); 395 bool spellCheckingEnabled = frame->editor()->spellCheckingEnabledInFocusedNode(); 395 396 396 if (!inPasswordField ) {397 if (!inPasswordField && spellCheckingEnabled) { 397 398 // Consider adding spelling-related or grammar-related context menu items (never both, since a single selected range 398 399 // is never considered a misspelling and bad grammar at the same time) -
trunk/WebKitTools/ChangeLog
r59580 r59585 1 2010-05-12 Tony Chang <tony@chromium.org> 2 3 Reviewed by Darin Adler. 4 5 Spellcheck disabling does not disable context menu 6 https://bugs.webkit.org/show_bug.cgi?id=25639 7 8 * DumpRenderTree/mac/EventSendingController.mm: 9 (+[EventSendingController isSelectorExcludedFromWebScript:]): 10 (+[EventSendingController webScriptNameForSelector:]): 11 (-[EventSendingController contextClick:]): add a bool parameter that 12 when true, dumps the context menu items to stdout. 13 1 14 2010-05-16 Robert Hogan <robert@webkit.org> 2 15 -
trunk/WebKitTools/DumpRenderTree/mac/EventSendingController.mm
r56808 r59585 123 123 if (aSelector == @selector(beginDragWithFiles:) 124 124 || aSelector == @selector(clearKillRing) 125 || aSelector == @selector(contextClick )125 || aSelector == @selector(contextClick:) 126 126 || aSelector == @selector(enableDOMUIEventLogging:) 127 127 || aSelector == @selector(fireKeyboardEventsToElement:) … … 153 153 if (aSelector == @selector(beginDragWithFiles:)) 154 154 return @"beginDragWithFiles"; 155 if (aSelector == @selector(contextClick:)) 156 return @"contextClick"; 155 157 if (aSelector == @selector(enableDOMUIEventLogging:)) 156 158 return @"enableDOMUIEventLogging"; … … 493 495 } 494 496 495 - (void)contextClick 497 - (void)contextClick:(BOOL)shouldPrintMenuItems 496 498 { 497 499 [[[mainFrame frameView] documentView] layout]; … … 509 511 510 512 NSView *subView = [[mainFrame webView] hitTest:[event locationInWindow]]; 511 if (subView) 512 [subView menuForEvent:event]; 513 if (subView) { 514 NSMenu* menu = [subView menuForEvent:event]; 515 if (shouldPrintMenuItems) { 516 printf("ContextMenuItems: "); 517 for (int i = 0; i < [menu numberOfItems]; ++i) { 518 if (i > 0) 519 printf(", "); 520 NSMenuItem* menuItem = [menu itemAtIndex:i]; 521 fputs([menuItem isSeparatorItem] ? "<separator>" : [[menuItem title] UTF8String], stdout); 522 } 523 printf("\n"); 524 } 525 } 513 526 } 514 527
Note: See TracChangeset
for help on using the changeset viewer.