Changeset 59606 in webkit

Timestamp:

May 17, 2010 6:49:55 AM (14 years ago)

Author:

kenneth@webkit.org

Message:

REGRESSION(59563): [Qt] JSValue QtClass::fallbackObject can be optimized

Reviewed by Laszlo Gombos.

Patch declared a variable index, which shadowed an earlier declared
variable.

• bridge/qt/qt_class.cpp:

(JSC::Bindings::QtClass::fallbackObject):

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• bridge/qt/qt_class.cpp (modified) (1 diff)

trunk/WebCore/ChangeLog

@@ +1 @@
+2010-05-17  Kenneth Rohde Christiansen  <kenneth@webkit.org>
+
+        Reviewed by Laszlo Gombos.
+
+        REGRESSION(59563): [Qt] JSValue QtClass::fallbackObject can be optimized
+
+        Patch declared a variable index, which shadowed an earlier declared
+        variable.
+
+        * bridge/qt/qt_class.cpp:
+        (JSC::Bindings::QtClass::fallbackObject):
+
 2010-05-14  Andrei Popescu  <andreip@google.com>
 

trunk/WebCore/bridge/qt/qt_class.cpp

@@ -101 +101 @@
             continue;
 
-        int index = 0;
+        int iter = 0;
         const char* signature = m.signature();
-        while (signature[index] && signature[index] != '(')
-            ++index;
-
-        if (normal == QByteArray::fromRawData(signature, index)) {
+        while (signature[iter] && signature[iter] != '(')
+            ++iter;
+
+        if (normal == QByteArray::fromRawData(signature, iter)) {
             QtRuntimeMetaMethod* val = new (exec) QtRuntimeMetaMethod(exec, identifier, static_cast<QtInstance*>(inst), index, normal, false);
             qtinst->m_methods.insert(name, val);