Changeset 59646 in webkit

Timestamp:

May 17, 2010 9:04:50 PM (14 years ago)

Author:

tkent@chromium.org

Message:

Chromium Windows build system does not rebuild correctly when
enabling/disabling a feature
​https://bugs.webkit.org/show_bug.cgi?id=38926

Reviewed by David Levin.

Add a workaround of this issue.

• Scripts/update-webkit: Chromium-Windows only: If WebKit/chromium/features.gyp has been updated, remove WebKit/chromium/Debug and WebKit/chromium/Release.

Location:

trunk/WebKitTools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/update-webkit (modified) (3 diffs)

trunk/WebKitTools/ChangeLog

@@ +1 @@
+2010-05-17  Kent Tamura  <tkent@chromium.org>
+
+        Reviewed by David Levin.
+
+        Chromium Windows build system does not rebuild correctly when
+        enabling/disabling a feature
+        https://bugs.webkit.org/show_bug.cgi?id=38926
+
+        Add a workaround of this issue.
+
+        * Scripts/update-webkit:
+          Chromium-Windows only: If WebKit/chromium/features.gyp has been
+          updated, remove WebKit/chromium/Debug and WebKit/chromium/Release.
+
 2010-05-17  Sheriff Bot  <webkit.review.bot@gmail.com>
 

trunk/WebKitTools/Scripts/update-webkit

@@ -34 +34 @@
 use lib $FindBin::Bin;
 use File::Basename;
+use File::Path;
 use File::Spec;
 use Getopt::Long;
@@ -68 +69 @@
 }
 
+my $startTime = time();
+
 my @svnOptions = ();
 push @svnOptions, '-q' if $quiet;
@@ -84 +87 @@
     runGitUpdate() if $isGit;
 } elsif (isChromium()) {
+    # Workaround for https://bugs.webkit.org/show_bug.cgi?id=38926
+    # We should remove the following "if" block when we find a right fix.
+    if ((isCygwin() || isWindows()) && (stat("WebKit/chromium/features.gypi"))[9] >= $startTime) {
+        print "features.gypi has been updated. Cleaning the build directories.\n";
+        rmtree(["WebKit/chromium/Debug", "WebKit/chromium/Release"]);
+    }
+
     system("perl", "WebKitTools/Scripts/update-webkit-chromium") == 0 or die $!;
 } elsif (isAppleWinWebKit()) {