Changeset 60040 in webkit

Timestamp:

May 23, 2010 4:59:16 AM (14 years ago)

Author:

eric@webkit.org

Message:

2010-05-23 Noam Rosenthal <​noam.rosenthal@nokia.com>

Reviewed by Kenneth Rohde Christiansen.

[Qt] Using Accelerated Composing the rocket back animation on ​http://www.the-art-of-web.com/css/css-animation/ works differently as when not using AC.
​https://bugs.webkit.org/show_bug.cgi?id=39513

The value of GraphicsLayer->transform() needs to be changed during the animation, regardless of m_fillsForward.
m_fillsForward should only apply at the end of the animation. Based on previous patch by Kenneth Christiansen.

• platform/graphics/qt/GraphicsLayerQt.cpp: (WebCore::TransformAnimationQt::applyFrame): (WebCore::OpacityAnimationQt::applyFrame):

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/graphics/qt/GraphicsLayerQt.cpp (modified) (2 diffs)

trunk/WebCore/ChangeLog

@@ +1 @@
+2010-05-23  Noam Rosenthal  <noam.rosenthal@nokia.com>
+
+        Reviewed by Kenneth Rohde Christiansen.
+
+        [Qt] Using Accelerated Composing the rocket back animation on http://www.the-art-of-web.com/css/css-animation/ works differently as when not using AC.
+        https://bugs.webkit.org/show_bug.cgi?id=39513
+
+        The value of GraphicsLayer->transform() needs to be changed during the animation, regardless of m_fillsForward.
+        m_fillsForward should only apply at the end of the animation. Based on previous patch by Kenneth Christiansen.
+
+        * platform/graphics/qt/GraphicsLayerQt.cpp:
+        (WebCore::TransformAnimationQt::applyFrame):
+        (WebCore::OpacityAnimationQt::applyFrame):
+
 2010-05-23  Kenneth Rohde Christiansen  <kenneth@webkit.org>
 

trunk/WebCore/platform/graphics/qt/GraphicsLayerQt.cpp

@@ -1321 +1321 @@
         }
 
+        m_layer.data()->m_layer->setTransform(transformMatrix);
+        // We force the actual opacity change, otherwise it would be ignored because of the animation.
         m_layer.data()->setBaseTransform(transformMatrix);
-        if (m_fillsForwards)
-            m_layer.data()->m_layer->setTransform(m_layer.data()->m_baseTransform);
     }
 
@@ -1371 +1371 @@
             m_layer.data()->scene()->update();
 
+        m_layer.data()->m_layer->setOpacity(opacity);
+        // We force the actual opacity change, otherwise it would be ignored because of the animation.
         m_layer.data()->setOpacity(opacity);
-        if (m_fillsForwards)
-            m_layer.data()->m_layer->setOpacity(opacity);
     }