Changeset 60502 in webkit


Ignore:
Timestamp:
Jun 1, 2010 1:15:02 PM (14 years ago)
Author:
jer.noble@apple.com
Message:

QuickTime 7.6.4 + Safari Nightly = Crash
​https://bugs.webkit.org/show_bug.cgi?id=40019
rdar://problem/8035443

Reviewed by Sam Weinig.

Check the return value of QTCFPropertyListCreateXMLData before calling CFDataGetLength().

  • platform/graphics/win/QTCFDictionary.cpp:

(QTCFDictionaryCreateCopyWithDataCallback):

Location:
trunk/WebCore
Files:
2 edited

Legend:

Unmodified
Added
Removed

  • trunk/WebCore/ChangeLog

    r60501 r60502  
     12010-06-01  Jer Noble  <jer.noble@apple.com>
     2
     3        Reviewed by Sam Weinig.
     4
     5        QuickTime 7.6.4 + Safari Nightly = Crash
     6        https://bugs.webkit.org/show_bug.cgi?id=40019
     7        rdar://problem/8035443
     8       
     9        Check the return value of QTCFPropertyListCreateXMLData before calling CFDataGetLength().
     10
     11        * platform/graphics/win/QTCFDictionary.cpp:
     12        (QTCFDictionaryCreateCopyWithDataCallback):
     13
    1142010-06-01  Rob Buis  <rwlbuis@gmail.com>
    215

  • trunk/WebCore/platform/graphics/win/QTCFDictionary.cpp

    r59001 r60502  
    5353
    5454    CFDataRef data = QTCFPropertyListCreateXMLData(kCFAllocatorDefault, dictionary);
     55    if (!data)
     56        return 0;
    5557    CFDictionaryRef outputDictionary = callback(allocator, CFDataGetBytePtr(data), CFDataGetLength(data));
    56     if (data)
    57         CFRelease(data);
     58    CFRelease(data);
    5859
    5960    return outputDictionary;
Note: See TracChangeset for help on using the changeset viewer.