Changeset 60522 in webkit


Ignore:
Timestamp:
Jun 1, 2010 5:30:16 PM (14 years ago)
Author:
ap@apple.com
Message:

Fixes Gtk buildbot. Suggested by Gavin Barraclough.

​https://bugs.webkit.org/show_bug.cgi?id=40012
Callable objects created via JavaScriptCore API cannot be used as Geolocation callbacks

Disable subtests that check Math.abs - JS host objects are still InternalFunctions in
interpreter, so they behave differently from JIT. The bug tracks deciding what's the best
solution here.

  • fast/dom/Geolocation/argument-types-expected.txt:
  • fast/dom/Geolocation/script-tests/argument-types.js:
Location:
trunk/LayoutTests
Files:
3 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r60516 r60522  
     12010-06-01  Alexey Proskuryakov  <ap@apple.com>
     2
     3        Fixes Gtk buildbot. Suggested by Gavin Barraclough.
     4
     5        https://bugs.webkit.org/show_bug.cgi?id=40012
     6        Callable objects created via JavaScriptCore API cannot be used as Geolocation callbacks
     7
     8        Disable subtests that check Math.abs - JS host objects are still InternalFunctions in
     9        interpreter, so they behave differently from JIT. The bug tracks deciding what's the best
     10        solution here.
     11
     12        * fast/dom/Geolocation/argument-types-expected.txt:
     13        * fast/dom/Geolocation/script-tests/argument-types.js:
     14
    1152010-06-01  James Robinson  <jamesr@chromium.org>
    216

  • trunk/LayoutTests/fast/dom/Geolocation/argument-types-expected.txt

    r48503 r60522  
    1010PASS navigator.geolocation.getCurrentPosition(objectThrowingException) threw exception Error: TYPE_MISMATCH_ERR: DOM Exception 17.
    1111PASS navigator.geolocation.getCurrentPosition(emptyFunction) did not throw exception.
    12 PASS navigator.geolocation.getCurrentPosition(Math.abs) did not throw exception.
    1312PASS navigator.geolocation.getCurrentPosition(true) threw exception Error: TYPE_MISMATCH_ERR: DOM Exception 17.
    1413PASS navigator.geolocation.getCurrentPosition(42) threw exception Error: TYPE_MISMATCH_ERR: DOM Exception 17.
    … …  
    2120PASS navigator.geolocation.getCurrentPosition(emptyFunction, objectThrowingException) threw exception Error: TYPE_MISMATCH_ERR: DOM Exception 17.
    2221PASS navigator.geolocation.getCurrentPosition(emptyFunction, emptyFunction) did not throw exception.
    23 PASS navigator.geolocation.getCurrentPosition(emptyFunction, Math.abs) did not throw exception.
    2422PASS navigator.geolocation.getCurrentPosition(emptyFunction, true) threw exception Error: TYPE_MISMATCH_ERR: DOM Exception 17.
    2523PASS navigator.geolocation.getCurrentPosition(emptyFunction, 42) threw exception Error: TYPE_MISMATCH_ERR: DOM Exception 17.

  • trunk/LayoutTests/fast/dom/Geolocation/script-tests/argument-types.js

    r59926 r60522  
    4141test('navigator.geolocation.getCurrentPosition(objectThrowingException)', true);
    4242test('navigator.geolocation.getCurrentPosition(emptyFunction)', false);
    43 test('navigator.geolocation.getCurrentPosition(Math.abs)', false);
     43//test('navigator.geolocation.getCurrentPosition(Math.abs)', false);
    4444test('navigator.geolocation.getCurrentPosition(true)', true);
    4545test('navigator.geolocation.getCurrentPosition(42)', true);
    … …  
    5353test('navigator.geolocation.getCurrentPosition(emptyFunction, objectThrowingException)', true);
    5454test('navigator.geolocation.getCurrentPosition(emptyFunction, emptyFunction)', false);
    55 test('navigator.geolocation.getCurrentPosition(emptyFunction, Math.abs)', false);
     55//test('navigator.geolocation.getCurrentPosition(emptyFunction, Math.abs)', false);
    5656test('navigator.geolocation.getCurrentPosition(emptyFunction, true)', true);
    5757test('navigator.geolocation.getCurrentPosition(emptyFunction, 42)', true);
Note: See TracChangeset for help on using the changeset viewer.