Changeset 60664 in webkit

Timestamp:

Jun 4, 2010 1:32:03 AM (14 years ago)

Author:

eric@webkit.org

Message:

2010-06-04 Qi Zhang <​qi.2.zhang@nokia.com>

Reviewed by Laszlo Gombos.

[Qt] Failed at ​http://philip.html5.org/tests/canvas/suite/tests/2d.path.arcTo.ensuresubpath.1.html
​https://bugs.webkit.org/show_bug.cgi?id=38645

Remove 2d.path.arcTo.ensuresubpath.1.html from Skipped.

• platform/qt/Skipped:

2010-06-04 Qi Zhang <​qi.2.zhang@nokia.com>

Reviewed by Laszlo Gombos.

[Qt] Failed at ​http://philip.html5.org/tests/canvas/suite/tests/2d.path.arcTo.ensuresubpath.1.html
​https://bugs.webkit.org/show_bug.cgi?id=38645

Path arcto function need to ensure there is subpath before it.

• platform/graphics/qt/PathQt.cpp: (WebCore::Path::addArcTo):

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/platform/qt/Skipped (modified) (1 diff)
• WebCore/ChangeLog (modified) (1 diff)
• WebCore/platform/graphics/qt/PathQt.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2010-06-04  Qi Zhang  <qi.2.zhang@nokia.com>
+
+        Reviewed by Laszlo Gombos.
+
+        [Qt] Failed at http://philip.html5.org/tests/canvas/suite/tests/2d.path.arcTo.ensuresubpath.1.html
+        https://bugs.webkit.org/show_bug.cgi?id=38645
+
+        Remove 2d.path.arcTo.ensuresubpath.1.html from Skipped.
+
+        * platform/qt/Skipped:
+
 2010-06-04  Qi Zhang  <qi.2.zhang@nokia.com>
 

trunk/LayoutTests/platform/qt/Skipped

@@ -5140 +5140 @@
 canvas/philip/tests/2d.path.arcTo.collinear.2.html
 canvas/philip/tests/2d.path.arcTo.collinear.3.html
-canvas/philip/tests/2d.path.arcTo.ensuresubpath.1.html
 canvas/philip/tests/2d.path.arcTo.scale.html
 canvas/philip/tests/2d.path.arcTo.transformation.html

trunk/WebCore/ChangeLog

@@ +1 @@
+2010-06-04  Qi Zhang  <qi.2.zhang@nokia.com>
+
+        Reviewed by Laszlo Gombos.
+
+        [Qt] Failed at http://philip.html5.org/tests/canvas/suite/tests/2d.path.arcTo.ensuresubpath.1.html
+        https://bugs.webkit.org/show_bug.cgi?id=38645
+
+        Path arcto function need to ensure there is subpath before it.
+
+        * platform/graphics/qt/PathQt.cpp:
+        (WebCore::Path::addArcTo):
+
 2010-06-04  Qi Zhang  <qi.2.zhang@nokia.com>
 

trunk/WebCore/platform/graphics/qt/PathQt.cpp

@@ -187 +187 @@
 void Path::addArcTo(const FloatPoint& p1, const FloatPoint& p2, float radius)
 {
+    // Make sure there is a subpath for p1, the behavior depend on the last element of the subpath.
+    // When the user agent is to ensure there is a subpath  for a coordinate (x, y), the user agent must 
+    // check to see if the context has any subpaths, and if it does not, then the user agent must create 
+    // a new subpath with the point (x, y) as its first (and only) point, as if the moveTo()  method had been called.
+    if (!m_path.elementCount()) {
+        m_path.moveTo(p1);
+        return;
+    }
+
     FloatPoint p0(m_path.currentPosition());