Changeset 60726 in webkit

Timestamp:

Jun 4, 2010 5:43:31 PM (14 years ago)

Author:

eric@webkit.org

Message:

2010-06-04 Andreas Kling <​andreas.kling@nokia.com>

Reviewed by Tor Arne Vestbø.

[Qt] Canvas arc() with zero radius should draw a line to the start point
​https://bugs.webkit.org/show_bug.cgi?id=40164

Unskip canvas/philip/tests/2d.path.arc.zeroradius.html

Spec link:
​http://www.whatwg.org/specs/web-apps/current-work/#dom-context-2d-arc

• platform/qt/Skipped:

2010-06-04 Andreas Kling <​andreas.kling@nokia.com>

Reviewed by Tor Arne Vestbø.

[Qt] Canvas arc() with zero radius should draw a line to the start point
​https://bugs.webkit.org/show_bug.cgi?id=40164

Spec link:
​http://www.whatwg.org/specs/web-apps/current-work/#dom-context-2d-arc

• platform/graphics/qt/PathQt.cpp: (WebCore::Path::addArc):

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/platform/qt/Skipped (modified) (1 diff)
• WebCore/ChangeLog (modified) (1 diff)
• WebCore/platform/graphics/qt/PathQt.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2010-06-04  Andreas Kling  <andreas.kling@nokia.com>
+
+        Reviewed by Tor Arne Vestbø.
+
+        [Qt] Canvas arc() with zero radius should draw a line to the start point
+        https://bugs.webkit.org/show_bug.cgi?id=40164
+
+        Unskip canvas/philip/tests/2d.path.arc.zeroradius.html
+
+        Spec link:
+        http://www.whatwg.org/specs/web-apps/current-work/#dom-context-2d-arc
+
+        * platform/qt/Skipped:
+
 2010-06-04  Martin Robinson  <mrobinson@igalia.com>
 

trunk/LayoutTests/platform/qt/Skipped

@@ -5137 +5137 @@
 canvas/philip/tests/2d.missingargs.html
 canvas/philip/tests/2d.path.arc.twopie.3.html
-canvas/philip/tests/2d.path.arc.zeroradius.html
 canvas/philip/tests/2d.path.arcTo.collinear.2.html
 canvas/philip/tests/2d.path.arcTo.collinear.3.html

trunk/WebCore/ChangeLog

@@ +1 @@
+2010-06-04  Andreas Kling  <andreas.kling@nokia.com>
+
+        Reviewed by Tor Arne Vestbø.
+
+        [Qt] Canvas arc() with zero radius should draw a line to the start point
+        https://bugs.webkit.org/show_bug.cgi?id=40164
+
+        Spec link:
+        http://www.whatwg.org/specs/web-apps/current-work/#dom-context-2d-arc
+
+        * platform/graphics/qt/PathQt.cpp:
+        (WebCore::Path::addArc):
+
 2010-06-04  Martin Robinson  <mrobinson@igalia.com>
 

trunk/WebCore/platform/graphics/qt/PathQt.cpp

@@ -320 +320 @@
     if (!m_path.elementCount())
         m_path.arcMoveTo(xs, ys, width, height, sa);
+    else if (!radius) {
+        m_path.lineTo(xc, yc);
+        return;
+    }
 
     m_path.arcTo(xs, ys, width, height, sa, span);