Changeset 60943 in webkit


Ignore:
Timestamp:
Jun 10, 2010 1:33:22 AM (14 years ago)
Author:
eric@webkit.org
Message:

2010-06-10 Eric Seidel <​eric@webkit.org>

Reviewed by Adam Barth.

Reduce FrameView.h includes to speed up build times
​https://bugs.webkit.org/show_bug.cgi?id=40408

Cleaned up FrameView.h includes and then propagated the
cascade of includes to the necessary .cpp files.
This should reduce the set of files rebuilt every
time FrameView.h changes, and should also reduce the size
of some .o files.

No functional changes, thus no tests.

  • accessibility/AccessibilityRenderObject.cpp:
  • dom/ContainerNode.cpp:
  • dom/Document.cpp:
  • dom/Element.cpp:
  • dom/EventTarget.h:
  • dom/Node.cpp:
  • editing/EditorCommand.cpp:
  • editing/SelectionController.cpp:
  • html/HTML5Tokenizer.cpp: (WebCore::HTML5Tokenizer::script):
    • No need for this to be inline. Being inline required Frame.h in the header, which causes huge include cascade.
  • html/HTML5Tokenizer.h:
  • page/DragController.cpp:
  • page/EventHandler.cpp:
  • page/Frame.h:
  • page/FrameView.h:
  • page/PrintContext.cpp:
  • page/SpatialNavigation.cpp:
  • rendering/RenderBlock.cpp:
  • rendering/RenderBlockLineLayout.cpp:
  • rendering/RenderImage.cpp:
  • rendering/RenderInline.cpp:
  • rendering/RenderObject.h:
  • rendering/RenderTextControlSingleLine.cpp:
  • rendering/RenderWidget.cpp:
  • rendering/SVGRenderSupport.cpp:
Location:
trunk/WebCore
Files:
25 edited

Legend:

Unmodified
Added
Removed

  • trunk/WebCore/ChangeLog

    r60941 r60943  
     12010-06-10  Eric Seidel  <eric@webkit.org>
     2
     3        Reviewed by Adam Barth.
     4
     5        Reduce FrameView.h includes to speed up build times
     6        https://bugs.webkit.org/show_bug.cgi?id=40408
     7
     8        Cleaned up FrameView.h includes and then propagated the
     9        cascade of includes to the necessary .cpp files.
     10        This should reduce the set of files rebuilt every
     11        time FrameView.h changes, and should also reduce the size
     12        of some .o files.
     13
     14        No functional changes, thus no tests.
     15
     16        * accessibility/AccessibilityRenderObject.cpp:
     17        * dom/ContainerNode.cpp:
     18        * dom/Document.cpp:
     19        * dom/Element.cpp:
     20        * dom/EventTarget.h:
     21        * dom/Node.cpp:
     22        * editing/EditorCommand.cpp:
     23        * editing/SelectionController.cpp:
     24        * html/HTML5Tokenizer.cpp:
     25        (WebCore::HTML5Tokenizer::script):
     26         - No need for this to be inline.  Being inline required
     27           Frame.h in the header, which causes huge include cascade.
     28        * html/HTML5Tokenizer.h:
     29        * page/DragController.cpp:
     30        * page/EventHandler.cpp:
     31        * page/Frame.h:
     32        * page/FrameView.h:
     33        * page/PrintContext.cpp:
     34        * page/SpatialNavigation.cpp:
     35        * rendering/RenderBlock.cpp:
     36        * rendering/RenderBlockLineLayout.cpp:
     37        * rendering/RenderImage.cpp:
     38        * rendering/RenderInline.cpp:
     39        * rendering/RenderObject.h:
     40        * rendering/RenderTextControlSingleLine.cpp:
     41        * rendering/RenderWidget.cpp:
     42        * rendering/SVGRenderSupport.cpp:
     43
    1442010-06-10  Adam Barth  <abarth@webkit.org>
    245

  • trunk/WebCore/accessibility/AccessibilityRenderObject.cpp

    r60753 r60943  
    6161#include "RenderImage.h"
    6262#include "RenderInline.h"
     63#include "RenderLayer.h"
    6364#include "RenderListBox.h"
    6465#include "RenderListMarker.h"

  • trunk/WebCore/dom/ContainerNode.cpp

    r59098 r60943  
    3737#include "MutationEvent.h"
    3838#include "Page.h"
     39#include "RenderBox.h"
    3940#include "RenderTheme.h"
    4041#include "RootInlineBox.h"

  • trunk/WebCore/dom/Document.cpp

    r60624 r60943  
    108108#include "RegisteredEventListener.h"
    109109#include "RenderArena.h"
     110#include "RenderLayer.h"
    110111#include "RenderTextControl.h"
    111112#include "RenderView.h"

  • trunk/WebCore/dom/Element.cpp

    r60181 r60943  
    4848#include "NodeRenderStyle.h"
    4949#include "Page.h"
     50#include "RenderLayer.h"
    5051#include "RenderView.h"
    5152#include "RenderWidget.h"

  • trunk/WebCore/dom/EventTarget.h

    r59068 r60943  
    167167    };
    168168
     169    // FIXME: These macros should be split into separate DEFINE and DECLARE
     170    // macros to avoid causing so many header includes.
    169171    #define DEFINE_ATTRIBUTE_EVENT_LISTENER(attribute) \
    170172        EventListener* on##attribute() { return getAttributeEventListener(eventNames().attribute##Event); } \

  • trunk/WebCore/dom/Node.cpp

    r60434 r60943  
    6767#include "ProgressEvent.h"
    6868#include "RegisteredEventListener.h"
    69 #include "RenderObject.h"
     69#include "RenderBox.h"
    7070#include "ScriptController.h"
    7171#include "SelectorNodeList.h"

  • trunk/WebCore/editing/EditorCommand.cpp

    r60841 r60943  
    5050#include "KillRing.h"
    5151#include "Page.h"
     52#include "RenderBox.h"
    5253#include "ReplaceSelectionCommand.h"
    5354#include "Scrollbar.h"

  • trunk/WebCore/editing/SelectionController.cpp

    r60841 r60943  
    4545#include "Page.h"
    4646#include "Range.h"
     47#include "RenderLayer.h"
    4748#include "RenderTheme.h"
    4849#include "RenderView.h"

  • trunk/WebCore/html/HTML5Tokenizer.cpp

    r60940 r60943  
    271271}
    272272
    273 }
     273ScriptController* HTML5Tokenizer::script() const
     274{
     275    return m_document->frame() ? m_document->frame()->script() : 0;
     276}
     277
     278}

  • trunk/WebCore/html/HTML5Tokenizer.h

    r60940 r60943  
    2828
    2929#include "CachedResourceClient.h"
    30 #include "Frame.h"
    3130#include "HTML5ScriptRunnerHost.h"
    3231#include "HTML5Token.h"
    33 #include "HTMLDocument.h"
    3432#include "SegmentedString.h"
    3533#include "Tokenizer.h"
    … …  
    3836namespace WebCore {
    3937
     38class HTMLDocument;
    4039class HTML5Lexer;
    4140class HTML5ScriptRunner;
    … …  
    170169    bool inWrite() const { return m_writeNestingLevel > 0; }
    171170
    172     ScriptController* script() const { return m_document->frame() ? m_document->frame()->script() : 0; }
     171    ScriptController* script() const;
    173172
    174173    InputStream m_input;

  • trunk/WebCore/page/DragController.cpp

    r60418 r60943  
    5757#include "RenderFileUploadControl.h"
    5858#include "RenderImage.h"
     59#include "RenderLayer.h"
    5960#include "RenderView.h"
    6061#include "ReplaceSelectionCommand.h"

  • trunk/WebCore/page/EventHandler.cpp

    r60849 r60943  
    6060#include "PluginDocument.h"
    6161#include "RenderFrameSet.h"
     62#include "RenderLayer.h"
    6263#include "RenderTextControlSingleLine.h"
    6364#include "RenderView.h"

  • trunk/WebCore/page/Frame.h

    r60841 r60943  
    3030
    3131#include "AnimationController.h"
    32 #include "CSSMutableStyleDeclaration.h"
    3332#include "DragImage.h"
    3433#include "Editor.h"

  • trunk/WebCore/page/FrameView.h

    r60591 r60943  
    2626#define FrameView_h
    2727
    28 #include "Frame.h"
     28#include "Frame.h" // Only used by FrameView::inspectorTimelineAgent()
    2929#include "IntSize.h"
    30 #include "Page.h"
    31 #include "RenderLayer.h"
     30#include "Page.h" // Only used by FrameView::inspectorTimelineAgent()
     31#include "RenderObject.h" // For PaintBehavior
    3232#include "ScrollView.h"
    3333#include <wtf/Forward.h>
    … …  
    3838class Color;
    3939class Event;
    40 class Frame;
    4140class FrameViewPrivate;
    4241class InspectorTimelineAgent;
    … …  
    4746class RenderObject;
    4847class RenderEmbeddedObject;
     48class RenderScrollbarPart;
    4949class ScheduledEvent;
    5050class String;

  • trunk/WebCore/page/PrintContext.cpp

    r58566 r60943  
    2525#include "Frame.h"
    2626#include "FrameView.h"
     27#include "RenderLayer.h"
    2728#include "RenderView.h"
    2829

  • trunk/WebCore/page/SpatialNavigation.cpp

    r59045 r60943  
    3636#include "IntRect.h"
    3737#include "Node.h"
     38#include "RenderLayer.h"
    3839#include "Page.h"
    3940

  • trunk/WebCore/rendering/RenderBlock.cpp

    r60841 r60943  
    3737#include "RenderImage.h"
    3838#include "RenderInline.h"
     39#include "RenderLayer.h"
    3940#include "RenderMarquee.h"
    4041#include "RenderReplica.h"

  • trunk/WebCore/rendering/RenderBlockLineLayout.cpp

    r59592 r60943  
    3030#include "RenderArena.h"
    3131#include "RenderInline.h"
     32#include "RenderLayer.h"
    3233#include "RenderListMarker.h"
    3334#include "RenderView.h"

  • trunk/WebCore/rendering/RenderImage.cpp

    r60753 r60943  
    3737#include "HitTestResult.h"
    3838#include "Page.h"
     39#include "RenderLayer.h"
    3940#include "RenderTheme.h"
    4041#include "RenderView.h"

  • trunk/WebCore/rendering/RenderInline.cpp

    r60753 r60943  
    3131#include "RenderArena.h"
    3232#include "RenderBlock.h"
     33#include "RenderLayer.h"
    3334#include "RenderView.h"
    3435#include "TransformState.h"

  • trunk/WebCore/rendering/RenderObject.h

    r60753 r60943  
    6767 */
    6868
     69// FIXME: These enums should move to their own header since they're used by other headers.
    6970enum PaintPhase {
    7071    PaintPhaseBlockBackground,

  • trunk/WebCore/rendering/RenderTextControlSingleLine.cpp

    r60753 r60943  
    2828#include "Frame.h"
    2929#include "FrameView.h"
    30 #include "HitTestResult.h"
    3130#include "HTMLInputElement.h"
    3231#include "HTMLNames.h"
     32#include "HitTestResult.h"
    3333#include "InputElement.h"
    3434#include "LocalizedStrings.h"
    3535#include "MouseEvent.h"
    3636#include "PlatformKeyboardEvent.h"
     37#include "RenderLayer.h"
    3738#include "RenderScrollbar.h"
    3839#include "RenderTheme.h"

  • trunk/WebCore/rendering/RenderWidget.cpp

    r59136 r60943  
    2828#include "GraphicsContext.h"
    2929#include "HitTestResult.h"
     30#include "RenderLayer.h"
    3031#include "RenderView.h"
    3132#include "RenderWidgetProtector.h"

  • trunk/WebCore/rendering/SVGRenderSupport.cpp

    r60761 r60943  
    3333#include "ImageBuffer.h"
    3434#include "NodeRenderStyle.h"
     35#include "RenderLayer.h"
    3536#include "RenderObject.h"
    3637#include "RenderSVGContainer.h"
Note: See TracChangeset for help on using the changeset viewer.