Changeset 60993 in webkit

Timestamp:

Jun 10, 2010 11:56:31 PM (14 years ago)

Author:

abarth@webkit.org

Message:

2010-06-10 Adam Barth <​abarth@webkit.org>

Reviewed by Daniel Bates.

Make SheriffBot more chatty
​https://bugs.webkit.org/show_bug.cgi?id=40463

People seem to like to talk to SheriffBot, so let's make him chat back.

• Scripts/webkitpy/thirdparty/init.py:
• Scripts/webkitpy/tool/bot/irc_command.py:
• Scripts/webkitpy/tool/bot/irc_command_unittest.py: Added.
• Scripts/webkitpy/tool/bot/sheriffircbot.py:
• Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:

Location:

trunk/WebKitTools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/webkitpy/thirdparty/__init__.py (modified) (1 diff)
• Scripts/webkitpy/tool/bot/irc_command.py (modified) (2 diffs)
• Scripts/webkitpy/tool/bot/irc_command_unittest.py (added)
• Scripts/webkitpy/tool/bot/sheriffircbot.py (modified) (2 diffs)
• Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py (modified) (1 diff)

trunk/WebKitTools/ChangeLog

@@ +1 @@
+2010-06-10  Adam Barth  <abarth@webkit.org>
+
+        Reviewed by Daniel Bates.
+
+        Make SheriffBot more chatty
+        https://bugs.webkit.org/show_bug.cgi?id=40463
+
+        People seem to like to talk to SheriffBot, so let's make him chat back.
+
+        * Scripts/webkitpy/thirdparty/__init__.py:
+        * Scripts/webkitpy/tool/bot/irc_command.py:
+        * Scripts/webkitpy/tool/bot/irc_command_unittest.py: Added.
+        * Scripts/webkitpy/tool/bot/sheriffircbot.py:
+        * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
+
 2010-06-10  Brian Weinstein  <bweinstein@apple.com>
 

trunk/WebKitTools/Scripts/webkitpy/thirdparty/__init__.py

@@ -72 +72 @@
 installer.install(url="http://pypi.python.org/packages/source/p/pep8/pep8-0.5.0.tar.gz#md5=512a818af9979290cd619cce8e9c2e2b",
                   url_subpath="pep8-0.5.0/pep8.py")
-
+installer.install(url="http://www.adambarth.com/webkit/eliza",
+                  target_name="eliza.py")
 
 rietveld_dir = os.path.join(autoinstalled_dir, "rietveld")

trunk/WebKitTools/Scripts/webkitpy/tool/bot/irc_command.py

@@ -76 +76 @@
 
 
+class Help(IRCCommand):
+    def execute(self, nick, args, tool, sheriff):
+        return "%s: Available commands: %s" % (nick, ", ".join(commands.keys()))
+
+
 class Hi(IRCCommand):
     def execute(self, nick, args, tool, sheriff):
@@ -81 +86 @@
         quips.append('"Only you can prevent forest fires." -- Smokey the Bear')
         return random.choice(quips)
+
+
+class Eliza(IRCCommand):
+    therapist = None
+
+    def __init__(self):
+        if not self.therapist:
+            import webkitpy.thirdparty.autoinstalled.eliza as eliza
+            Eliza.therapist = eliza.eliza()
+
+    def execute(self, nick, args, tool, sheriff):
+        return "%s: %s" % (nick, self.therapist.respond(" ".join(args)))
+
+
+# FIXME: Lame.  We should have an auto-registering CommandCenter.
+commands = {
+    "last-green-revision": LastGreenRevision,
+    "restart": Restart,
+    "rollout": Rollout,
+    "help": Help,
+    "hi": Hi,
+}

trunk/WebKitTools/Scripts/webkitpy/tool/bot/sheriffircbot.py

@@ -53 +53 @@
 
 class SheriffIRCBot(object):
-    # FIXME: Lame.  We should have an auto-registering CommandCenter.
-    commands = {
-        "last-green-revision": irc_command.LastGreenRevision,
-        "restart": irc_command.Restart,
-        "rollout": irc_command.Rollout,
-        "hi": irc_command.Hi,
-    }
-
     def __init__(self, tool, sheriff):
         self._tool = tool
@@ -76 +68 @@
         if not tokenized_request:
             return
-        command = self.commands.get(tokenized_request[0])
+        command = irc_command.commands.get(tokenized_request[0])
+        args = tokenized_request[1:]
         if not command:
-            self._tool.irc().post("%s: Available commands: %s" % (
-                                  nick, ", ".join(self.commands.keys())))
-            return
-        response = command().execute(nick,
-                                     tokenized_request[1:],
-                                     self._tool,
-                                     self._sheriff)
+            # Give the peoples someone to talk with.
+            command = irc_command.Eliza
+            args = tokenized_request
+        response = command().execute(nick, args, self._tool, self._sheriff)
         if response:
             self._tool.irc().post(response)

trunk/WebKitTools/Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py

@@ -51 +51 @@
         OutputCapture().assert_outputs(self, run, args=["hi"], expected_stderr=expected_stderr)
 
-    def test_bogus(self):
-        expected_stderr = "MOCK: irc.post: mock_nick: Available commands: rollout, hi, restart, last-green-revision\n"
-        OutputCapture().assert_outputs(self, run, args=["bogus"], expected_stderr=expected_stderr)
+    def test_help(self):
+        expected_stderr = "MOCK: irc.post: mock_nick: Available commands: rollout, hi, help, restart, last-green-revision\n"
+        OutputCapture().assert_outputs(self, run, args=["help"], expected_stderr=expected_stderr)
 
     def test_lgr(self):