Changeset 61071 in webkit


Ignore:
Timestamp:
Jun 12, 2010, 6:03:54 PM (15 years ago)
Author:
eric@webkit.org
Message:

2010-06-12 Andreas Kling <​andreas.kling@nokia.com>

Reviewed by Darin Adler.

Window object should have CanvasGradient and CanvasPattern
​https://bugs.webkit.org/show_bug.cgi?id=40394

Unskipped 2 tests that are now working properly.

  • canvas/philip/tests/2d.gradient.object.return-expected.txt:
  • canvas/philip/tests/2d.pattern.basic.type-expected.txt:
  • fast/dom/Window/window-properties-expected.txt:
  • fast/dom/Window/window-property-descriptors-expected.txt:
  • fast/dom/dom-constructors-expected.txt:
  • fast/dom/prototype-inheritance-2-expected.txt:
  • fast/dom/prototype-inheritance-expected.txt:
  • fast/js/global-constructors-expected.txt:
  • platform/gtk/fast/dom/Window/window-properties-expected.txt:
  • platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/gtk/fast/dom/prototype-inheritance-expected.txt:
  • platform/gtk/fast/js/global-constructors-expected.txt:
  • platform/mac/Skipped:
  • platform/qt/Skipped:
  • platform/qt/fast/dom/Window/window-properties-expected.txt:
  • platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:
  • platform/qt/fast/dom/prototype-inheritance-expected.txt:
  • platform/qt/fast/js/global-constructors-expected.txt:

2010-06-12 Andreas Kling <​andreas.kling@nokia.com>

Reviewed by Darin Adler.

Window object should have CanvasGradient and CanvasPattern
​https://bugs.webkit.org/show_bug.cgi?id=40394

This fixes the following tests:

  • canvas/philip/tests/2d.gradient.object.return.html
  • canvas/philip/tests/2d.pattern.basic.type.html
  • html/canvas/CanvasGradient.idl:
  • html/canvas/CanvasPattern.idl:
  • page/DOMWindow.idl:
Location:
trunk
Files:
23 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r61070 r61071  
     12010-06-12  Andreas Kling  <andreas.kling@nokia.com>
     2
     3        Reviewed by Darin Adler.
     4
     5        Window object should have CanvasGradient and CanvasPattern
     6        https://bugs.webkit.org/show_bug.cgi?id=40394
     7
     8        Unskipped 2 tests that are now working properly.
     9
     10        * canvas/philip/tests/2d.gradient.object.return-expected.txt:
     11        * canvas/philip/tests/2d.pattern.basic.type-expected.txt:
     12        * fast/dom/Window/window-properties-expected.txt:
     13        * fast/dom/Window/window-property-descriptors-expected.txt:
     14        * fast/dom/dom-constructors-expected.txt:
     15        * fast/dom/prototype-inheritance-2-expected.txt:
     16        * fast/dom/prototype-inheritance-expected.txt:
     17        * fast/js/global-constructors-expected.txt:
     18        * platform/gtk/fast/dom/Window/window-properties-expected.txt:
     19        * platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt:
     20        * platform/gtk/fast/dom/prototype-inheritance-expected.txt:
     21        * platform/gtk/fast/js/global-constructors-expected.txt:
     22        * platform/mac/Skipped:
     23        * platform/qt/Skipped:
     24        * platform/qt/fast/dom/Window/window-properties-expected.txt:
     25        * platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:
     26        * platform/qt/fast/dom/prototype-inheritance-expected.txt:
     27        * platform/qt/fast/js/global-constructors-expected.txt:
     28
    1292010-06-12  Dan Bernstein  <mitz@apple.com>
    230

  • trunk/LayoutTests/canvas/philip/tests/2d.gradient.object.return-expected.txt

    r60162 r61071  
    44References: 2d.gradient.linear.return 2d.gradient.radial.return
    55Actual output:
    6 Aborted with exception: Result of expression 'window.CanvasGradient' [undefined] is not an object.
     6Passed

  • trunk/LayoutTests/canvas/philip/tests/2d.pattern.basic.type-expected.txt

    r60162 r61071  
    55Passed
    66
    7 

  • trunk/LayoutTests/fast/dom/Window/window-properties-expected.txt

    r60831 r61071  
    386386window.CSSVariablesRule [object CSSVariablesRuleConstructor]
    387387window.CSSVariablesRule.prototype [printed above as window.CSSRule.prototype]
     388window.CanvasGradient [object CanvasGradientConstructor]
     389window.CanvasGradient.prototype [object CanvasGradientPrototype]
     390window.CanvasGradient.prototype.addColorStop [function]
     391window.CanvasPattern [object CanvasPatternConstructor]
     392window.CanvasPattern.prototype [object CanvasPatternPrototype]
    388393window.CanvasRenderingContext2D [object CanvasRenderingContext2DConstructor]
    389394window.CanvasRenderingContext2D.prototype [object CanvasRenderingContext2DPrototype]

  • trunk/LayoutTests/fast/dom/Window/window-property-descriptors-expected.txt

    r60831 r61071  
    2626PASS typeof Object.getOwnPropertyDescriptor(window, 'CSSVariablesDeclaration') is 'object'
    2727PASS typeof Object.getOwnPropertyDescriptor(window, 'CSSVariablesRule') is 'object'
     28PASS typeof Object.getOwnPropertyDescriptor(window, 'CanvasGradient') is 'object'
     29PASS typeof Object.getOwnPropertyDescriptor(window, 'CanvasPattern') is 'object'
    2830PASS typeof Object.getOwnPropertyDescriptor(window, 'CanvasRenderingContext2D') is 'object'
    2931PASS typeof Object.getOwnPropertyDescriptor(window, 'CharacterData') is 'object'

  • trunk/LayoutTests/fast/dom/dom-constructors-expected.txt

    r49998 r61071  
    117117PASS TryAllocate('XPathResult') is 'exception'
    118118FAIL TryAllocate('BarInfo') should be exception. Was no constructor.
    119 FAIL TryAllocate('CanvasGradient') should be exception. Was no constructor.
    120 FAIL TryAllocate('CanvasPattern') should be exception. Was no constructor.
     119PASS TryAllocate('CanvasGradient') is 'exception'
     120PASS TryAllocate('CanvasPattern') is 'exception'
    121121FAIL TryAllocate('Console') should be exception. Was no constructor.
    122122FAIL TryAllocate('DOMSelection') should be exception. Was no constructor.

  • trunk/LayoutTests/fast/dom/prototype-inheritance-2-expected.txt

    r60831 r61071  
    4949PASS CSSValuePrototype from inner.getComputedStyle(inner.document.body).getPropertyCSSValue(background-clip).__proto__.__proto__
    5050FAIL CanvasPattern from inner.document.getElementsByTagName("canvas")[0].getContext("2d").createPattern(inner.document.getElementsByTagName("img")[0], "")
     51FAIL CanvasPatternConstructor from inner.document.getElementsByTagName("canvas")[0].getContext("2d").createPattern(inner.document.getElementsByTagName("img")[0], "").constructor
    5152FAIL CanvasPatternPrototype from inner.document.getElementsByTagName("canvas")[0].getContext("2d").createPattern(inner.document.getElementsByTagName("img")[0], "").__proto__
    5253PASS CanvasRenderingContext2D from inner.document.getElementsByTagName("canvas")[0].getContext("2d")
    … …  
    215216Never found CSSVariablesDeclaration
    216217Never found CSSVariablesRule
     218Never found CanvasGradient
    217219Never found CharacterData
    218220Never found Clipboard

  • trunk/LayoutTests/fast/dom/prototype-inheritance-expected.txt

    r60831 r61071  
    4444PASS inner.CSSVariablesRule.isInner is true
    4545PASS inner.CSSVariablesRule.constructor.isInner is true
     46PASS inner.CanvasGradient.isInner is true
     47PASS inner.CanvasGradient.constructor.isInner is true
     48PASS inner.CanvasPattern.isInner is true
     49PASS inner.CanvasPattern.constructor.isInner is true
    4650PASS inner.CanvasRenderingContext2D.isInner is true
    4751PASS inner.CanvasRenderingContext2D.constructor.isInner is true

  • trunk/LayoutTests/fast/js/global-constructors-expected.txt

    r60831 r61071  
    2424PASS CSSVariablesDeclaration.toString() is '[object CSSVariablesDeclarationConstructor]'
    2525PASS CSSVariablesRule.toString() is '[object CSSVariablesRuleConstructor]'
     26PASS CanvasGradient.toString() is '[object CanvasGradientConstructor]'
     27PASS CanvasPattern.toString() is '[object CanvasPatternConstructor]'
    2628PASS CanvasRenderingContext2D.toString() is '[object CanvasRenderingContext2DConstructor]'
    2729PASS CharacterData.toString() is '[object CharacterDataConstructor]'

  • trunk/LayoutTests/platform/gtk/fast/dom/Window/window-properties-expected.txt

    r60568 r61071  
    357357window.CSSVariablesRule [object CSSVariablesRuleConstructor]
    358358window.CSSVariablesRule.prototype [printed above as window.CSSRule.prototype]
     359window.CanvasGradient [object CanvasGradientConstructor]
     360window.CanvasGradient.prototype [object CanvasGradientPrototype]
     361window.CanvasGradient.prototype.addColorStop [function]
     362window.CanvasPattern [object CanvasPatternConstructor]
     363window.CanvasPattern.prototype [object CanvasPatternPrototype]
    359364window.CanvasRenderingContext2D [object CanvasRenderingContext2DConstructor]
    360365window.CanvasRenderingContext2D.prototype [object CanvasRenderingContext2DPrototype]

  • trunk/LayoutTests/platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt

    r60070 r61071  
    2626PASS typeof Object.getOwnPropertyDescriptor(window, 'CSSVariablesDeclaration') is 'object'
    2727PASS typeof Object.getOwnPropertyDescriptor(window, 'CSSVariablesRule') is 'object'
     28PASS typeof Object.getOwnPropertyDescriptor(window, 'CanvasGradient') is 'object'
     29PASS typeof Object.getOwnPropertyDescriptor(window, 'CanvasPattern') is 'object'
    2830PASS typeof Object.getOwnPropertyDescriptor(window, 'CanvasRenderingContext2D') is 'object'
    2931PASS typeof Object.getOwnPropertyDescriptor(window, 'CharacterData') is 'object'

  • trunk/LayoutTests/platform/gtk/fast/dom/prototype-inheritance-expected.txt

    r60070 r61071  
    4444PASS inner.CSSVariablesRule.isInner is true
    4545PASS inner.CSSVariablesRule.constructor.isInner is true
     46PASS inner.CanvasGradient.isInner is true
     47PASS inner.CanvasGradient.constructor.isInner is true
     48PASS inner.CanvasPattern.isInner is true
     49PASS inner.CanvasPattern.constructor.isInner is true
    4650PASS inner.CanvasRenderingContext2D.isInner is true
    4751PASS inner.CanvasRenderingContext2D.constructor.isInner is true

  • trunk/LayoutTests/platform/gtk/fast/js/global-constructors-expected.txt

    r60070 r61071  
    2424PASS CSSVariablesDeclaration.toString() is '[object CSSVariablesDeclarationConstructor]'
    2525PASS CSSVariablesRule.toString() is '[object CSSVariablesRuleConstructor]'
     26PASS CanvasGradient.toString() is '[object CanvasGradientConstructor]'
     27PASS CanvasPattern.toString() is '[object CanvasPatternConstructor]'
    2628PASS CanvasRenderingContext2D.toString() is '[object CanvasRenderingContext2DConstructor]'
    2729PASS CharacterData.toString() is '[object CharacterDataConstructor]'

  • trunk/LayoutTests/platform/mac/Skipped

    r60998 r61071  
    241241canvas/philip/tests/2d.path.stroke.prune.curve.html
    242242canvas/philip/tests/2d.path.stroke.prune.line.html
    243 canvas/philip/tests/2d.pattern.basic.type.html
    244243canvas/philip/tests/2d.pattern.image.broken.html
    245244canvas/philip/tests/2d.pattern.image.incomplete.html

  • trunk/LayoutTests/platform/qt/Skipped

    r61062 r61071  
    53015301canvas/philip/tests/2d.path.stroke.prune.arc.html
    53025302canvas/philip/tests/2d.path.stroke.scale2.html
    5303 canvas/philip/tests/2d.pattern.basic.type.html
    53045303canvas/philip/tests/2d.pattern.image.broken.html
    53055304canvas/philip/tests/2d.pattern.image.incomplete.html

  • trunk/LayoutTests/platform/qt/fast/dom/Window/window-properties-expected.txt

    r60625 r61071  
    386386window.CSSVariablesRule [object CSSVariablesRuleConstructor]
    387387window.CSSVariablesRule.prototype [printed above as window.CSSRule.prototype]
     388window.CanvasGradient [object CanvasGradientConstructor]
     389window.CanvasGradient.prototype [object CanvasGradientPrototype]
     390window.CanvasGradient.prototype.addColorStop [function]
     391window.CanvasPattern [object CanvasPatternConstructor]
     392window.CanvasPattern.prototype [object CanvasPatternPrototype]
    388393window.CanvasRenderingContext2D [object CanvasRenderingContext2DConstructor]
    389394window.CanvasRenderingContext2D.prototype [object CanvasRenderingContext2DPrototype]

  • trunk/LayoutTests/platform/qt/fast/dom/Window/window-property-descriptors-expected.txt

    r60625 r61071  
    2626PASS typeof Object.getOwnPropertyDescriptor(window, 'CSSVariablesDeclaration') is 'object'
    2727PASS typeof Object.getOwnPropertyDescriptor(window, 'CSSVariablesRule') is 'object'
     28PASS typeof Object.getOwnPropertyDescriptor(window, 'CanvasGradient') is 'object'
     29PASS typeof Object.getOwnPropertyDescriptor(window, 'CanvasPattern') is 'object'
    2830PASS typeof Object.getOwnPropertyDescriptor(window, 'CanvasRenderingContext2D') is 'object'
    2931PASS typeof Object.getOwnPropertyDescriptor(window, 'CharacterData') is 'object'

  • trunk/LayoutTests/platform/qt/fast/dom/prototype-inheritance-expected.txt

    r60625 r61071  
    4444PASS inner.CSSVariablesRule.isInner is true
    4545PASS inner.CSSVariablesRule.constructor.isInner is true
     46PASS inner.CanvasGradient.isInner is true
     47PASS inner.CanvasGradient.constructor.isInner is true
     48PASS inner.CanvasPattern.isInner is true
     49PASS inner.CanvasPattern.constructor.isInner is true
    4650PASS inner.CanvasRenderingContext2D.isInner is true
    4751PASS inner.CanvasRenderingContext2D.constructor.isInner is true

  • trunk/LayoutTests/platform/qt/fast/js/global-constructors-expected.txt

    r60625 r61071  
    2424PASS CSSVariablesDeclaration.toString() is '[object CSSVariablesDeclarationConstructor]'
    2525PASS CSSVariablesRule.toString() is '[object CSSVariablesRuleConstructor]'
     26PASS CanvasGradient.toString() is '[object CanvasGradientConstructor]'
     27PASS CanvasPattern.toString() is '[object CanvasPatternConstructor]'
    2628PASS CanvasRenderingContext2D.toString() is '[object CanvasRenderingContext2DConstructor]'
    2729PASS CharacterData.toString() is '[object CharacterDataConstructor]'

  • trunk/WebCore/ChangeLog

    r61070 r61071  
     12010-06-12  Andreas Kling  <andreas.kling@nokia.com>
     2
     3        Reviewed by Darin Adler.
     4
     5        Window object should have CanvasGradient and CanvasPattern
     6        https://bugs.webkit.org/show_bug.cgi?id=40394
     7
     8        This fixes the following tests:
     9        - canvas/philip/tests/2d.gradient.object.return.html
     10        - canvas/philip/tests/2d.pattern.basic.type.html
     11
     12        * html/canvas/CanvasGradient.idl:
     13        * html/canvas/CanvasPattern.idl:
     14        * page/DOMWindow.idl:
     15
    1162010-06-12  Dan Bernstein  <mitz@apple.com>
    217

  • trunk/WebCore/html/canvas/CanvasGradient.idl

    r52534 r61071  
    2828    interface [
    2929        InterfaceUUID=bb1108ea-6b8c-4a08-894a-218628630cdb,
    30         ImplementationUUID=a2942ae6-2731-4286-98cc-9d5e79e20de1,
    31         OmitConstructor
     30        ImplementationUUID=a2942ae6-2731-4286-98cc-9d5e79e20de1
    3231    ] CanvasGradient {
    3332

  • trunk/WebCore/html/canvas/CanvasPattern.idl

    r52534 r61071  
    2828    interface [
    2929        InterfaceUUID=c2131348-6d8c-47b5-86cc-d41aff34ce15,
    30         ImplementationUUID=82f5d713-3d17-44dd-aa4a-7766fe345940,
    31         OmitConstructor
     30        ImplementationUUID=82f5d713-3d17-44dd-aa4a-7766fe345940
    3231    ] CanvasPattern {
    3332

  • trunk/WebCore/page/DOMWindow.idl

    r60902 r61071  
    449449        attribute [CustomGetter] HTMLOptionElementConstructor Option; // Usable with new operator
    450450
     451        attribute CanvasPatternConstructor CanvasPattern;
     452        attribute CanvasGradientConstructor CanvasGradient;
    451453        attribute CanvasRenderingContext2DConstructor CanvasRenderingContext2D;
    452454        attribute ImageDataConstructor ImageData;
Note: See TracChangeset for help on using the changeset viewer.