Changeset 61215 in webkit

Timestamp:

Jun 15, 2010 3:00:26 PM (14 years ago)

Author:

Simon Fraser

Message:

2010-06-15 Simon Fraser <Simon Fraser>

Reviewed by Dave Hyatt.

Garbage shown outside HTML if HTML is absolutely positioned
​https://bugs.webkit.org/show_bug.cgi?id=36163

Add a check that the root renderer (the document element's renderer) covers
the entire viewport before deciding that we don't need the RenderView
to paint its background. Fixes lack of painting with positioned, floated, and
display: table html elements.

Test: fast/repaint/positioned-document-element.html

• rendering/RenderView.cpp: (WebCore::RenderView::paintBoxDecorations):

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/repaint/positioned-document-element.html (added)
• LayoutTests/platform/mac/fast/repaint/positioned-document-element-expected.checksum (added)
• LayoutTests/platform/mac/fast/repaint/positioned-document-element-expected.png (added)
• LayoutTests/platform/mac/fast/repaint/positioned-document-element-expected.txt (added)
• WebCore/ChangeLog (modified) (1 diff)
• WebCore/rendering/RenderView.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2010-06-15  Simon Fraser  <simon.fraser@apple.com>
+
+        Reviewed by Dave Hyatt.
+
+        Garbage shown outside HTML if HTML is absolutely positioned
+        https://bugs.webkit.org/show_bug.cgi?id=36163
+        
+        Repaint test with a positioned html element.
+
+        * fast/repaint/positioned-document-element.html: Added.
+        * platform/mac/fast/repaint/positioned-document-element-expected.checksum: Added.
+        * platform/mac/fast/repaint/positioned-document-element-expected.png: Added.
+        * platform/mac/fast/repaint/positioned-document-element-expected.txt: Added.
+
 2010-06-15  Simon Fraser  <simon.fraser@apple.com>
 

trunk/WebCore/ChangeLog

@@ +1 @@
+2010-06-15  Simon Fraser  <simon.fraser@apple.com>
+
+        Reviewed by Dave Hyatt.
+
+        Garbage shown outside HTML if HTML is absolutely positioned
+        https://bugs.webkit.org/show_bug.cgi?id=36163
+        
+        Add a check that the root renderer (the document element's renderer) covers
+        the entire viewport before deciding that we don't need the RenderView
+        to paint its background. Fixes lack of painting with positioned, floated, and
+        display: table html elements.
+
+        Test: fast/repaint/positioned-document-element.html
+
+        * rendering/RenderView.cpp:
+        (WebCore::RenderView::paintBoxDecorations):
+
 2010-06-15  Simon Fraser  <simon.fraser@apple.com>
 

trunk/WebCore/rendering/RenderView.cpp

@@ -202 +202 @@
     }
 
+    bool rootFillsViewport = false;
+    if (RenderObject* rootRenderer = document()->documentElement()->renderer()) {
+        // The document element's renderer is currently forced to be a block, but may not always be.
+        RenderBox* rootBox = rootRenderer->isBox() ? toRenderBox(rootRenderer) : 0;
+        rootFillsViewport = rootBox && !rootBox->x() && !rootBox->y() && rootBox->width() >= width() && rootBox->height() >= height();
+    }
+    
     // If painting will entirely fill the view, no need to fill the background.
-    if (elt || rendererObscuresBackground(firstChild()) || !view())
+    if (elt || (rootFillsViewport && rendererObscuresBackground(firstChild())) || !view())
         return;