Changeset 61311 in webkit
- Timestamp:
- Jun 17, 2010 12:33:11 AM (14 years ago)
- Location:
- trunk
- Files:
-
- 4 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/LayoutTests/ChangeLog
r61309 r61311 1 2010-06-17 Robert Hogan <robert@webkit.org> 2 3 Reviewed by Kenneth Rohde Christiansen. 4 5 [Qt] NPP_SetWindow seems to not be called when TestNetscapePlugin is moved 6 7 https://bugs.webkit.org/show_bug.cgi?id=36702 8 9 setNPWindowIfNeeded() is called on paint() in PluginViewQt, which doesn't 10 work for DRT. So call it if we are in DRT mode and the window geometry 11 has changed. 12 13 Unskips plugins/reentrant-update-widget-positions.html 14 15 * platform/qt/Skipped: 16 1 17 2010-06-16 Hayato Ito <hayato@chromium.org> 2 18 -
trunk/LayoutTests/platform/qt/Skipped
r61303 r61311 429 429 plugins/geturlnotify-during-document-teardown.html 430 430 431 # ---- https://bugs.webkit.org/show_bug.cgi?id=36702432 plugins/reentrant-update-widget-positions.html433 431 # ---- plugins rendered in incorrect position 434 432 plugins/embed-attributes-style.html -
trunk/WebCore/ChangeLog
r61310 r61311 1 2010-06-17 Robert Hogan <robert@webkit.org> 2 3 Reviewed by Kenneth Rohde Christiansen. 4 5 [Qt] NPP_SetWindow seems to not be called when TestNetscapePlugin is moved 6 7 https://bugs.webkit.org/show_bug.cgi?id=36702 8 9 setNPWindowIfNeeded() is called on paint() in PluginViewQt, which doesn't 10 work for DRT. So call it if we are in DRT mode and the window geometry 11 has changed. 12 13 Unskips plugins/reentrant-update-widget-positions.html 14 15 * plugins/qt/PluginViewQt.cpp: 16 (WebCore::PluginView::updatePluginWidget): 17 1 18 2010-06-17 Simon Hausmann <simon.hausmann@nokia.com> 2 19 -
trunk/WebCore/plugins/qt/PluginViewQt.cpp
r58821 r61311 61 61 #include "Settings.h" 62 62 #include "npruntime_impl.h" 63 #include "qwebpage_p.h" 63 64 #include "runtime_root.h" 64 65 … … 122 123 m_hasPendingGeometryChange = true; 123 124 124 // in order to move/resize the plugin window at the same time as the125 // (i) in order to move/resize the plugin window at the same time as the 125 126 // rest of frame during e.g. scrolling, we set the window geometry 126 127 // in the paint() function, but as paint() isn't called when the 127 128 // plugin window is outside the frame which can be caused by a 128 129 // scroll, we need to move/resize immediately. 129 if (!m_windowRect.intersects(frameView->frameRect())) 130 // (ii) if we are running layout tests from DRT, paint() won't ever get called 131 // so we need to call setNPWindowIfNeeded() if window geometry has changed 132 if (!m_windowRect.intersects(frameView->frameRect()) 133 || (QWebPagePrivate::drtRun && platformPluginWidget() && (m_windowRect != oldWindowRect || m_clipRect != oldClipRect))) 130 134 setNPWindowIfNeeded(); 131 135
Note: See TracChangeset
for help on using the changeset viewer.