Changeset 61412 in webkit

Timestamp:

Jun 18, 2010 9:39:59 AM (14 years ago)

Author:

dumi@chromium.org

Message:

Remove some unnecessary checks that cause compiler warnings.
​https://bugs.webkit.org/show_bug.cgi?id=40772

Reviewed by Dimitri Glazkov.

• bindings/v8/custom/V8SQLResultSetRowListCustom.cpp:

(WebCore::V8SQLResultSetRowList::itemCallback):

• bindings/v8/npruntime.cpp:

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• bindings/v8/custom/V8SQLResultSetRowListCustom.cpp (modified) (2 diffs)
• bindings/v8/npruntime.cpp (modified) (1 diff)

trunk/WebCore/ChangeLog

@@ +1 @@
+2010-06-17  Dumitru Daniliuc  <dumi@chromium.org>
+
+        Reviewed by Dimitri Glazkov.
+
+        Remove some unnecessary checks that cause compiler warnings.
+        https://bugs.webkit.org/show_bug.cgi?id=40772
+
+        * bindings/v8/custom/V8SQLResultSetRowListCustom.cpp:
+        (WebCore::V8SQLResultSetRowList::itemCallback):
+        * bindings/v8/npruntime.cpp:
+
 2010-06-18  Mikhail Naganov  <mnaganov@chromium.org>
 

trunk/WebCore/bindings/v8/custom/V8SQLResultSetRowListCustom.cpp

@@ -57 +57 @@
 
     unsigned long index = args[0]->IntegerValue();
-    if (index < 0 || index >= rowList->length()) {
+    if (index >= rowList->length()) {
         V8Proxy::throwError(V8Proxy::RangeError, "Item index is out of range.");
         return v8::Undefined();
@@ -92 +92 @@
 
 #endif
-

trunk/WebCore/bindings/v8/npruntime.cpp

@@ -297 +297 @@
 {
     ASSERT(npObject);
-    ASSERT(npObject->referenceCount >= 0);
 
     if (npObject) {