Changeset 61986 in webkit

Timestamp:

Jun 28, 2010 1:15:58 AM (14 years ago)

Author:

abarth@webkit.org

Message:

2010-06-28 Adam Barth <​abarth@webkit.org>

Reviewed by Eric Seidel.

Add support for parsing attributes
​https://bugs.webkit.org/show_bug.cgi?id=41272

This patch lets use parse the following document:

<script src="data:text/javascript,alert('PASS')"></script>

• html/HTMLTreeBuilder.cpp: (WebCore::HTMLTreeBuilder::constructTreeFromToken): (WebCore::HTMLTreeBuilder::insertHTMLStartTagBeforeHTML): (WebCore::HTMLTreeBuilder::insertScriptElement): (WebCore::HTMLTreeBuilder::createElement):

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• html/HTMLTreeBuilder.cpp (modified) (3 diffs)

trunk/WebCore/ChangeLog

@@ +1 @@
+2010-06-28  Adam Barth  <abarth@webkit.org>
+
+        Reviewed by Eric Seidel.
+
+        Add support for parsing attributes
+        https://bugs.webkit.org/show_bug.cgi?id=41272
+
+        This patch lets use parse the following document:
+
+        <script src="data:text/javascript,alert('PASS')"></script>
+
+        * html/HTMLTreeBuilder.cpp:
+        (WebCore::HTMLTreeBuilder::constructTreeFromToken):
+        (WebCore::HTMLTreeBuilder::insertHTMLStartTagBeforeHTML):
+        (WebCore::HTMLTreeBuilder::insertScriptElement):
+        (WebCore::HTMLTreeBuilder::createElement):
+
 2010-06-28  Eric Seidel  <eric@webkit.org>
 

trunk/WebCore/html/HTMLTreeBuilder.cpp

@@ -273 +273 @@
 }
 
-void HTMLTreeBuilder::insertHTMLStartTagBeforeHTML(AtomicHTMLToken&)
+void HTMLTreeBuilder::insertHTMLStartTagBeforeHTML(AtomicHTMLToken& token)
 {
     RefPtr<Element> element = HTMLHtmlElement::create(m_document);
-    // FIXME: Add attributes to |element|.
+    element->setAttributeMap(token.attributes(), m_fragmentScriptingPermission);
     m_document->addChild(element);
     m_openElements.push(element.release());
@@ -840 +840 @@
     ASSERT_UNUSED(token, token.type() == HTMLToken::StartTag);
     RefPtr<HTMLScriptElement> element = HTMLScriptElement::create(scriptTag, m_document, true);
+    element->setAttributeMap(token.attributes(), m_fragmentScriptingPermission);
     currentElement()->addChild(element);
     m_openElements.push(element.release());
@@ -849 +850 @@
 PassRefPtr<Element> HTMLTreeBuilder::createElement(AtomicHTMLToken& token)
 {
-    return HTMLElementFactory::createHTMLElement(QualifiedName(nullAtom, token.name(), xhtmlNamespaceURI), m_document, 0);
+    RefPtr<Element> element = HTMLElementFactory::createHTMLElement(QualifiedName(nullAtom, token.name(), xhtmlNamespaceURI), m_document, 0);
+    element->setAttributeMap(token.attributes(), m_fragmentScriptingPermission);
+    return element.release();
 }