Changeset 62006 in webkit

Timestamp:

Jun 28, 2010 8:08:02 AM (14 years ago)

Author:

commit-queue@webkit.org

Message:

2010-06-28 Lucas De Marchi <​lucas.demarchi@profusion.mobi>

Reviewed by Kenneth Rohde Christiansen.

[EFL] Implement download requests
When a download request arrives through FrameLoaderClient, forward it to
browser in order to be possible to download files.
​https://bugs.webkit.org/show_bug.cgi?id=40967

• efl/WebCoreSupport/FrameLoaderClientEfl.cpp: (WebCore::FrameLoaderClientEfl::download): get file names and forward to ewk_view_download_request()
• efl/ewk/ewk_private.h: export private function to WebCoreSupport

Location:

trunk/WebKit

Files:

• ChangeLog (modified) (1 diff)
• efl/WebCoreSupport/FrameLoaderClientEfl.cpp (modified) (1 diff)
• efl/ewk/ewk_private.h (modified) (1 diff)

trunk/WebKit/ChangeLog

@@ +1 @@
+2010-06-28  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
+
+        Reviewed by Kenneth Rohde Christiansen.
+
+        [EFL] Implement download requests
+        When a download request arrives through FrameLoaderClient, forward it to
+        browser in order to be possible to download files.
+        https://bugs.webkit.org/show_bug.cgi?id=40967
+
+        * efl/WebCoreSupport/FrameLoaderClientEfl.cpp:
+        (WebCore::FrameLoaderClientEfl::download): get file names and
+        forward to ewk_view_download_request()
+        * efl/ewk/ewk_private.h: export private function to WebCoreSupport
+
 2010-06-25  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
 

trunk/WebKit/efl/WebCoreSupport/FrameLoaderClientEfl.cpp

@@ -750 +750 @@
 }
 
-void FrameLoaderClientEfl::download(ResourceHandle*, const ResourceRequest&, const ResourceRequest&, const ResourceResponse&)
-{
-    notImplemented();
+void FrameLoaderClientEfl::download(ResourceHandle*, const ResourceRequest& request, const ResourceRequest&, const ResourceResponse&)
+{
+    if (!m_view)
+        return;
+
+    CString url = request.url().prettyURL().utf8();
+    Ewk_Download download;
+
+    download.url = url.data();
+    ewk_view_download_request(m_view, &download);
 }
 

trunk/WebKit/efl/ewk/ewk_private.h

@@ -97 +97 @@
 void             ewk_view_popup_new(Evas_Object *o, WebCore::PopupMenuClient* client, int selected, const WebCore::IntRect& rect);
 
+void             ewk_view_download_request(Evas_Object *o, Ewk_Download *download);
+
 Ewk_History      *ewk_history_new(WebCore::BackForwardList *history);
 void              ewk_history_free(Ewk_History *history);