Changeset 62076 in webkit
- Timestamp:
- Jun 28, 2010 7:00:09 PM (14 years ago)
- Location:
- trunk
- Files:
-
- 1 added
- 9 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/LayoutTests/ChangeLog
r62051 r62076 1 2010-06-28 Adam Barth <abarth@webkit.org> 2 3 Reviewed by Eric Seidel. 4 5 Fix ASSERT so we can run more HTML5lib tests 6 https://bugs.webkit.org/show_bug.cgi?id=41325 7 8 Uncomment <title> tag that was triggering ASSERT. 9 Uncomment test groups that were triggering ASSERTs. 10 Update expected results to show how many more tests we have left to 11 fix. :) 12 13 * html5lib/webkit-runner-expected-html5.txt: 14 * html5lib/webkit-runner.html: 15 1 16 2010-06-28 Adam Barth <abarth@webkit.org> 2 17 -
trunk/LayoutTests/html5lib/webkit-runner-expected-html5.txt
r62051 r62076 2 2 CONSOLE MESSAGE: line 2: FOO<span>BAR</span>BAZ 3 3 Content-Type: text/plain 4 resources/tests2.dat: 5 3 6 4 7 8 8 9 9 10 10 11 11 13 12 14 13 17 14 18 15 19 16 20 17 21 18 22 19 24 20 25 21 26 22 27 23 29 24 32 25 33 26 34 27 35 28 36 29 37 30 40 31 42 32 46 33 47 34 48 35 49 36 50 37 51 38 52 39 53 40 54 41 55 42 57 43 58 44 45 resources/tests3.dat: 46 1 47 2 48 3 49 16 50 17 51 18 52 19 53 20 54 21 55 22 56 57 resources/tests4.dat: 58 3 59 5 60 6 61 7 62 63 resources/tests6.dat: 64 1 65 2 66 6 67 8 68 9 69 10 70 11 71 12 72 13 73 14 74 15 75 16 76 17 77 19 78 20 79 22 80 23 81 24 82 26 83 27 84 28 85 30 86 33 87 36 88 37 89 38 90 40 91 41 92 42 93 44 94 45 95 46 96 47 97 48 98 49 99 51 100 101 resources/tests7.dat: 102 2 103 3 104 4 105 5 106 6 107 7 108 8 109 9 110 10 111 13 112 14 113 15 114 16 115 17 116 18 117 19 118 20 119 21 120 24 121 25 122 26 123 27 124 28 125 29 126 30 127 128 resources/tests8.dat: 129 1 130 2 131 3 132 4 133 5 134 6 135 7 136 8 137 9 138 139 resources/tests11.dat: 140 1 141 2 142 3 143 4 144 5 145 6 146 7 147 8 148 9 149 150 resources/tests12.dat: 151 1 152 2 153 154 resources/tests14.dat: 155 3 156 6 157 158 resources/tests16.dat: 159 3 160 4 161 5 162 6 163 7 164 8 165 9 166 10 167 12 168 13 169 14 170 15 171 16 172 17 173 25 174 27 175 28 176 42 177 44 178 45 179 56 180 57 181 58 182 97 183 98 184 99 185 100 186 101 187 102 188 103 189 104 190 106 191 107 192 108 193 109 194 110 195 111 196 119 197 121 198 122 199 136 200 138 201 139 202 148 203 149 204 150 205 187 206 188 207 189 208 4 209 resources/webkit01.dat: 5 210 15 -
trunk/LayoutTests/html5lib/webkit-runner.html
r62051 r62076 21 21 THE SOFTWARE. 22 22 --> 23 < !-- <title>html5lib test runner</title> -->23 <title>html5lib test runner</title> 24 24 <script src=resources/dom2string.js></script> 25 25 <script> … … 40 40 var test_files = [ 41 41 // 'resources/tests1.dat', 42 //'resources/tests2.dat',43 //'resources/tests3.dat',44 //'resources/tests4.dat',42 'resources/tests2.dat', 43 'resources/tests3.dat', 44 'resources/tests4.dat', 45 45 // 'resources/tests5.dat', 46 //'resources/tests6.dat',47 //'resources/tests7.dat',48 //'resources/tests8.dat',46 'resources/tests6.dat', 47 'resources/tests7.dat', 48 'resources/tests8.dat', 49 49 // 'resources/tests9.dat', 50 50 // 'resources/tests10.dat', 51 //'resources/tests11.dat',52 //'resources/tests12.dat',53 //'resources/tests14.dat',51 'resources/tests11.dat', 52 'resources/tests12.dat', 53 'resources/tests14.dat', 54 54 // 'resources/tests15.dat', 55 //'resources/tests16.dat',55 'resources/tests16.dat', 56 56 'resources/webkit01.dat', 57 57 'resources/doctype01.dat', -
trunk/WebCore/ChangeLog
r62073 r62076 1 2010-06-28 Adam Barth <abarth@webkit.org> 2 3 Reviewed by Eric Seidel. 4 5 Fix ASSERT so we can run more HTML5lib tests 6 https://bugs.webkit.org/show_bug.cgi?id=41325 7 8 We can't call Node::addChild because that function contains a bunch of 9 logic from the old parser. Instead, this patch creates a new version 10 of addChild that's does less validating (that's the tree builder's 11 job). 12 13 * dom/ContainerNode.cpp: 14 (WebCore::ContainerNode::parserAddChild): 15 * dom/ContainerNode.h: 16 * dom/Node.cpp: 17 (WebCore::Node::parserAddChild): 18 * dom/Node.h: 19 * html/HTMLTreeBuilder.h: 20 (WebCore::HTMLTreeBuilder::attach): 21 1 22 2010-06-28 David Levin <levin@chromium.org> 2 23 -
trunk/WebCore/dom/ContainerNode.cpp
r60943 r62076 538 538 } 539 539 540 void ContainerNode::parserAddChild(PassRefPtr<Node> newChild) 541 { 542 ASSERT(newChild); 543 // This function is only used during parsing. 544 // It does not send any DOM mutation events. 545 546 forbidEventDispatch(); 547 Node* last = m_lastChild; 548 appendChildToContainer<Node, ContainerNode>(newChild.get(), this); 549 allowEventDispatch(); 550 551 document()->incDOMTreeVersion(); 552 if (inDocument()) 553 newChild->insertedIntoDocument(); 554 childrenChanged(true, last, 0, 1); 555 } 556 540 557 ContainerNode* ContainerNode::addChild(PassRefPtr<Node> newChild) 541 558 { -
trunk/WebCore/dom/ContainerNode.h
r49208 r62076 50 50 51 51 virtual ContainerNode* addChild(PassRefPtr<Node>); 52 virtual void parserAddChild(PassRefPtr<Node>); 53 52 54 bool hasChildNodes() const { return m_firstChild; } 53 55 virtual void attach(); -
trunk/WebCore/dom/Node.cpp
r61777 r62076 645 645 } 646 646 647 void Node::parserAddChild(PassRefPtr<Node>) 648 { 649 ASSERT_NOT_REACHED(); 650 } 651 647 652 bool Node::isContentEditable() const 648 653 { -
trunk/WebCore/dom/Node.h
r61777 r62076 266 266 // Returns the appropriate container node for future insertions as you parse, or 0 for failure. 267 267 virtual ContainerNode* addChild(PassRefPtr<Node>); 268 // addChild is tied into the logic of the LegacyHTMLTreeBuilder. We need 269 // a "clean" version to use for the HTML5 version of the HTMLTreeBuilder. 270 virtual void parserAddChild(PassRefPtr<Node>); 268 271 269 272 // Called by the parser when this element's close tag is reached, -
trunk/WebCore/html/HTMLTreeBuilder.h
r62045 r62076 182 182 { 183 183 RefPtr<ChildType> child = prpChild; 184 parent-> addChild(child);184 parent->parserAddChild(child); 185 185 // It's slightly unfortunate that we need to hold a reference to child 186 186 // here to call attach(). We should investigate whether we can rely on
Note: See TracChangeset
for help on using the changeset viewer.